From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752442AbbL0QYg (ORCPT <rfc822;w@1wt.eu>);
	Sun, 27 Dec 2015 11:24:36 -0500
Received: from mout.web.de ([212.227.15.14]:61043 "EHLO mout.web.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751129AbbL0QYU (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Sun, 27 Dec 2015 11:24:20 -0500
Subject: Re: [Cocci] [PATCH v2] coccinelle: api: check for propagation of
 error from platform_get_irq
To: Julia Lawall <julia.lawall@lip6.fr>
References: <1451157891-24881-1-git-send-email-Julia.Lawall@lip6.fr>
 <567EF188.7020203@cogentembedded.com>
 <alpine.DEB.2.02.1512262107340.2070@localhost6.localdomain6>
 <alpine.DEB.2.02.1512262123500.2070@localhost6.localdomain6>
 <567EF895.6080702@cogentembedded.com>
 <alpine.DEB.2.02.1512262156580.2070@localhost6.localdomain6>
 <567F9A29.50202@users.sourceforge.net>
 <alpine.DEB.2.02.1512271239460.2038@localhost6.localdomain6>
Cc: Coccinelle <cocci@systeme.lip6.fr>, LKML <linux-kernel@vger.kernel.org>,
        kernel-janitors@vger.kernel.org, linux-media@vger.kernel.org,
        netdev@vger.kernel.org, linux-i2c@vger.kernel.org,
        linux-spi@vger.kernel.org, dri-devel@lists.freedesktop.org,
        Gilles Muller <Gilles.Muller@lip6.fr>, Michal Marek <mmarek@suse.com>,
        Nicolas Palix <nicolas.palix@imag.fr>,
        Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
From: SF Markus Elfring <elfring@users.sourceforge.net>
X-Enigmail-Draft-Status: N1110
Message-ID: <568010A2.3000902@users.sourceforge.net>
Date: Sun, 27 Dec 2015 17:24:02 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.02.1512271239460.2038@localhost6.localdomain6>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:pyTDCpTlsDo4SGSK87hEL3kQ5OLN71W5Cp9e2YqrVPlPI4r1g9z
 /2vbAAme1SQXj44oa1CC/duq9S6p+sjl+9wnic3Q3LBCWo3/ZmcNIoWT/KdiJGYfsARx3tR
 P/2slBLIjWwNAN4lD6NgNRMAsidOWa0qVo0bIlLa6f847NyOL11Ii64bPxmz+VN3jAwFImj
 4ccikQ6gswcWlMfv/AUXQ==
X-UI-Out-Filterresults: notjunk:1;V01:K0:g2Q1lxgx964=:h3WzSFuwzHtYtlqyvLP2iu
 s3vQC7gcZonX1pbt/n31OGoTK6UreMXZjksqc9OaQnNHyZfbYrCZkLeFRze6aH85lwzasv+Ln
 CkCcd/eIVeMYpmcoVHWmGH2OeWIbf94P+EP59CtKWPGOoQzHA1Wo391wYOHcZ44WLCkd4MmOq
 wpr/lCn5Ed+dyPjbUzcIudtd94ZqJH/pVqPnKsc5fac0EWxshjhggQOIsWxMEtKJEfHMX1EOz
 pXhkpusQbwwS3FNIWqOZuJv5UA01MnRgG+fhowsytvrb5/c9HzURnXV8p4DtErb6T1gLG7ND8
 dsSJehjSOonJomQ+PolHIYH8V1cr/bUSBZKcX3pq+5lHtyqA7Y6Pe4qtBW9PPTzZsFhMTgRDP
 3xsrWP5j3nrpZXVUlgdUGvCNuV6sED2pSQumL4sb7C7n2ey7qdUaO32C4QDmAkVKDGpZcca9x
 69H/bdRIw6jDB5IbTjq5zJY6eSU/PO3zFn9CZJPuk+0bp3hwHTURLMsSylu/94M6a4ngjIYta
 GcTvooeq/9WTwY/b4fMMTliz1GaeRwLZK9NnKwJCBjfz3Y/gZbbobCeDUimG+15vGqPjFPeeN
 ouKdDqN1q3uo8jfOGCuncCds4wmIO77dyZ1RBBf9fIZOOGMwX+J8VCPRKp6w/3ZhxG+n7W91t
 0QP7PInvIcfBdwAQJCvDVOViY5GFEscFrOYRwMKzD8kpEv/C+N/y2DfN+pKRJeupZXKLNuFjG
 OCpRUBj3Fzz71rm3+jjyirGsbAsNa16KijT1ch5GB3n/V3MdRcaIZFLsNDeg9uhFY2Qx4t40H
 a3Jyt/o
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> https://cwe.mitre.org/data/definitions/252.html
> 
> The value is not unchecked.

Would you like to express any stronger relationship between
the function call example and the occurrence of an if statement
by the discussed SmPL script?


> I made a specific rule because the specific problem is quite common.

Can it become also interesting to generalise this search pattern?

Regards,
Markus