From: Milo Kim <milo.kim@ti.com>
To: Paul Kocialkowski <contact@paulk.fr>
Cc: linux-kernel@vger.kernel.org, "Rob Herring" <robh+dt@kernel.org>,
"Pawel Moll" <pawel.moll@arm.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
"Kumar Gala" <galak@codeaurora.org>,
"Russell King" <linux@arm.linux.org.uk>,
"Benoît Cousson" <bcousson@baylibre.com>,
"Tony Lindgren" <tony@atomide.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-omap@vger.kernel.org
Subject: Re: [PATCH 2/6] regulator: lp872x: Get rid of duplicate reference to DVS GPIO
Date: Mon, 28 Dec 2015 10:05:27 +0900 [thread overview]
Message-ID: <56808AD7.9080305@ti.com> (raw)
In-Reply-To: <1450868319-20513-3-git-send-email-contact@paulk.fr>
On 23/12/15 19:58, Paul Kocialkowski wrote:
> The lp872x structure holds a reference to the DVS GPIO, but it is never actually
> used anywhere, since a first reference exists from the lp872x_dvs structure.
>
> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
Acked-by: Milo Kim <milo.kim@ti.com>
> ---
> drivers/regulator/lp872x.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/regulator/lp872x.c b/drivers/regulator/lp872x.c
> index 9412353..19d7584 100644
> --- a/drivers/regulator/lp872x.c
> +++ b/drivers/regulator/lp872x.c
> @@ -108,7 +108,6 @@ struct lp872x {
> struct lp872x_platform_data *pdata;
> int num_regulators;
> enum lp872x_dvs_state dvs_pin;
> - int dvs_gpio;
> };
>
> /* LP8720/LP8725 shared voltage table for LDOs */
> @@ -752,7 +751,6 @@ static int lp872x_init_dvs(struct lp872x *lp)
> }
>
> lp->dvs_pin = pinstate;
> - lp->dvs_gpio = gpio;
>
> return 0;
>
>
next prev parent reply other threads:[~2015-12-28 1:05 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-23 10:58 [PATCH 0/6] LG Optimus Black (P970) codename sniper support and lp872x improvements Paul Kocialkowski
2015-12-23 10:58 ` [PATCH 1/6] regulator: lp872x: Add missing of_match in regulators descriptions Paul Kocialkowski
2015-12-23 12:13 ` Applied "regulator: lp872x: Add missing of_match in regulators descriptions" to the regulator tree Mark Brown
2015-12-28 1:04 ` [PATCH 1/6] regulator: lp872x: Add missing of_match in regulators descriptions Milo Kim
2015-12-23 10:58 ` [PATCH 2/6] regulator: lp872x: Get rid of duplicate reference to DVS GPIO Paul Kocialkowski
2015-12-23 12:13 ` Applied "regulator: lp872x: Get rid of duplicate reference to DVS GPIO" to the regulator tree Mark Brown
2015-12-28 1:05 ` Milo Kim [this message]
2015-12-23 10:58 ` [PATCH 3/6] regulator: lp872x: Remove warning about invalid DVS GPIO Paul Kocialkowski
2015-12-23 11:41 ` Mark Brown
2015-12-23 11:50 ` Paul Kocialkowski
2015-12-23 11:58 ` Mark Brown
2015-12-23 10:58 ` [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Paul Kocialkowski
2015-12-23 11:56 ` Mark Brown
2015-12-23 12:52 ` Paul Kocialkowski
2015-12-24 18:12 ` Paul Kocialkowski
2015-12-24 19:35 ` Mark Brown
2015-12-24 20:05 ` Paul Kocialkowski
2015-12-28 0:56 ` Milo Kim
2015-12-28 22:49 ` Paul Kocialkowski
2015-12-29 0:45 ` Milo Kim
2015-12-29 11:13 ` Paul Kocialkowski
2015-12-30 0:22 ` Milo Kim
2015-12-30 8:35 ` Paul Kocialkowski
2015-12-30 16:33 ` Mark Brown
2015-12-30 18:37 ` Paul Kocialkowski
2015-12-31 21:40 ` Mark Brown
2015-12-31 21:59 ` Paul Kocialkowski
2015-12-31 22:14 ` Mark Brown
2016-01-03 10:19 ` Paul Kocialkowski
2016-01-16 7:32 ` Paul Kocialkowski
2016-01-18 16:32 ` Mark Brown
2016-02-05 18:48 ` Paul Kocialkowski
2015-12-28 0:34 ` Milo Kim
2016-02-05 18:49 ` Paul Kocialkowski
2015-12-29 20:02 ` Rob Herring
2015-12-29 21:26 ` Paul Kocialkowski
2015-12-29 21:55 ` Rob Herring
2016-02-05 18:48 ` Paul Kocialkowski
2015-12-23 10:58 ` [PATCH 5/6] ARM: LG Optimus Black (P970) codename sniper support, with basic features Paul Kocialkowski
2015-12-23 15:44 ` Tony Lindgren
2015-12-24 19:38 ` Paul Kocialkowski
2015-12-23 16:03 ` Javier Martinez Canillas
2015-12-24 19:38 ` Paul Kocialkowski
2015-12-23 10:58 ` [PATCH 6/6] ARM: multi_v7_defconfig: Enable LP872x regulator support Paul Kocialkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56808AD7.9080305@ti.com \
--to=milo.kim@ti.com \
--cc=bcousson@baylibre.com \
--cc=broonie@kernel.org \
--cc=contact@paulk.fr \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).