From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752735AbbL1UiG (ORCPT <rfc822;w@1wt.eu>);
	Mon, 28 Dec 2015 15:38:06 -0500
Received: from out21.biz.mail.alibaba.com ([205.204.114.132]:57361 "EHLO
	out21.biz.mail.alibaba.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1752437AbbL1UiE (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 28 Dec 2015 15:38:04 -0500
X-Alimail-AntiSpam: AC=CONTINUE;BC=0.1024427|-1;FP=0|0|0|0|0|-1|-1|-1;HT=e01l10450;MF=chengang@emindsoft.com.cn;NM=1;PH=DS;RN=12;RT=11;SR=0;TI=SMTPD_----4OrxuSk_1451335034;
Message-ID: <56819E3B.20506@emindsoft.com.cn>
Date: Tue, 29 Dec 2015 04:40:27 +0800
From: Chen Gang <chengang@emindsoft.com.cn>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Joerg Roedel <joro@8bytes.org>
CC: akpm@linux-foundation.org, oded.gabbay@gmail.com, airlied@linux.ie,
        joe@perches.com, jslaby@suse.com, gregkh@linuxfoundation.org,
        davem@davemloft.net, mchehab@osg.samsung.com,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] include/linux/amd-iommu.h: Move to arch/x86/include/asm
References: <1451136392-22638-1-git-send-email-chengang@emindsoft.com.cn> <20151228155153.GM18805@8bytes.org>
In-Reply-To: <20151228155153.GM18805@8bytes.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/28/15 23:51, Joerg Roedel wrote:
> On Sat, Dec 26, 2015 at 09:26:32PM +0800, chengang@emindsoft.com.cn wrote:
>>
>> It is architecture specific mechanism header, not generic header, so
>> move it to arch/x86/include/asm.
> 
> There might be future non-x86 hardware which also has an amd iommu, so
> the header file should stay where it is for now.
>

For me, amd-iommu.h is architecture specific, for this kind of headers,
if it is used by most of archs, it will be in "include/asm-generic". If
it is used by several archs, it will be in "arch/*/include/asm/".

So for me, at present, it is only used by x86, so is move to "arch/x86/
include/asm/"; if another archs want it, they can copy one.  If quite a
few archs (e.g. > 3 archs) need it, move it to "include/asm-generic".


Thanks.
-- 
Chen Gang (陈刚)

Open, share, and attitude like air, water, and life which God blessed