From: Keith Owens <kaos@ocs.com.au>
To: Mark Orr <markorr@intersurf.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [2.4.15pre6] Funny error on "make modules_install" - cosmetic cleanup probably needed
Date: Mon, 19 Nov 2001 23:44:50 +1100 [thread overview]
Message-ID: <5682.1006173890@ocs3.intra.ocs.com.au> (raw)
In-Reply-To: Your message of "Mon, 19 Nov 2001 02:32:58 MDT." <20011119023258.4bb705b0.markorr@intersurf.com>
On Mon, 19 Nov 2001 02:32:58 -0600,
Mark Orr <markorr@intersurf.com> wrote:
>make[2]: Entering directory `/usr/src/linux/drivers/cdrom'
>mkdir -p /lib/modules/2.4.15-pre6/kernel/drivers/cdrom/
>cp cdrom.o cdrom.o /lib/modules/2.4.15-pre6/kernel/drivers/cdrom/
>cp: will not overwrite just-created `/lib/modules/2.4.15-pre6/kernel/drivers/cdrom/cdrom.o' with `cdrom.o'
There are several places where a module gets installed twice, because
of the way that module objects are selected in 2.4 (2.5 does not have
this feature). The fix is easy but it should not be necessary. IMNSHO
it is *wrong* for fileutils to decide that it will not copy a file
twice, cp should do what the user asked. Complain to the fileutils
maintainer as a first step.
Work around for unexpected cp behaviour, against 2.4.14, untested.
Index: 14.1/Rules.make
--- 14.1/Rules.make Wed, 07 Mar 2001 23:04:43 +1100 kaos (linux-2.4/T/c/47_Rules.make 1.1.2.2 644)
+++ 14.1(w)/Rules.make Mon, 19 Nov 2001 23:42:58 +1100 kaos (linux-2.4/T/c/47_Rules.make 1.1.2.2 644)
@@ -173,7 +173,7 @@ modules: $(ALL_MOBJS) dummy \
_modinst__: dummy
ifneq "$(strip $(ALL_MOBJS))" ""
mkdir -p $(MODLIB)/kernel/$(MOD_DESTDIR)
- cp $(ALL_MOBJS) $(MODLIB)/kernel/$(MOD_DESTDIR)$(MOD_TARGET)
+ cp $(sort $(ALL_MOBJS)) $(MODLIB)/kernel/$(MOD_DESTDIR)$(MOD_TARGET)
endif
.PHONY: modules_install
next prev parent reply other threads:[~2001-11-19 12:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-19 8:32 [2.4.15pre6] Funny error on "make modules_install" - cosmetic cleanup probably needed Mark Orr
2001-11-19 12:44 ` Keith Owens [this message]
2001-11-21 14:00 ` Todd M. Roy
2001-11-22 16:39 ` Jim Meyering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5682.1006173890@ocs3.intra.ocs.com.au \
--to=kaos@ocs.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=markorr@intersurf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox