From: "Matias Bjørling" <mb@lightnvm.io>
To: Wenwei Tao <ww.tao0320@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: [PATCH] lightnvm: check bi_error in gc
Date: Tue, 29 Dec 2015 10:37:10 +0100 [thread overview]
Message-ID: <56825446.70902@lightnvm.io> (raw)
In-Reply-To: <1451368212-20076-1-git-send-email-ww.tao0320@gmail.com>
On 12/29/2015 06:50 AM, Wenwei Tao wrote:
> We should check last io compeltion status before
> start another one.
>
> Signed-off-by: Wenwei Tao <ww.tao0320@gmail.com>
> ---
> drivers/lightnvm/rrpc.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/lightnvm/rrpc.c b/drivers/lightnvm/rrpc.c
> index c0886a8..d40c140 100644
> --- a/drivers/lightnvm/rrpc.c
> +++ b/drivers/lightnvm/rrpc.c
> @@ -328,6 +328,10 @@ try:
> goto finished;
> }
> wait_for_completion_io(&wait);
> + if (bio->bi_error) {
> + rrpc_inflight_laddr_release(rrpc, rqd);
> + goto finished;
> + }
>
> bio_reset(bio);
> reinit_completion(&wait);
> @@ -350,6 +354,8 @@ try:
> wait_for_completion_io(&wait);
>
> rrpc_inflight_laddr_release(rrpc, rqd);
> + if (bio->bi_error)
> + goto finished;
>
> bio_reset(bio);
> }
>
Thanks Tao. I've applied it for 4.5.
prev parent reply other threads:[~2015-12-29 9:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-29 5:50 [PATCH] lightnvm: check bi_error in gc Wenwei Tao
2015-12-29 9:37 ` Matias Bjørling [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56825446.70902@lightnvm.io \
--to=mb@lightnvm.io \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ww.tao0320@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox