From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: Willy Tarreau <w@1wt.eu>, "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Eric Dumazet <edumazet@google.com>,
socketpair@gmail.com
Subject: Re: [PATCH] unix: properly account for FDs passed over unix sockets
Date: Tue, 29 Dec 2015 15:37:39 +0100 [thread overview]
Message-ID: <56829AB3.9000607@stressinduktion.org> (raw)
In-Reply-To: <20151228141435.GA13351@1wt.eu>
On 28.12.2015 15:14, Willy Tarreau wrote:
> @@ -1528,10 +1546,8 @@ static int unix_attach_fds(struct scm_cookie *scm, struct sk_buff *skb)
> if (!UNIXCB(skb).fp)
> return -ENOMEM;
>
> - if (unix_sock_count) {
> - for (i = scm->fp->count - 1; i >= 0; i--)
> - unix_inflight(scm->fp->fp[i]);
> - }
> + for (i = scm->fp->count - 1; i >= 0; i--)
> + unix_inflight(scm->fp->fp[i]);
> return max_level;
You seem to be able to remove the unix_sock_count variable altogether now.
Bye,
Hannes
next prev parent reply other threads:[~2015-12-29 14:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-28 14:14 [PATCH] unix: properly account for FDs passed over unix sockets Willy Tarreau
2015-12-29 14:37 ` Hannes Frederic Sowa [this message]
2015-12-29 14:48 ` Hannes Frederic Sowa
2015-12-29 20:35 ` Willy Tarreau
2015-12-30 8:58 ` Hannes Frederic Sowa
2015-12-30 11:23 ` Willy Tarreau
2015-12-30 13:14 ` One Thousand Gnomes
2015-12-31 6:08 ` Tetsuo Handa
2015-12-31 7:12 ` Willy Tarreau
2015-12-31 10:27 ` One Thousand Gnomes
2016-01-04 21:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56829AB3.9000607@stressinduktion.org \
--to=hannes@stressinduktion.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=socketpair@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox