From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753511AbbL2QBf (ORCPT ); Tue, 29 Dec 2015 11:01:35 -0500 Received: from mail-lf0-f48.google.com ([209.85.215.48]:36703 "EHLO mail-lf0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753285AbbL2QBc (ORCPT ); Tue, 29 Dec 2015 11:01:32 -0500 Subject: Re: [PATCH 5/5] usb: dwc2: gadget: free TX FIFO after killing requests To: Robert Baldyga , balbi@ti.com, johnyoun@synopsys.com References: <1451319928-21250-1-git-send-email-r.baldyga@samsung.com> <1451319928-21250-6-git-send-email-r.baldyga@samsung.com> Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, m.szyprowski@samsung.com, b.zolnierkie@samsung.com From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <5682AE57.5000505@cogentembedded.com> Date: Tue, 29 Dec 2015 19:01:27 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1451319928-21250-6-git-send-email-r.baldyga@samsung.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 12/28/2015 07:25 PM, Robert Baldyga wrote: > As kill_all_requests() potentially flushes TX FIFO, we should should > free FIFO after calling it. Otherwise FIFO could stay unflushed properly. > > Signed-off-by: Robert Baldyga > --- > drivers/usb/dwc2/gadget.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c > index fadd635..e14d076 100644 > --- a/drivers/usb/dwc2/gadget.c > +++ b/drivers/usb/dwc2/gadget.c > @@ -2779,10 +2779,6 @@ static int dwc2_hsotg_ep_disable(struct usb_ep *ep) > > spin_lock_irqsave(&hsotg->lock, flags); > > - hsotg->fifo_map &= ~(1<fifo_index); > - hs_ep->fifo_index = 0; > - hs_ep->fifo_size = 0; > - > ctrl = dwc2_readl(hsotg->regs + epctrl_reg); > ctrl &= ~DXEPCTL_EPENA; > ctrl &= ~DXEPCTL_USBACTEP; > @@ -2797,6 +2793,10 @@ static int dwc2_hsotg_ep_disable(struct usb_ep *ep) > /* terminate all requests with shutdown */ > kill_all_requests(hsotg, hs_ep, -ESHUTDOWN); > > + hsotg->fifo_map &= ~(1<fifo_index); Please enclose << in spaces for consistency with the other code, and with the kernel coding style in general. [...] MBR, Sergei