[PATCH 1/1] kernel booting messages, first line

[PATCH 1/1] kernel booting messages, first line

[Alexandru GOIA]

For -rc8 ,

Hoping that someone DO cares about the aesthetic of kernel messages at boot :

 
What it does : first line of booting kernel, as seen in dmesg(1), will be the Linux kernel signature
(version, compiler, compiler hostname).

What it solves : it appers ahead of cgroup messages at booting.


This ugliness, since 3.10.x kernel.


So :

Instead of the unaesthetic lines :

Initializing cgroup subsys cpuset
Initializing cgroup subsys cpu
Initializing cgroup subsys cpuacct
Linux version 4 ...


... We will have :


Linux version 4 ...
Initializing cgroup subsys cpuset
Initializing cgroup subsys cpu
Initializing cgroup subsys cpuacct


As normal .


In file linux-4.4-rc7/init/main.c  :

<code>

--- main.c      2015-12-28 04:17:37.000000000 +0200
+++ main+.c     2015-12-29 03:18:59.896820046 +0200
@@ -512,6 +512,7 @@
          * Set up the the initial canary ASAP:
          */
         boot_init_stack_canary();
+       pr_notice("%s", linux_banner);
 
         cgroup_init_early();
 
@@ -524,7 +525,6 @@
  */
         boot_cpu_init();
         page_address_init();
-       pr_notice("%s", linux_banner);
         setup_arch(&command_line);
         mm_init_cpumask(&init_mm);
         setup_command_line(command_line);

</code>


Signed-off-by: Alexandru Goia <alexandru.goia@cti.pub.ro>

Re: [PATCH 1/1] kernel booting messages, first line

[Randy Dunlap]

On 12/28/15 17:31, Alexandru GOIA wrote:
> 
> For -rc8 ,
> 
> Hoping that someone DO cares about the aesthetic of kernel messages at boot :
> 
>  
> What it does : first line of booting kernel, as seen in dmesg(1), will be the Linux kernel signature
> (version, compiler, compiler hostname).
> 
> What it solves : it appers ahead of cgroup messages at booting.
> 
> 
> This ugliness, since 3.10.x kernel.
> 
> 
> So :
> 
> Instead of the unaesthetic lines :
> 
> Initializing cgroup subsys cpuset
> Initializing cgroup subsys cpu
> Initializing cgroup subsys cpuacct
> Linux version 4 ...
> 
> 
> ... We will have :
> 
> 
> Linux version 4 ...
> Initializing cgroup subsys cpuset
> Initializing cgroup subsys cpu
> Initializing cgroup subsys cpuacct
> 
> 
> As normal .
> 
> 
> In file linux-4.4-rc7/init/main.c  :
> 
> <code>
> 
> --- main.c      2015-12-28 04:17:37.000000000 +0200
> +++ main+.c     2015-12-29 03:18:59.896820046 +0200
> @@ -512,6 +512,7 @@
>           * Set up the the initial canary ASAP:
>           */
>          boot_init_stack_canary();
> +       pr_notice("%s", linux_banner);
>  
>          cgroup_init_early();
>  
> @@ -524,7 +525,6 @@
>   */
>          boot_cpu_init();
>          page_address_init();
> -       pr_notice("%s", linux_banner);
>          setup_arch(&command_line);
>          mm_init_cpumask(&init_mm);
>          setup_command_line(command_line);
> 
> </code>
> 
> 
> Signed-off-by: Alexandru Goia <alexandru.goia@cti.pub.ro>--


I like the patch. Could you make it a proper kernel patch, please?


thanks,
-- 
~Randy

Re: [PATCH 1/1] kernel booting messages, first line

[Tejun Heo]

On Tue, Dec 29, 2015 at 10:42:40AM -0800, Randy Dunlap wrote:
> On 12/28/15 17:31, Alexandru GOIA wrote:
> > What it does : first line of booting kernel, as seen in dmesg(1), will be the Linux kernel signature
> > (version, compiler, compiler hostname).
> > 
> > What it solves : it appers ahead of cgroup messages at booting.
> > 
> > This ugliness, since 3.10.x kernel.
> > 
> > 
> > So :
> > 
> > Instead of the unaesthetic lines :
> > 
> > Initializing cgroup subsys cpuset
> > Initializing cgroup subsys cpu
> > Initializing cgroup subsys cpuacct
> > Linux version 4 ...
> > 
> > 
> > ... We will have :
> > 
> > 
> > Linux version 4 ...
> > Initializing cgroup subsys cpuset
> > Initializing cgroup subsys cpu
> > Initializing cgroup subsys cpuacct
> > 
> > As normal .
...
> 
> I like the patch. Could you make it a proper kernel patch, please?

I don't know why cgroup is printing those messages to begin with.
They don't serve any purpose.  Lemme just kill them.

Thanks.

-- 
tejun

[PATCH] cgroup: demote subsystem init messages to KERN_DEBUG

[Tejun Heo]

>From 507bd688e32c2b2ca4bed139d9123b3da6d2d19d Mon Sep 17 00:00:00 2001
From: Tejun Heo <tj@kernel.org>
Date: Tue, 29 Dec 2015 14:53:56 -0500

These are noisy during boot and not all that interesting.

Signed-off-by: Tejun Heo <tj@kernel.org>
---
Queued for the coming merge window.

Thanks.

 kernel/cgroup.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index f3836f3..7eb1d9d 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -5245,7 +5245,7 @@ static void __init cgroup_init_subsys(struct cgroup_subsys *ss, bool early)
 {
 	struct cgroup_subsys_state *css;
 
-	printk(KERN_INFO "Initializing cgroup subsys %s\n", ss->name);
+	pr_debug("Initializing cgroup subsys %s\n", ss->name);
 
 	mutex_lock(&cgroup_mutex);
 
-- 
2.5.0