From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754561AbbL3KI7 (ORCPT ); Wed, 30 Dec 2015 05:08:59 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:42011 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754176AbbL3KIn (ORCPT ); Wed, 30 Dec 2015 05:08:43 -0500 X-AuditID: cbfee68f-f793a6d000001364-56-5683ad2a5702 Message-id: <5683AD40.2010609@samsung.com> Date: Wed, 30 Dec 2015 15:39:04 +0530 From: Alim Akhtar User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-version: 1.0 To: Krzysztof Kozlowski , Sangbeom Kim , Alessandro Zummo , Alexandre Belloni , Lee Jones , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, rtc-linux@googlegroups.com Cc: Yadwinder Singh Brar Subject: Re: [PATCH v2 2/3] rtc: s5m: Add separate field for storing auto-cleared mask in register config References: <1451450847-928-1-git-send-email-k.kozlowski@samsung.com> <1451450847-928-2-git-send-email-k.kozlowski@samsung.com> In-reply-to: <1451450847-928-2-git-send-email-k.kozlowski@samsung.com> Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrGIsWRmVeSWpSXmKPExsWyRsSkWldrbXOYwbq5YhZLLl5lt+i4tpjJ 4vULQ4v7X48yWlzeNYfNYsb5fUwW+zs7GC0urvjCZDH3dyOrA6fHk00XGT12zrrL7rFn4kk2 jzvX9rB59G1Zxegxfd5PJo/Pm+QC2KO4bFJSczLLUov07RK4Mtb92MpccEqo4tPbLrYGxg98 XYycHBICJhJt29eyQdhiEhfurQeyuTiEBFYwSuxa9IsZpqjr/m0miMQsRolJMx+xgCSEBB4w SkzpqwWxeQW0JFqvnWQEsVkEVCX+zuxjArHZBLQl7k7fAmRzcIgKREg8viAEUS4o8WPyPRaQ mSIC+5kkVix9zQ6SYBYwkHhw5ikjSL2wQLbEhz5FiL2NjBId/y6DzeQUcJNYu6aNEaLeWmLl pG1QtrzE5jVvmUEaJAQ+sks0Tz/CAnGQgMS3yYdYQIZKCMhKbDoA9ZikxMEVN1gmMIrNQnLT LCRjZyEZu4CReRWjaGpBckFxUnqRsV5xYm5xaV66XnJ+7iZGYHSe/vesfwfj3QPWhxgFOBiV eHhPCDWHCbEmlhVX5h5iNAW6YiKzlGhyPjAF5JXEGxqbGVmYmpgaG5lbmimJ8y6U+hksJJCe WJKanZpakFoUX1Sak1p8iJGJg1OqgXG7rWfVk2WLt5kFXT4oo5e+OlOJoS/9yOJnLw0cAyV6 d/9nza7wF9OxE9hiPiPfymfVgaov5ebRVle/XXU707bDYA3fBqbljMdmK1/ed6mzaonA/yKm OZe3n4mesmJapFCtan6Jg+M0sVMX/Nva1rK2e5fwNPNZrYtd9VFZzZkxtvAY8/nnz5VYijMS DbWYi4oTAbqrNZLJAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpmleLIzCtJLcpLzFFi42I5/e+xoK7W2uYwg7eT+S2WXLzKbtFxbTGT xesXhhb3vx5ltLi8aw6bxYzz+5gs9nd2MFpcXPGFyWLu70ZWB06PJ5suMnrsnHWX3WPPxJNs Hneu7WHz6NuyitFj+ryfTB6fN8kFsEc1MNpkpCampBYppOYl56dk5qXbKnkHxzvHm5oZGOoa WlqYKynkJeam2iq5+AToumXmAJ2mpFCWmFMKFApILC5W0rfDNCE0xE3XAqYxQtc3JAiux8gA DSSsYcxY92Mrc8EpoYpPb7vYGhg/8HUxcnJICJhIdN2/zQRhi0lcuLeerYuRi0NIYBajxKSZ j1hAEkICDxglpvTVgti8AloSrddOMoLYLAKqEn9n9oE1swloS9ydvgXI5uAQFYiQeHxBCKJc UOLH5HssIDNFBPYzSaxY+podJMEsYCDx4MxTRpB6YYFsiQ99ihB7GxklOv5dBpvJKeAmsXZN GyNEvbXEyknboGx5ic1r3jJPYAS6EmHHLCRls5CULWBkXsUokVqQXFCclJ5rlJdarlecmFtc mpeul5yfu4kRnACeSe9gPLzL/RCjAAejEg/vCaHmMCHWxLLiytxDjBIczEoivB/rgEK8KYmV ValF+fFFpTmpxYcYTYGBMJFZSjQ5H5ic8kriDY1NzE2NTS1NLEzMLJXEefddigwTEkhPLEnN Tk0tSC2C6WPi4JRqYHS85OwvNfXyTU9x8+sKa3nydT5dvBNmWz/xaILf20WPz3Tabj/U7x5/ v5mrf3fX+ftLF/LrvzAtcbyh8XGJeO/jshJt3z9LHe5v/pmmnyqtIcmYukBv7r5U1gffPqyZ /ln4jJhdk83+E6dFp0amKJ6zXB1nv2/fBOVN+tF6yppzXh24om/V5qHEUpyRaKjFXFScCABu 6w7gFgMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, On 12/30/2015 10:17 AM, Krzysztof Kozlowski wrote: > Some devices from S2M/S5M family use different register update masks for > different operations (alarm and register update). Now the driver uses > common register configuration and a lot of exceptions per device in code. > > Before eliminating the exceptions and using specific register > configuration for given device, make the auto-cleared mask a separate > field. This is merely a refactoring. > > Signed-off-by: Krzysztof Kozlowski > Tested for s2mps15 pmic on exynos7-espresso board. Works well. Fill free to add Reviewed-by: Alim Akhtar Tested-by: Alim Akhtar > --- > > Changes since v1: > 1. None. > --- > drivers/rtc/rtc-s5m.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c > index 85649861a6b0..559db8f72117 100644 > --- a/drivers/rtc/rtc-s5m.c > +++ b/drivers/rtc/rtc-s5m.c > @@ -56,6 +56,8 @@ struct s5m_rtc_reg_config { > * auto-cleared after successful update. > */ > unsigned int udr_update; > + /* Auto-cleared mask in UDR field for writing time and alarm */ > + unsigned int autoclear_udr_mask; > /* Mask for UDR field in 'udr_update' register */ > unsigned int udr_mask; > }; > @@ -68,6 +70,7 @@ static const struct s5m_rtc_reg_config s5m_rtc_regs = { > .alarm0 = S5M_ALARM0_SEC, > .alarm1 = S5M_ALARM1_SEC, > .udr_update = S5M_RTC_UDR_CON, > + .autoclear_udr_mask = S5M_RTC_UDR_MASK, > .udr_mask = S5M_RTC_UDR_MASK, > }; > > @@ -82,6 +85,7 @@ static const struct s5m_rtc_reg_config s2mps_rtc_regs = { > .alarm0 = S2MPS_ALARM0_SEC, > .alarm1 = S2MPS_ALARM1_SEC, > .udr_update = S2MPS_RTC_UDR_CON, > + .autoclear_udr_mask = S2MPS_RTC_WUDR_MASK, > .udr_mask = S2MPS_RTC_WUDR_MASK, > }; > > @@ -167,7 +171,7 @@ static inline int s5m8767_wait_for_udr_update(struct s5m_rtc_info *info) > > do { > ret = regmap_read(info->regmap, info->regs->udr_update, &data); > - } while (--retry && (data & info->regs->udr_mask) && !ret); > + } while (--retry && (data & info->regs->autoclear_udr_mask) && !ret); > > if (!retry) > dev_err(info->dev, "waiting for UDR update, reached max number of retries\n"); >