public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Xinwei Kong <kong.kongxinwei@hisilicon.com>
To: Bintian <bintian.wang@huawei.com>,
	"xuwei5@hisilicon.com" <xuwei5@hisilicon.com>
Cc: <shawnguo@kernel.org>, <robh+dt@kernel.org>,
	<mark.rutland@arm.com>, <devicetree@vger.kernel.org>,
	<linux-i2c@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>, <pawel.moll@arm.com>,
	<galak@codeaurora.org>, <catalin.marinas@arm.com>,
	<w.f@huawei.com>, <liguozhu@hisilicon.com>,
	<puck.chen@hisilicon.com>
Subject: Re: [PATCH v4] arm64: dts: add all hi6220 i2c nodes
Date: Thu, 31 Dec 2015 09:27:06 +0800	[thread overview]
Message-ID: <5684846A.2050305@hisilicon.com> (raw)
In-Reply-To: <56828756.2040500@huawei.com>

+to xuwei

On 2015/12/29 21:15, Bintian wrote:
> On 2015/12/2 18:13, Xinwei Kong wrote:
>> This patch adds all I2C nodes for the Hi6220 SoC. This hi6220 Soc
>> use this I2C IP of Synopsys Designware for HiKey board.
>>
>> Signed-off-by: Xinwei Kong <kong.kongxinwei@hisilicon.com>
>> Signed-off-by: Chen Feng <puck.chen@hisilicon.com>
   Reviewed-by: Shawn Guo <shawnguo@kernel.org>
>> ---
>>   arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 34 +++++++++++++++++++++++++++++++
>>   1 file changed, 34 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
>> index 82d2488..8cec56a 100644
>> --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
>> +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
>> @@ -208,5 +208,39 @@
>>               clock-names = "uartclk", "apb_pclk";
>>               status = "disabled";
>>           };
>> +
>> +        i2c0: i2c@f7100000 {
>> +            compatible = "snps,designware-i2c";
>> +            reg = <0x0 0xf7100000 0x0 0x1000>;
>> +            interrupts = <0 44 4>;
>> +            clocks = <&sys_ctrl HI6220_I2C0_CLK>;
>> +            i2c-sda-hold-time-ns = <300>;
>> +            pinctrl-names = "default";
>> +            pinctrl-0 = <&i2c0_pmx_func &i2c0_cfg_func>;
>> +            status = "disabled";
>> +        };
>> +
>> +        i2c1: i2c@f7101000 {
>> +            compatible = "snps,designware-i2c";
>> +            reg = <0x0 0xf7101000 0x0 0x1000>;
>> +            clocks = <&sys_ctrl HI6220_I2C1_CLK>;
>> +            interrupts = <0 45 4>;
>> +            i2c-sda-hold-time-ns = <300>;
>> +            pinctrl-names = "default";
>> +            pinctrl-0 = <&i2c1_pmx_func &i2c1_cfg_func>;
>> +            status = "disabled";
>> +        };
>> +
>> +        i2c2: i2c@f7102000 {
>> +            compatible = "snps,designware-i2c";
>> +            reg = <0x0 0xf7102000 0x0 0x1000>;
>> +            clocks = <&sys_ctrl HI6220_I2C2_CLK>;
>> +            interrupts = <0 46 4>;
>> +            i2c-sda-hold-time-ns = <300>;
>> +            pinctrl-names = "default";
>> +            pinctrl-0 = <&i2c2_pmx_func &i2c2_cfg_func>;
>> +            status = "disabled";
>> +        };
>> +
>>       };
>>   };
> 
> Looks good to me!
> 
> Reviewed-by: Bintian Wang<bintian.wang@huawei.com>
> 
> 
> 
> .
> 


      reply	other threads:[~2015-12-31  1:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-02 10:13 [PATCH v4] arm64: dts: add all hi6220 i2c nodes Xinwei Kong
2015-12-02 12:57 ` Shawn Guo
2015-12-29 13:15 ` Bintian
2015-12-31  1:27   ` Xinwei Kong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5684846A.2050305@hisilicon.com \
    --to=kong.kongxinwei@hisilicon.com \
    --cc=bintian.wang@huawei.com \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=liguozhu@hisilicon.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=puck.chen@hisilicon.com \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=w.f@huawei.com \
    --cc=xuwei5@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox