From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752282AbcAAUEO (ORCPT ); Fri, 1 Jan 2016 15:04:14 -0500 Received: from mxout4.netvision.net.il ([194.90.9.27]:45697 "EHLO mxout4.netvision.net.il" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752172AbcAAUEL (ORCPT ); Fri, 1 Jan 2016 15:04:11 -0500 X-Greylist: delayed 924 seconds by postgrey-1.27 at vger.kernel.org; Fri, 01 Jan 2016 15:04:10 EST MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; CHARSET=US-ASCII; format=flowed Message-id: <5686D7BC.7060900@gmail.com> Date: Fri, 01 Jan 2016 21:47:08 +0200 From: Eli Billauer User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.12) Gecko/20100907 Fedora/3.0.7-1.fc12 Thunderbird/3.0.7 To: Geliang Tang Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/7] char: xillybus: use to_delayed_work References: <643e31066f3378b9521dd9cd8c569ccfcf185d61.1451659910.git.geliangtang@163.com> In-reply-to: <643e31066f3378b9521dd9cd8c569ccfcf185d61.1451659910.git.geliangtang@163.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, It's fine with me, but this patch needs to go to the char and misc drivers maintainers (i.e. Arnd Bergmann and Greg Kroah-Hartman). I don't have a repository of my own. Thanks, Eli Acked-by: Eli Billauer On 01/01/16 16:59, Geliang Tang wrote: > Use to_delayed_work() instead of open-coding it. > > Signed-off-by: Geliang Tang > --- > drivers/char/xillybus/xillybus_core.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/char/xillybus/xillybus_core.c b/drivers/char/xillybus/xillybus_core.c > index 77d6c12..3bd36e0 100644 > --- a/drivers/char/xillybus/xillybus_core.c > +++ b/drivers/char/xillybus/xillybus_core.c > @@ -1164,8 +1164,7 @@ static int xillybus_flush(struct file *filp, fl_owner_t id) > > static void xillybus_autoflush(struct work_struct *work) > { > - struct delayed_work *workitem = container_of( > - work, struct delayed_work, work); > + struct delayed_work *workitem = to_delayed_work(work); > struct xilly_channel *channel = container_of( > workitem, struct xilly_channel, rd_workitem); > int rc; >