From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751521AbcABLWL (ORCPT ); Sat, 2 Jan 2016 06:22:11 -0500 Received: from mout.web.de ([212.227.17.12]:54205 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751117AbcABLWI (ORCPT ); Sat, 2 Jan 2016 06:22:08 -0500 Subject: Re: net-libertas: Better exception handling in if_spi_host_to_card_worker() To: Arend van Spriel References: <566ABCD9.1060404@users.sourceforge.net> <5686F0B2.5000000@users.sourceforge.net> <56870866.7020000@cogentembedded.com> <568785B3.5000905@users.sourceforge.net> <5687939E.7010701@users.sourceforge.net> <5687A2C7.3000704@gmail.com> Cc: Julia Lawall , Sergei Shtylyov , libertas-dev@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Kalle Valo , LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring X-Enigmail-Draft-Status: N1110 Message-ID: <5687B2BC.8090901@users.sourceforge.net> Date: Sat, 2 Jan 2016 12:21:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <5687A2C7.3000704@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:raRJ95FO55mSBcAYCCi5s4w8JZAkpfvxKtwgggM/iforE9xqkKb kPZkUPDmuQthRJ222ENqZvDbQqQIlc2u85M50Qmn9eXK5aEWfgGNrqTdVwzbbMDCYBRJhwG ShrQnTqUB+w3i1OjUXRTFhlCCU5tNPLkKw6Gogun2bQx4EVb8GNVmRw2Bs1lOepVNUmMpCU 0V3UKqQH7WgOSkH1JKABw== X-UI-Out-Filterresults: notjunk:1;V01:K0:yJAqpbkk1/E=:2Nl/+qhaTfQHPSr3I2vpMg CSaWKly/Ofn5u8aoI2+savq3zr/L6TidnXtR07GaHV+TOxpcastxL+HCvMoJ1//ZIUoWX8dVS oVcqMb3bI+pV40RyRX5avELXuR4OnbOfzI3SDsPZ4V1Fzziy9p9van8pncWUG1I8UuvBYhq7l jHwBMl3Vr3MyqNzrKR5zenZ5RTeDhFQ2q6vOYvokm/51JiQOos+qiGYb1vdp5DMhPxVygquX1 qFEn/N3T4deIJgiTph9jivq9Zdof6fQOmhyjmWNHjEeJia4Hsj4ufYUHj8v6JYrS8K1TZPeE2 2RqU0dGizvpVgaN+HQ7bQIUhW1sNKZRPw52i3C0vn5jqiu9qYCZljIuIaVDMgN9qaq0l1rSd4 geiIurd9Vk0xApz8S8ag86WWA0KDYPt2Mjqew6UFhxZDu/hRQs7c4jAcAhA7RA8A0LuLf6ZVN EkI9gFnlIRhFs1lvgmBLcIK4TkmOjLuAHbguUHKhOrIyLLWdEt8z6s/ghP11LsH/Wq17JikRR GZm+ZzNCzHvHRFNKyapANFb/hyZXlXGgALeF991pt59FX/QYFyMp4LRtzqoWjsu7DoKiCRTPa esUwlVD6rFgJLwtK/xZA1vIzpL3KNTepzLbufOnMjoWjl9rC7iJDYl/kYTC2AlsqXuqT/QN7k sHKTp1W88O+x3D4THj2b/IPqZQLhMiE0MaCdKESGv5InW4XF3U0ii9p7nGSJiDWN5MzZN1BgF HupYMNm36MrMKj3ME3bDA9LA9nQChinbTY+X7oIuQ261z+z7eNvVWDcr1nHtjAVfi94ah1FQA 1hbLTby Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > I have never seen much evolution going on in this area. I can get an other impression from a specific document for example. https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/log/Documentation/CodingStyle > What the patch tries to do is avoid the extra 'if (err)'. Yes. - I propose to look at related consequences together with the usage of a popular short jump label once more. > Setting coding style aside, the question is whether there is > a good metric for the patch. A software development challenge is to accept changes also around a topic like "error handling". My update suggestion for the source file "drivers/net/wireless/marvell/libertas/if_spi.c" should only improve exception handling. (I came along other source files where more improvements will eventually be possible.) When will the run-time behaviour matter also for exceptional situations? > Did you look at the resulting assembly code for different target architectures? Not yet. - Which execution system variants would you recommend for further comparisons? Regards, Markus