From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751974AbcABPMi (ORCPT ); Sat, 2 Jan 2016 10:12:38 -0500 Received: from mout.web.de ([212.227.17.12]:54591 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751812AbcABPMg (ORCPT ); Sat, 2 Jan 2016 10:12:36 -0500 Subject: net-rsi: Reconsider usage of variable "vap_id" in rsi_send_mgmt_pkt() To: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Kalle Valo References: <566ABCD9.1060404@users.sourceforge.net> <5687E169.4070704@users.sourceforge.net> <5687E203.1070404@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring X-Enigmail-Draft-Status: N1110 Message-ID: <5687E8DB.3080706@users.sourceforge.net> Date: Sat, 2 Jan 2016 16:12:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <5687E203.1070404@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:hr4Tb+w8NbKgRLkQPOe6weXrrulGO+ASnkK2jgU7OJyyzpPT7Yo gDpKNNo3OMiu3lOuLrxIbYwsMeKKkwL2XANyI18UcjHRFVDGvtZZINBS977LHUprsPaJLWo jpqGusXQ72+5V7xrRixpWTOXQb4Y6fk8YID69itaqjKX2XaBiS9JHVCtuG65tdTXs4+zjxv FCWxeXxCc7XE6fx5Ohn9g== X-UI-Out-Filterresults: notjunk:1;V01:K0:gcVbgWpPAUU=:EFq1cK0nlfex0Flu+XVsP3 biDEZV5K/TCoYRlmDV/BvJ8AyJbEib00uSO9Eov7TPX2N9/nayz5fCk1igmGCNMyeg5IdvR9c NNtsLUsN5c+yCDoRz1WIEHKt32SVPYucA2ipWkuNd13zp3KhCXjEDgtMVcyLEa2LfrEkq8TGE eMbv2lfxseAzFPCTX1gXB1cGj3qBxXrjJqwqof8CbTknM+HWgiFdUXX++Qnu1O7z3O/C3pBwM 5TwWT6qHRopCfP03ayOzchpfuKtl3ZKlMgb5KAmpJRdbtVACq9NL4e2gF+cehNPBkf0yYZ+a0 o5YX4i4AwrBG5SqKMrmMdOK7mHIcaSWcxaHiLp8a38JHqEta/OrzMj2jkNvlaHzBNMvxIsETE CEScCBAUtZYtJnr52V+mdZOHf7ot7fNpw9YEPJFF79tWu6VZFl+gHkTJg5L3pqBi9CoGgJ77T 2wCs1FYeYxbeFOdI0ofh8gf9QUR1XQo1dsekHgaKsXohDZZC8SvFmj+azg6m+pfXNsi5HYcb7 oq39upLXSbL31vurFcQ3ZB+4TmP1eVBeK9SzaBr8iftftN1HJvW8l9Q37POJ69TK0cs+8RE6g O38NSfxQzH7PJnCK+rI+T5QzPE2f/U0/lpMVPr+QHogcOwJ1khWMQcxNe0qgkxfhlb7wCpCqp rGDsfGgZQdtFXZ9XRvrD287RPgNtR5v+Ue/0uzH2/hDSqESE7LjoeDKjXFWjfGM2Xy5cbBAPE dY5qqvvAH+peggi0ar4M0to5VPx2kBat3yAVoxnTx7EK9F2p3ssGSq1LkzHmfCnz6STmMbYjp fsMArjk Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, I have taken another look at the implementation of the function "rsi_send_mgmt_pkt". https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/drivers/net/wireless/rsi/rsi_91x_pkt.c?id=e8c58e7a5a106c3d557fccd01cd4d1128f9bab38#n114 I find the following statement combination interesting there. … u8 vap_id = 0; … msg[7] |= cpu_to_le16(vap_id << 8); … I would appreciate a further clarification. Does a shift operation for a variable which contains zero indicate an open issue? Regards, Markus