From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751598AbcACHAw (ORCPT ); Sun, 3 Jan 2016 02:00:52 -0500 Received: from mout.web.de ([212.227.15.3]:49685 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750855AbcACHAu (ORCPT ); Sun, 3 Jan 2016 02:00:50 -0500 Subject: Re: [PATCH 1/3] NFC-mei_phy: Refactoring for mei_nfc_connect() To: Julian Calaby References: <566ABCD9.1060404@users.sourceforge.net> <56883849.2080304@users.sourceforge.net> <5688390B.3080800@users.sourceforge.net> Cc: linux-wireless , Aloisio Almeida Jr , Lauro Ramos Venancio , Samuel Ortiz , LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring X-Enigmail-Draft-Status: N1110 Message-ID: <5688C712.3070900@users.sourceforge.net> Date: Sun, 3 Jan 2016 08:00:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:TQUXo+GS67y8AjDo3mp+4/L4HWPeS0KydbivMURMzxXfQfy5ukS H1/Lcpp3vzB1DmNtPfjH6+iC9gkyGJkWUj3M1dhW2KoehQi4ozqZW6SvG+oAXKAEhBqeJB+ 92+gvt/hsZX/Cgb5Md9g1ImC0DmPLLHAlf+w0rxxrF8b2oyiZFs9eOmRaNiwUMFbGx2xD/9 OAcWEzOPPkam7V3tmqXeQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:iIFdGeL0Rcg=:5DkfV1wLt9xMPLRTHFUzAq 8DhKTL0DJKIleEoSQBBSSOcOd9AMKsq5lvvzc7YBw6Pdk3+gGfsASI6rZ9dbGy+hSkXgVTcem 4ZPjl+1bQqj2+/753QuuZ6hbU77JBNvh/3uYKfO88u0Zs24ijvQOdUyiu4BbKLFbnc2jULcWD fvYlIJtR9IHpYoECjxr4xC0rqQ9BdP4w+5wHOZHSqwZkAv4P8ulId7OlKojuEDkKmxK9G6J4K cqnGceJvV7Y/bCh5SphtowCBxUsLcwKSAtiw5besNUQxVPI9zatxWF99WNdbVHctHu5oa/C1n 9rULGVOdJXpjFXrG0ya1ms5Bi+QIrgHw5klQ57GA5n6hS+IR7QvlT7VB74JsDugtTIyGh+fYZ zh4ciOvsni/xI9Xc1hZJw/FaiGAeNvKRGIFb5G+kBqOuWnrSjIvzohCQIDhzbmLI7ytR0moEE +Gs+HJS9jq7WbuaADiM6TOF8zaA7cXuPMUSLLl3UodJBlDWeRSCU9IFCBkkUvNAWbLq+BELjs ZY/DeKuL5ZUFCJyC3WSx7Nh3jZyekPsXhvlaPonw1QNsohTdO1z28/tZXr4CvU/iH5L5OHmHS 4J25ARtEsWXGkzX0617PTQvsYyN0Gv6KO/Y1GHMTMIAJ8wBQJKKRDzJScsb9S0fxgyTmykmzc d3tN15H5sdDIRlK/Cbu6lTB7ACSRpHh7LYSsCuxhILAPTUzDEjdE6XtfnA3iGvoGExlHQRNdh 7BbFp1NKjdGXvMVsfvQw8tLqZ2Gco5QdAww+1L8kPNo8oDVT2hZolrNz/PCkk2uCbISCHeuWA pftzF6w Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> r = 0; >> - >> -err: >> +free_reply: >> kfree(reply); >> +free_cmd: >> kfree(cmd); >> - > > Why are you deleting the two blank lines here? Can they be unnecessary at this source code place according to the Linux coding style convention? Regards, Markus