From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751966AbcACWzJ (ORCPT ); Sun, 3 Jan 2016 17:55:09 -0500 Received: from mail-bn1bon0091.outbound.protection.outlook.com ([157.56.111.91]:34868 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751130AbcACWzD (ORCPT ); Sun, 3 Jan 2016 17:55:03 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Suravee.Suthikulpanit@amd.com; Subject: Re: [PATCH] i2c: designware: Add support for AMD Seattle I2C To: Wolfram Sang References: <1450216553-5641-1-git-send-email-Suravee.Suthikulpanit@amd.com> <5670C90A.5020305@amd.com> <20151216091652.GN1762@lahna.fi.intel.com> <56717552.4060203@amd.com> <20151216145401.GX1762@lahna.fi.intel.com> <567206B7.1050405@amd.com> <20160103184555.GG1522@katana> CC: Mika Westerberg , , , From: Suravee Suthikulpanit Message-ID: <5689A6B7.7010401@amd.com> Date: Sun, 3 Jan 2016 16:54:47 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20160103184555.GG1522@katana> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [97.79.218.117] X-ClientProxiedBy: SN1PR15CA0037.namprd15.prod.outlook.com (25.163.200.47) To BLUPR12MB0434.namprd12.prod.outlook.com (25.162.92.14) X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0434;2:nOrWD4LqXqIQbc/lwa3I8/fB1J5MdEOuK+H90cLxippaPr2oBACEmRgSdyKBdqjrStnh3F5zNyi8wnXqEfFVBD2Aqw0gMsmUYOXw+44RCfJTDhHwvJjA/NUNL3UNOa40nkOq2l/rkp2MQcwdzyNmwQ==;3:sEwVcdOKu3ABV7oJpenqXfVDk7WHOSIBjrgGXOVoXWNYWsqwJAs5l6QTJ59y1rdvwwQHhw+zFcA/ukMfikxV+NJWTciyVxvkuvy3iz0RWmHtJjYHgi3gqXhnPZdkqE5l;25:bWupB18zxccY2DVi9kqEWScxZZQQ3LIV1BzsQ/itb+wX8Pq9+RQ6tZ2iRDRG7UDgReY/AwRmNWloJ+9NUwcfjgaxLM8/kJozoIfncCphAKVA18S3+PkUZBFvmofutFj2hQz5YFIQBsuAqP5NGJ+vubWBRjvwVh0YaSBGGIwepaIiXATyxXgn2kV9LxbtBbUPtJx/mAmZYghrY+aRnaIZ04xqSDnpeqU9p22ff2DrorQCZgSic7KTYSJ/NyaQXe2V6ZLFsLZyUmYstpum0uw7XA== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR12MB0434; X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0434;20:AfSfKGvdoIKtH0WbBYLmuQ9gFUmo1oRE2z9gaub2WPVLFF5SVR0kb7jJIW305tGmrF1pG5pnSh5FQ6Voj0XxXuGEqr6+N7GU2iNQI5GzVVLZgDA2vN6koSC0rF8SAdXjwP+2I4rvY4txt7FifmX67SXnguo5ikhtkY0muylZhTK0VcNFAidh5n8esy2a67pkOtVg5Ckcuc8/nQAYHxjj1c7m+kiYkVbm8o4P/LhfQ5GgkdpqVkx/dKjrBnpcgx2dBaRdw0KpaDGpoSwK3os8o03MTJSKhXUrguRKODrigamOgn61Zmeoz66z67v3PeMMLiOvZFUmEunZLisagl2e5jx9T/u6553zOawFJ8m0g1iLwnktGXckm8Vhf79uLPRcn8sQ3xTyhH7YxSBFmTzgjgWJovTsyOHe2hLkUhDnoIQ+Xfl8v1i69uXFLNYFEJYjEFUzOlnDq5C9gDEV0Bs37s8mz4H/ggMTD4m3EMhQUzZzNQbvrcLLtuqkMun8aCan;4:utpHh8J22fDjRjguSpylH5qgsBref7z8GtRpXmXuzrze1EYtDTezTiiJG/A8Fx8FJqfRQxJVXKwSGmogqxniNIkQk52VJ+9gGtCLuwEasr3FL19GzHINB+mIxtJVPBwDVMAugwt8cPwfvytPI95EMGXH3kKOX8z3prlHuEqG6SDUVfrlsxJhz5kaugsWHbnygzISUwLQzVE1TNC5b+onVUa5hx5zCqm2AYGMU4CbyIYmqWcVD9+JH4DyQl24tSURG5IU4vthZB+qikWhmDOxJGFiD9uGLrxbL0mU1VaXl6g1PU4rnvDxam3SUkmEuaD7zBPJyvE3BrF/8S72nbH5yyGYoJt/mqJP1XpceZEL3yz32TsftIvmmzHsttL0PyihYCNcmU2RpWd4n/y/PjULshMsf7pnY1R9W+M8e4Ug0b8= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(5005006)(8121501046)(10201501046)(3002001);SRVR:BLUPR12MB0434;BCL:0;PCL:0;RULEID:;SRVR:BLUPR12MB0434; X-Forefront-PRVS: 0810818DA0 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(6049001)(479174004)(189002)(199003)(377454003)(24454002)(86362001)(2950100001)(106356001)(122386002)(3846002)(87266999)(4001350100001)(105586002)(76176999)(5001960100002)(54356999)(5004730100002)(23746002)(77096005)(81156007)(92566002)(64126003)(42186005)(110136002)(189998001)(87976001)(50466002)(83506001)(65806001)(65816999)(5008740100001)(65956001)(19580395003)(230700001)(101416001)(19580405001)(66066001)(36756003)(97736004)(59896002)(4326007)(80316001)(33656002)(117156001)(93886004)(47776003)(6116002)(40100003)(1096002)(586003)(50986999)(7099028);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR12MB0434;H:[192.168.1.18];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BLUPR12MB0434;23:EpcN0ct09kMfjae+anLeMbySNBfFokXQI6N0k?= =?Windows-1252?Q?qrzlo5RssuXHjlKyu8svELQZvSWXQ2juDLBTWvtH8cZqXb6DCN8IVpLT?= =?Windows-1252?Q?TXd8rRy0sOIUQQFbtgGMvSJBteWefTnhcBuPGISY9pYxDCcSp6SeIacZ?= =?Windows-1252?Q?5ED/IQRliAXP8IWMOF3okq2C7gWL5CqbMhX5vE1EcNpKAwyVTcWl4T1N?= =?Windows-1252?Q?BzbXaFndjCL9ecc50ahrDhY47S88E20E1uDSoaeuNpxVFfKeolgt5hX9?= =?Windows-1252?Q?VLOlmo6XGNAuSoMMkRyUq1UM/lEoiKnP3UHm71qekHS9xfvUIhdVJ3H1?= =?Windows-1252?Q?NoFxCRm/Pdpf+jSwiMmsCnoMyRlErSDeNqxvnroR82rTgf9QN/dAdLmS?= =?Windows-1252?Q?6SR81t74IKQUXYM1PwIYyBZN+/1rP7bRhciJsdSlgO8fICsRzIJZ20Pk?= =?Windows-1252?Q?ZZ/NpTAgIYbDMbvXLmHV6E83V4CYmsMkuTELDdeauiO3Yr5cmWN3cS5o?= =?Windows-1252?Q?r6rHBtYlPgtz9BJ14MJsJBJQaEHE1YQp93t/PsAa6aopeACuUKzmaoOo?= =?Windows-1252?Q?CZxYauL6wMOm6cnHswZakB36OOtu7yJLiIrQbH16/4v+IbtOd6jGWgaA?= =?Windows-1252?Q?8PxjJb/TxCPTZXaudCWLTDJJwJz30qIBJLH8ecFgSmIkAL6AbaWQbRj2?= =?Windows-1252?Q?hFg0Hl2v4MUIyk8vecBb7zHZKiB1x6NnyMtpll9l+0UAfzxYZ4fOUo+G?= =?Windows-1252?Q?Uo12+39hQIduudLjfCPd+3vjnOEVMpSIXbyfQC2fWhXOIsugDrXF1lYI?= =?Windows-1252?Q?SP+tx+B57xqfnbu/5D+5+rk6H0JYJ8Rtui/8XRtbj+d7TO0yndMMVHwK?= =?Windows-1252?Q?XlW53A7Q5S6wAWlQmm+B3mhAF/jbdG0zVJxi+veR+JC+wi7cVaQCRaam?= =?Windows-1252?Q?EvP+Io+xwcpXeFpu8slDsSgZMrtDI0/15ICd574gC7NNLNO8Va6iwpA2?= =?Windows-1252?Q?jbK4Ntrx7XslAl8ckjeiG3YlDVbklVIeS+n5zN0KZmYdOWWAVgtsFp6k?= =?Windows-1252?Q?nNo2BwYt4qkDLFjQWPs9DXFOo35kXxQRxXQq52JxRp0CUpmT96vXGNBw?= =?Windows-1252?Q?DpDnCoLi8hpjhsNFLz4+GoTTknHDp+EF6DFBgyuvl90wOs5z2Oo+q0OG?= =?Windows-1252?Q?tZUwNHUZNTYgev02MUZXxbN8LxSHRGWht+sMpdQ+3STBUQxC2vM42RTR?= =?Windows-1252?Q?VUmZ4cDg7ZFkJhpGxO4e/j7AtwDBxvIQP4dkjzbMtkLNOC2+8ACMDO9t?= =?Windows-1252?Q?dfgiOxmvInvnHrqxNlp5mEey0z8YgvdKPSAChynszaQvU9RVmV4YpEyK?= =?Windows-1252?Q?+0b7y5DPnKh0eB1hg9QBvkIWwjABwwgKz47ccKFk4qLiJEMCeyV0q8FH?= =?Windows-1252?Q?4spQtl+MeL5RjWm7I4KADQzyS2/5V9PfJvraxjCKQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0434;5:roRbk9LvTehPNIDnVGfAE+uiTvjNk31r9LtvLLbwdyccIfBe7m3U4IBjbWNm8GflwQEv7qZSZwvptLK5nSbTlLWE41YlK5oRW3VBMzxgH8yx1bEwckI61XjwK4JC1moobsLLJ70jR3povbd9f93h/w==;24:ZYvJaxkuF5N26nEe7G1y8aj6aLDgTdhwMWLhTtxjefP6IjxVaRTP38R83N9Z0OuWOPIOsVJIDkf+34cclRQhSqQLWszJvtsX6XU1uGo8neg=;20:Zrcqe+25CB1Av6ar6JyNOCwtS14w09NefkrPUnadiAPbvyENxZZr/Qg3tXAb5dsettU16qhn73k+/OH6DjiBSIqGIU3IcBBd2Tgm/JQsqxxCt/QAYwVVV1PcyT9/3FbN23Prk1B4Y3IJanaLjnXZH9WAAPVzIMnv4CIPNgytvYQw8KqdpYyk1tiErKbn52hm5NMkvMRgte++cZUbSRK/32FEByywzoWTfOr70x1QWgqmkvFfu/gNwkzFV2XQxWwS SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2016 22:54:58.3416 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR12MB0434 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Wolfram, On 01/03/2016 12:45 PM, Wolfram Sang wrote: > On Wed, Dec 16, 2015 at 06:49:59PM -0600, Suravee Suthikulanit wrote: >> Mika, >> >> On 12/16/2015 8:54 AM, Mika Westerberg wrote: >>> On Wed, Dec 16, 2015 at 08:29:38AM -0600, Suravee Suthikulpanit wrote: >>>>> >>>>> >>>>> On 12/16/2015 03:16 AM, Mika Westerberg wrote: >>>>>>> On Tue, Dec 15, 2015 at 08:14:34PM -0600, Suravee Suthikulpanit wrote: >>>>>>>>> Hi Mika, >>>>>>>>> >>>>>>>>> On 12/15/15 15:55, Suravee Suthikulpanit wrote: >>>>>>>>>>> Add device HID AMDI0510 to match the I2C controlers on AMD Seattle platform >>>>>>>>>>> >>>>>>>>>>> Signed-off-by: Suravee Suthikulpanit >>>>>>>>>>> --- >>>>>>>>>>> drivers/i2c/busses/i2c-designware-platdrv.c | 1 + >>>>>>>>>>> 1 file changed, 1 insertion(+) >>>>>>>>>>> >>>>>>>>>>> diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c >>>>>>>>>>> index 57f623b..a027154 100644 >>>>>>>>>>> --- a/drivers/i2c/busses/i2c-designware-platdrv.c >>>>>>>>>>> +++ b/drivers/i2c/busses/i2c-designware-platdrv.c >>>>>>>>>>> @@ -117,6 +117,7 @@ static const struct acpi_device_id dw_i2c_acpi_match[] = { >>>>>>>>>>> { "80860F41", 0 }, >>>>>>>>>>> { "808622C1", 0 }, >>>>>>>>>>> { "AMD0010", 0 }, >>>>>>>>>>> + { "AMDI0510", 0 }, >>>>>>>>>>> { } >>>>>>>>> >>>>>>>>> Since this driver seems to be used by several SOCs, and we have been adding >>>>>>>>> the HID from various SOC vendors. Do you think it would be better to assign >>>>>>>>> a CID so that each SOC vendor can specify in their ACPI DSDT and we can >>>>>>>>> match them here? >>>>>>> >>>>>>> Sure _CID would work here. >>>>> >>>>> Do you know if Synopsys has already provided a CID that we can use for this? >>> No. >>> >>>>> If not, who do you think should provide this? >>> Why can't you make _CID for AMD part only? For Intel we are going to get >>> new IDs for every major SoC release no matter what. >>> >> Actually, after discussed with the team. We have decided to go with the >> AMDI0510 at this point, and we will reuse this as CID in future SOC if it >> contains compatible I2C controller. > > So, can I take the patch as is? > Yes, please pull this as is. Thank you, Suravee