From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753098AbcADIf4 (ORCPT ); Mon, 4 Jan 2016 03:35:56 -0500 Received: from arroyo.ext.ti.com ([192.94.94.40]:56389 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753030AbcADIfx (ORCPT ); Mon, 4 Jan 2016 03:35:53 -0500 Subject: Re: [PATCH v3] irqchip: omap-intc: add support for spurious irq handling To: Thomas Gleixner References: <9c78a6db02ac55f7af7371b417b6e414d2c3095b.1450188128.git.nsekhar@ti.com> <20151215152842.GR23396@atomide.com> CC: Tony Lindgren , Jason Cooper , Marc Zyngier , John Ogness , Felipe Balbi , Linux OMAP Mailing List , From: Sekhar Nori Message-ID: <568A2ED5.9060704@ti.com> Date: Mon, 4 Jan 2016 14:05:33 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20151215152842.GR23396@atomide.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Thomas, On Tuesday 15 December 2015 08:58 PM, Tony Lindgren wrote: > * Sekhar Nori [151215 06:26]: >> Under some conditions, irq sorting procedure used >> by INTC can go wrong resulting in a spurious irq >> getting reported. >> >> If this condition is not handled, it results in >> endless stream of: >> >> unexpected IRQ trap at vector 00 >> >> messages from ack_bad_irq() >> >> Handle the spurious interrupt condition in omap-intc >> driver to prevent this. >> >> Measurements using kernel function profiler on AM335x >> EVM running at 720MHz show that after this patch >> omap_intc_handle_irq() takes about 37.4us against >> 34us before this patch. >> >> Signed-off-by: Sekhar Nori > > Looks good to me, probably should get tagged Cc stable when > committing: > > Acked-by: Tony Lindgren Can you please apply this if it looks good? Thanks, Sekhar