From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753456AbcADLry (ORCPT <rfc822;w@1wt.eu>);
	Mon, 4 Jan 2016 06:47:54 -0500
Received: from smtp.citrix.com ([66.165.176.89]:21438 "EHLO SMTP.CITRIX.COM"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753240AbcADLrt (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 4 Jan 2016 06:47:49 -0500
X-IronPort-AV: E=Sophos;i="5.20,520,1444694400"; 
   d="scan'208";a="322702417"
Message-ID: <568A5BE1.8090900@citrix.com>
Date: Mon, 4 Jan 2016 11:47:45 +0000
From: David Vrabel <david.vrabel@citrix.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0
MIME-Version: 1.0
To: "Michael S. Tsirkin" <mst@redhat.com>, <linux-kernel@vger.kernel.org>
CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Julien Grall <julien.grall@citrix.com>,
        "Stefano Stabellini" <stefano.stabellini@citrix.com>,
        Ross Lagerwall <ross.lagerwall@citrix.com>,
        Wei Liu <wei.liu2@citrix.com>, <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] xen/events: use virt_xxx barriers
References: <1451907925-15768-1-git-send-email-mst@redhat.com>
In-Reply-To: <1451907925-15768-1-git-send-email-mst@redhat.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
X-DLP: MIA2
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 04/01/16 11:46, Michael S. Tsirkin wrote:
> drivers/xen/events/events_fifo.c uses rmb() to communicate with the
> other side.
> 
> For guests compiled with CONFIG_SMP, smp_rmb would be sufficient, so
> rmb() here is only needed if a non-SMP guest runs on an SMP host.
> 
> Switch to the virt_rmb barrier which serves this exact purpose.
> 
> Pull in asm/barrier.h here to make sure the file is self-contained.

Thanks!

Acked-by: David Vrabel <david.vrabel@citrix.com>

David