From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754004AbcADMdi (ORCPT ); Mon, 4 Jan 2016 07:33:38 -0500 Received: from mout.web.de ([212.227.15.3]:63022 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753318AbcADMd3 (ORCPT ); Mon, 4 Jan 2016 07:33:29 -0500 Subject: Re: rsi: Delete unnecessary variable initialisations in rsi_send_mgmt_pkt() To: Dan Carpenter References: <566ABCD9.1060404@users.sourceforge.net> <5687E169.4070704@users.sourceforge.net> <5687E203.1070404@users.sourceforge.net> <20160104092857.GD5284@mwanda> <568A4CFF.8060600@users.sourceforge.net> <20160104114849.GH5284@mwanda> Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Kalle Valo , LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring X-Enigmail-Draft-Status: N1110 Message-ID: <568A668D.8090007@users.sourceforge.net> Date: Mon, 4 Jan 2016 13:33:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20160104114849.GH5284@mwanda> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:dEiMCqN8YIGOOWm/peQGUITxM2QoQID4DyktVmDlDLUkHZ0v2cy 0+CArdCjGBQ+uvpN98e+WYjRhNXIF8Sg+lnSipVh8I0lKZONsir2zBn4052szfhYa5GW2Yg 4FI3l5JJLunh+j1fxeFxtKTi272GxN+2BsSVj9DNno8vAUmoRdtt47c2sTpp3bXg+SOx7Vd hZISNFXaXSZpAUUPHkzJg== X-UI-Out-Filterresults: notjunk:1;V01:K0:0IKFYKphzgk=:3HKKpyzbNYP9Z94F3IuZlR 1hGhNWTpIujlsc/K+vg9H//1c8Z8Vn7G6InmYEYZ7psEQQsqp+rJgW6wK7YveEGS8WBimvtLG LqOt/+2acuthHN4/lP+w1OTMy0Z7SCpqtXBQxFqEVxrYa4A814tjVQcyFYTRaQq/LXzU/OZc2 JM9vkQCH/hHSfm1vHBImgKB9W6S7v1u1fLUq4uMJ0XbGQlJxeWZWjkoPV/ME46yRe7fXavvx/ ypt9f6d3zaM1+ms2nGS/52p1VtDJGDI7wfRT+uKZFefGjNYl6j02kJsmTgCANZYZE/d4Q4gKQ Lb8Dy8+CNz7jVgKz55SRexigZw21sT6ekD0ZHx/ilYdbduZEYzj38vjSvIUeWpoQK6RsD0q0B EvZFTPlBSr3u2e7MRFwZJ7ula63K1igvyCGlluFOYLJI6qZmdQeISpKCS7vGhvafLGbuVV3mI +OL0W4hLSTU+14iIByLMdEKwNo9t9+bb8ABUiJ30+/4mg4gvnc49sQOMWr1xaG6DNO5WGRGSq EpIJkK/DbtQt7fZ1paiT1PIUsfuab13o3ht9h6HpgHrRrPmY60PNptVub+18U2kMW3+L3fAee cOF9x7RLkfAgn9/r/XkkvTM0DEyLA7z5Jrl0PdLcRJpPw9ynyQRaMR5FmKpplHkJmJaS9zOBH E+81+D38IUAZllLqORGpyjfQFf6jkb4c5Xr5FSZ4OGDGgap19wOosj8Cb2LMSwdtLiVuLOkdB mx2RD/isxdI9kC6XMQDiPdBZee/jouM0eIEE+vL/rhNC4+HG3KdTPCIexFpu4NQCMycDDb8tl fhxB84i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> May I resend a consistent patch series for the source file >> "drivers/net/wireless/rsi/rsi_91x_pkt.c" in the near future? > > If you were sending checkpatch.pl fixes that would be easier to deal with Does this feedback mean that you would accept any more suggestions around source code updates which are derived from recommendations of this script? > but you are sending hundreds of "controversial" cleanups. It depends on the time range you look at for my proposals. > They are controversial in the sense that they don't fix anything > against official kernel style I find that I suggested also few changes that fit to this aspect. > and they go against the author's original intention. Can it occasionally help to reconsider the "first approach"? > I tend to agree that useless initializers are bad Would any more software developers like to share their opinions on this detail? > and disable GCCs uninitialized variable warnings I hope that this software area can be also improved. > but just because I agree with you doesn't make it official kernel style. That is fine. - Will it become useful to clarify any extensions to a document like "CodingStyle"? > It's slightly rude to go against the author's intention. I just dare to propose further special changes. Regards, Markus