Re: [tip:x86/urgent] x86/entry: Restore traditional SYSENTER calling convention

Re: [tip:x86/urgent] x86/entry: Restore traditional SYSENTER calling convention

[Andy Lutomirski]

On Mon, Dec 21, 2015 at 7:10 AM, tip-bot for Andy Lutomirski
<tipbot@zytor.com> wrote:
> Commit-ID:  30bfa7b3488bfb1bb75c9f50a5fcac1832970c60
> Gitweb:     http://git.kernel.org/tip/30bfa7b3488bfb1bb75c9f50a5fcac1832970c60
> Author:     Andy Lutomirski <luto@kernel.org>
> AuthorDate: Wed, 16 Dec 2015 23:18:48 -0800
> Committer:  Thomas Gleixner <tglx@linutronix.de>
> CommitDate: Mon, 21 Dec 2015 16:05:01 +0100
>
> x86/entry: Restore traditional SYSENTER calling convention

This is still missing from Linus' tree AFAICT, and I'm a bit nervous
about it landing in 4.4 without ever showing up in a -rc.

--Andy

Re: [tip:x86/urgent] x86/entry: Restore traditional SYSENTER calling convention

[H. Peter Anvin]

On 01/04/2016 10:31 AM, Andy Lutomirski wrote:
> On Mon, Dec 21, 2015 at 7:10 AM, tip-bot for Andy Lutomirski
> <tipbot@zytor.com> wrote:
>> Commit-ID:  30bfa7b3488bfb1bb75c9f50a5fcac1832970c60
>> Gitweb:     http://git.kernel.org/tip/30bfa7b3488bfb1bb75c9f50a5fcac1832970c60
>> Author:     Andy Lutomirski <luto@kernel.org>
>> AuthorDate: Wed, 16 Dec 2015 23:18:48 -0800
>> Committer:  Thomas Gleixner <tglx@linutronix.de>
>> CommitDate: Mon, 21 Dec 2015 16:05:01 +0100
>>
>> x86/entry: Restore traditional SYSENTER calling convention
> 
> This is still missing from Linus' tree AFAICT, and I'm a bit nervous
> about it landing in 4.4 without ever showing up in a -rc.
> 

Linus has frequently stated that if it is something that is critical
enough for stable, it is critical enough for final.  Linus will decide
if an additional -rc is needed for that reason.

	-hpa

Re: [tip:x86/urgent] x86/entry: Restore traditional SYSENTER calling convention

[Andy Lutomirski]

On Mon, Jan 4, 2016 at 10:48 AM, H. Peter Anvin <hpa@zytor.com> wrote:
> On 01/04/2016 10:31 AM, Andy Lutomirski wrote:
>> On Mon, Dec 21, 2015 at 7:10 AM, tip-bot for Andy Lutomirski
>> <tipbot@zytor.com> wrote:
>>> Commit-ID:  30bfa7b3488bfb1bb75c9f50a5fcac1832970c60
>>> Gitweb:     http://git.kernel.org/tip/30bfa7b3488bfb1bb75c9f50a5fcac1832970c60
>>> Author:     Andy Lutomirski <luto@kernel.org>
>>> AuthorDate: Wed, 16 Dec 2015 23:18:48 -0800
>>> Committer:  Thomas Gleixner <tglx@linutronix.de>
>>> CommitDate: Mon, 21 Dec 2015 16:05:01 +0100
>>>
>>> x86/entry: Restore traditional SYSENTER calling convention
>>
>> This is still missing from Linus' tree AFAICT, and I'm a bit nervous
>> about it landing in 4.4 without ever showing up in a -rc.
>>
>
> Linus has frequently stated that if it is something that is critical
> enough for stable, it is critical enough for final.  Linus will decide
> if an additional -rc is needed for that reason.

True.  It's also been in -next for a while, although the number of
32-bit -next testers over the holidays might not be that high.

--Andy

Re: [tip:x86/urgent] x86/entry: Restore traditional SYSENTER calling convention

[Linus Torvalds]

On Mon, Jan 4, 2016 at 10:48 AM, H. Peter Anvin <hpa@zytor.com> wrote:
>
> Linus has frequently stated that if it is something that is critical
> enough for stable, it is critical enough for final.  Linus will decide
> if an additional -rc is needed for that reason.

So it would have been good to have it in an -rc, but at the same time
I'm not particularly worried about this one.

It's not like it's complicated, and I'm assuming it got tested and
passed all our current test-cases (which are much more complete than
anything we've ever had historically).

                     Linus

RE: [tip:x86/urgent] x86/entry: Restore traditional SYSENTER calling convention

[Zhuo, Qiuxu]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1861 bytes --]

Hi Linus and Andy,

  We did test in our side with v4.4-rc8 + Andy's vDSO v2 patches + Android M (bionic libc using sysenter) ==> Device can boot up successfully

  Other tests were:
  - Android L (bionic libc using int80) + v4.4-rc8 ==> Device can boot up successfully
  - Android L (bionic libc using int80) + v4.4-rc8 + Andy's v2 patches ==> Device can boot up successfully
  - Android M (bionic libc using sysenter) + v4.4-rc8 ==> Device can NOT boot up successfully
  - Android M (bionic libc using sysenter) + v4.4-rc8 + Andy's v2 patches ==> Device can boot up successfully

   Thanks!
BR
qiuxu

-----Original Message-----
From: linus971@gmail.com [mailto:linus971@gmail.com] On Behalf Of Linus Torvalds
Sent: Tuesday, January 5, 2016 3:28 AM
To: H. Peter Anvin
Cc: Andy Lutomirski; Shi, Mingwei; Fu, Borun; Gross, Mark; Andrew Lutomirski; Su, Tao; Borislav Petkov; Ingo Molnar; Brian Gerst; linux-kernel@vger.kernel.org; Zhuo, Qiuxu; Thomas Gleixner; Denys Vlasenko; Wang, Frank; linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/urgent] x86/entry: Restore traditional SYSENTER calling convention

On Mon, Jan 4, 2016 at 10:48 AM, H. Peter Anvin <hpa@zytor.com> wrote:
>
> Linus has frequently stated that if it is something that is critical 
> enough for stable, it is critical enough for final.  Linus will decide 
> if an additional -rc is needed for that reason.

So it would have been good to have it in an -rc, but at the same time I'm not particularly worried about this one.

It's not like it's complicated, and I'm assuming it got tested and passed all our current test-cases (which are much more complete than anything we've ever had historically).

                     Linus
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥