From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753129AbcADUZX (ORCPT ); Mon, 4 Jan 2016 15:25:23 -0500 Received: from mail-by2on0094.outbound.protection.outlook.com ([207.46.100.94]:3382 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751561AbcADUZR (ORCPT ); Mon, 4 Jan 2016 15:25:17 -0500 X-Greylist: delayed 10857 seconds by postgrey-1.27 at vger.kernel.org; Mon, 04 Jan 2016 15:25:17 EST Authentication-Results: spf=fail (sender IP is 66.35.236.227) smtp.mailfrom=opensource.altera.com; xmission.com; dkim=pass (signature was verified) header.d=altera.onmicrosoft.com;xmission.com; dmarc=none action=none header.from=opensource.altera.com; Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=dinguyen@opensource.altera.com; Message-ID: <568AD038.7070200@opensource.altera.com> Date: Mon, 4 Jan 2016 14:04:08 -0600 From: Dinh Nguyen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Borislav Petkov CC: , , , , , , Subject: Re: [PATCHv7] EDAC, altera: Add Altera L2 Cache and OCRAM EDAC Support References: <1445978292-29918-1-git-send-email-dinguyen@opensource.altera.com> <20151119183421.GG6065@pd.tnic> <568AA929.1020801@opensource.altera.com> <20160104194629.GN22941@pd.tnic> In-Reply-To: <20160104194629.GN22941@pd.tnic> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [64.129.157.38] X-ClientProxiedBy: BLUPR0301CA0027.namprd03.prod.outlook.com (25.162.113.165) To BY1PR03MB1369.namprd03.prod.outlook.com (25.162.109.27) X-Microsoft-Exchange-Diagnostics-untrusted: 1;BY1PR03MB1369;2:Pc3XZdqetnGEzRDtmgujgzk9QCOnf1B+9HALM2xligVhxOIqM2pnL/9mwYqHGRVPgLm1yH9npBTKj9Gt9zaN7yejo+qGBmf32Qa/Q1CnxRa2CPegnrdANa8WFK7f138I96bmd1MxChQfM2Vvb8UfPA==;3:pGiBTGPHP74/gyYXi8kUl9blsgPJRnpd27ZZYFdy+jCKUnaRRHjE1eUoC21wRxpxvqHoXcSVeyy4q6UE4yeGVCbolqUCByk9U6Jj5Esu2DxpIujqgpjdDOXz1NQovCzK;25:45OaBcOL8Hej66fCM8BSQ5FEzE3vu7n4QpbFNMbtLsk017EDt0UXSBl4WODfA9tXYgPZLGkbCmtqbRb/AKETs7amS5Ge+pEZoi1JCgcSYeVRi1KeSrWyQp1vtZmqN0FeDcLH28QKmapkqpVPLtvLRUi1DL7fIh/i1SF62OOy5E6or/fricl0i78wP0NMKdaQjbHjJly+yMOau+Ff+eLmJHrA9wlFkjXDjWLGD/XlGaU+rEOLxqhtSI47XZlyW7S1BMmboexPxcT1udWi02F49Q==;20:bDs9e2iG0aqITwyKIgD4hs14X2At0jMPrbmdbbZCOJ6QhNyHWq+c6TPLhJLHpl0v6+6wrz3CU2TmidwmAXBus3Zba3Ud6jsIXD9AUrHB9N2a3NlwJfOJM5h8AxlxicIqvtToYvm947avbEYg1lfHoWG3cJSWe3QRJg4tZIpy6RE= X-Microsoft-Antispam-Untrusted: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1369; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:;UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(5005006)(8121501046)(10201501046)(3002001);SRVR:BY1PR03MB1369;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1369;BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(5005006)(8121501046)(10201501046)(3002001);SRVR:BLUPR03MB439;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB439; X-Microsoft-Exchange-Diagnostics-untrusted: 1;BY1PR03MB1369;4:mT2hbb3PgRNjEuUoglJwxLWcMO63zcvDS20xF+rizs1qvjK5IDSid8KRcgzKJWoLqPomHVaZnaTzDMhvT+MYcoriOCJtDK514X43GBGYb9KbKnCZMRvvIaDBMMYt+J5BTkIVNJYM3yjqBHiLhhfg+G9krrh/mpSfFstf6VhqzoeSWL/VRuJ0JzXX7XEDspmI+1LstyMmUu88mc9dSTUPZroGtN0jTyEnd0NFDwsv34Vj1qbHAkwk2TCuzZh9tIxqEjRvZ5mJvrpoXtvprxyqHWQXglS+88z7mpbE2vb0UQStf7HQtUBKd89dDJgF57RlOWgUWlQ/yFQo/OFCN0SL3JY6u4hUi3yO61O7Bev/GNa7ZX1EC16/bs6Hl6U874Gj X-Forefront-PRVS: 08118EFC2B X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(6049001)(6009001)(377454003)(189002)(199003)(479174004)(24454002)(92566002)(50986999)(42186005)(65816999)(76176999)(86362001)(4001350100001)(47776003)(81156007)(101416001)(97736004)(66066001)(4326007)(5004730100002)(93886004)(5008740100001)(105586002)(77096005)(65806001)(80316001)(5001960100002)(110136002)(59896002)(50466002)(1096002)(33656002)(64126003)(3846002)(65956001)(586003)(23676002)(87266999)(122386002)(83506001)(6116002)(87976001)(106356001)(230700001)(54356999)(2950100001)(189998001)(40100003)(217873001);DIR:OUT;SFP:1101;SCL:1;SRVR:BY1PR03MB1369;H:[137.57.160.210];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:0;LANG:en; X-Microsoft-Exchange-Diagnostics-untrusted: =?utf-8?B?MTtCWTFQUjAzTUIxMzY5OzIzOm1oVzhaK0VxbDBaNW51VGZERjJqN0VXYkx2?= =?utf-8?B?bjNzczFNMEpjSFJydDN5TDZtNU1BQUppUkl2bmZ0SnROcUg4Q1QwSGdFeFhn?= =?utf-8?B?QXhuK2hTcVBHTUhkREJCcmZMRU1uYklIOFdMemMyTWxaeFJZbWk5N0phWkxo?= =?utf-8?B?TnBxdFB1ZE9IUjF5OVVNY2ZsSEdwb2FBQ0xDeXhyYjZFaDdWVXI5TC9IeTFP?= =?utf-8?B?Y1NPbzg5bkNBcFM2STJIWWQ2WXRqRmlRZzlUN2lManV6SmtlWlpJQnIwL2ww?= =?utf-8?B?VEJEUm5CaHMxWXNoZW93cnRrYURYTDlhOXBmdWdPK3NYZU9mWEhBN2NtZU93?= =?utf-8?B?QkM2cTRYekpncGpQbjVhdnJ5allCd2E5bkhuUWNwYThwckZTcnNtalBvbjd4?= =?utf-8?B?Nm9URE9iZXU5UTBmaWdmN3BqVGJ6MVMwWUtTdzMxRjI4UlQrUWZCSUY4ZzIx?= =?utf-8?B?THFXbXBBS3UxVEhORWRLM1RTV2hrSDg4NVdkM3U2dTdlSm84RldXbVBSSit1?= =?utf-8?B?YWRab0VyM05sRzdwMldvOHo1bkpxY1BzcUtPSXJrT2kzL0Y0M3E2MWk4Rk9N?= =?utf-8?B?RVV1ajlPRlJWZnR1WFVvL0JYWFdMV0MyUE8zUGk2djQ5dnVsRUpnWnlXeFdp?= =?utf-8?B?V1ZJREtnRk5FUFBqWlJzZW4zekFFYTZhY1ZvVUpsM0daWlVLQjZvT3IwN3Ri?= =?utf-8?B?SkhEU2pHUnVOS3pNNnVtYXNmWFREVjNMaUxnekdnK1dLWWtVekpvUW9rYksy?= =?utf-8?B?V0Y4ZENnelFUY29tWGJzUG5mdEtML2NWTUMwb0N0aUI5a0VEa0lmajdOeUZB?= =?utf-8?B?SXY4cVRjOHVIYXFrRm1MclBXOWozMG8xSDVqNmhDbXpTVzA2Q1R6a2p0dGFm?= =?utf-8?B?LzdhazZwRHdGUis5ZGFsMjRLVnBpU2FCZytjcHlVc1ZEV29lUGpuVyt3MlpM?= =?utf-8?B?eG50M1VMZ1NYVytvbVJ4ZXJ3RmJKWlplVmZ6SG1RUjdIQWo4RlFEWVBvZzhB?= =?utf-8?B?RUY4SnNWc2U1aTRpZCtSMVlJbnJLUG96QzlVTHJ3NmozRTEzeTBlZmJ2VTlq?= =?utf-8?B?Q3I3aWJxaWxpazhDT2RhUHJ2T2Q5VVZETmNJTWpoTzhiYllNaGpoQlNPT1Ft?= =?utf-8?B?VzNWcGsyWE5xQ1Jya1VRZjJZZzNPM29mdUdkNjNKdVJEQm9vOU5CSmo0Q2xX?= =?utf-8?B?WFdxVTRxSTlQL25oOGZrUzFZV2NqMGgwUm4zYmVvb3Z2TmQwV3MzN2pMOGc3?= =?utf-8?B?bjUrZVZSOEMwNHh6UHpJT284UXFiWUgya1JjNVBodlpxN3RzREdpYUVBYXNn?= =?utf-8?B?NlN6VmllclpXRFF4RDNvR1J6Ym03S0hEN05yVFZiTzh2VEFQQllwam9HMUM3?= =?utf-8?B?ZkdjcWRPVkhhOWRjSW5IUTRFcVZFcTNnVnFoR2FzODJJWDNyTzZXUFlQWjdl?= =?utf-8?B?M3JOMEdkYmpDSjJPWmNuVmtQTGdUckczeTgxQXlFM1RRdVQ0SG54Qzg0ejBn?= =?utf-8?B?d2RNdHI2VURMZCsvQzZSY2lBSmQ1dS9FRGxTcUUrOHBCc1huYzE3UEpSQ3pz?= =?utf-8?B?ZVI1Z2NGQTNzNE9VaUhSU002eFMxUktjOFVnYktCZTlGbjNJRHkxUXZueGVN?= =?utf-8?B?UzRIam1IdDhtTHU0WlJsem80YXAybmJSc0NyNlJkMmNZOXBWcHZpNk1VbmNq?= =?utf-8?Q?khtjO5zLGuSJ3kheNvUPveAVDd74phhlHoFAlhF?= X-Microsoft-Exchange-Diagnostics-untrusted: 1;BY1PR03MB1369;5:+8KrQXtZlQPBhrMRZg113EBR7HFhydPwW2g4Kc1c2K9lusik4DWoSP8B9FmoUL8Tp1/Ozfx+6G1aduK5lKybJ4MgS5JMkUHNaEmS2x9U6zvIM1SsJqMW5wi7LPX1TE4s3q6i+Y2ijODdXF2UFng7oQ==;24:RCPxRVp017M5eroHXdvRUMEj06J4OyNfKCtrTJQqAsJmWLfJ85AKVQwFmO0omG5RTS7vI3glUUYOXNVPUXhZRqdPAlGatV2L9Ne4+yZCD0Y=;20:5BIV25zgL3UUccJGbzXMMeOd02+n1rYXS69p62UQrsdY0JjADDGbZUrcvUYUeb7bJugZtFQwIStzy+8aYgEEYt7wAdMq33NdhYsKash3ZrxD7gezYQ8sfJtZaxP6gZro4wMC+ZqdV7/BcJsbDf3sMfspeFWotzsV+gdOiuR3FTo= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1369 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: BY2FFO11OLC009.protection.gbl X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11OLC009;1:+y02UKUxb1gtUN1YAqv7dwsrj1t3iG0crOp2v+LviUO5rQ1eGn9uQHIww5pzxBmenc4q8eiEaTdQBfWvAbm1bPzK+S9oyKj/PIeMrDU+uPm7/lWX59Y5EUpkBgnyvOyPIy4dI2EPNOx4WNwC7nsZvdxGldAuUPnI9IWPYTPd3GRkRGU+uoo20eNNg8QS9XBDHsKGuAT8xaBrZmcjBINmozWCFXyIVskfPHI0/tTxY+37jXeX55Z7lS1rn9lVbwz9ncwOWQBxlgBf8LGXDxniiX5RROZYS16iJtpmImLLg0yAxmPp48sX1V6+8CohSWV/qAZhqeWkC/Bp6b6ghsswr2+iUsZmXWqTfV+hhCbRjJTPA38y4LlT+Jv6pJLr8kbW X-Forefront-Antispam-Report: CIP:66.35.236.227;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(1110001)(1109001)(339900001)(24454002)(189002)(199003)(479174004)(377454003)(2950100001)(40100003)(106466001)(16796002)(65956001)(87266999)(65816999)(65806001)(47776003)(90366008)(92566002)(66066001)(21840400001)(956001)(86362001)(105606002)(87936001)(5001960100002)(76176999)(54356999)(33656002)(50986999)(4326007)(83506001)(189998001)(1096002)(5004730100002)(59896002)(11100500001)(93886004)(110136002)(4001350100001)(64126003)(85426001)(6070500001)(80316001)(77096005)(97736004)(6116002)(586003)(3846002)(230700001)(6806005)(81156007)(50466002)(5008740100001)(1220700001)(23676002)(122386002)(7099028)(217873001);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR03MB439;H:sj-itexedge03.altera.priv.altera.com;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;MX:1;A:0;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB439;2:mHY4bDIYSpKcTbK49wG3gNNdm5tYjqbRgi9BEVeygy7TS3+mgNtXXKNDLiEwvmHF5u1q93ajBUaguABfQ4eVYxNZdaSMtdgWNrTpXs3Ruri/iMKuqo6Mdpxo4Zf/9iY6VdFXaA4H50G0WYAmIYvYRQ==;3:hLsmG45IrGzr61reCcMUXjE0JAvTN8Y2XQbCc9GK4brpWbIvOyV3iNCtOM+1kv+RrxJlHnnxPIt6UprYzzU4YfLTu5bAgyb8gOwADdmNxxkfx52CAGQUiwejxqr/BTzLvXFRt1Z/VK0WBiKLuTwkhihfjeuLRH921zC2bPLUhK7mybMrXp33kV1429JQboNNwDlyZNAFHtYI3roy6NjphiljK0PBjOzciRqNpCu+63uD6OaVEZqTvZpIm/GHhrci;25:nEifJKW2jc9rYCROO5vGo6AuQPn74Ovrp0BZUwfjvOqbNjQImspENoBZD0V4R5cokzSAPeentu+qbmHEqrLa/yPD4oilsnVrYVdaht/y0Ot70FcI6s3kFiA0CNvWs8BKIeBYFlxPDFzUea5w/mBR8MKb5uLC6nMWzHgJ5H+jVN0ij/Ysu+d/eA/LDemu4ZK+z4/iiV52dx6YJ6nIP4KTEu9vun+ytITVV6Shz7Nn0dHoAUCUTTNRAe+LS8eeXIAgctB7jwQSYaRHpAvx8V1yGA==;20:ZcN0R100pd3TU2DaqelyMk9eWtzmG0/qpMDeJMUG4LTY8ZHUxMBjZJvG9KVa6qORKe60AA/69FwEdn1COm4h4CoWJDfYbC/7UGFnBSEsZbVkmJgiA4/gqERkWCch1PIr6M50yCaoCwCR+PR1kS94c72pXRiJbSxV4irNnbfrJ4k= X-DkimResult-Test: Passed X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(3001015);SRVR:BLUPR03MB439; X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB439;4:sap+EM/5H8EV6jn8kNdsjGZJUL5g9KCqtGRZx+RvIe2QWv67fU0qw3j7vjb89V7zHrFdtOcYIjhZJWxqMUeKJCp1F+LlPpbGwHoxeJ9ybtrkqGiD5sgxZLjEiu4XfsbFZRJ/h7gpkiWrqGKiBLJ11WEPjmtWLYphwuDjNGpXNbwKkFQrL/x21ipoJ249k0gOOP99oMQEC82gr2gJazT94vr+wSX22X9NzHcLpgAtW5QbMYLU9IJc9XFiN+nl2Y48ruUOXQAdQy3VvtKdTV1DQ6407tBV2I9N44O882ONK8LXyzddgF322S2WDK8TfNj1zY5evtCvxJ2ay2QFNuyp3USuTxCHkehKrAMkgrqBeowRorWw5F/xuHo1XUCTfdT/ X-Forefront-PRVS: 08118EFC2B X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTFVQUjAzTUI0Mzk7MjM6M0NOU2k2NG1Nb1pQMFRHT05XTWRCdEQzaFZP?= =?utf-8?B?MktSS0Y4LytHNmpQWktaMnZQV0kwbGZieUx3SHkxTjZuT05DK3drR0piLzBh?= =?utf-8?B?S25SWFk5YXg2NGxRRVJuWm50bllKRzl1bFN4UVpOM24vTWdxWnZVT21OV2NW?= =?utf-8?B?b1lRdnlLQjZnSWFOREd1cTdGNTdmdjJZVy9yUmxxMDZiZjdCQUNZUHo1Z3B1?= =?utf-8?B?dFZBUFBEc1ZHZ0EwaGhLemJRMENhK01aZXRPSWkxMmRMWVNUQTRWRW91Ynpn?= =?utf-8?B?dk1pWHJ4VldrRy8vQzBkZk45R1dOa1FBVWk2Z3ZsL3BJRm5QUXYxZk05L3FC?= =?utf-8?B?RkE0RE94TkVlQktlN1RoTVhoUnVrOHoxMGlsbFVOQWJKRzB1ZG55bkEyelV4?= =?utf-8?B?UXpPQzNJcGsvZHZvNmhrSno0ajNqOVI3RUFrVlVCcmJmRDl3V29adlpoNmts?= =?utf-8?B?NVZ4QVNCc2ZqSGNVbFIremR0dzJDUXdBQTFnOVJlRW01d3pyUkFxYXNyblNG?= =?utf-8?B?bGhlVzRhTHE4WWhOSFJCRHJDcU1uWlRDdFNSY1hPTnZ5OFhlQ1hHK3VUSHZ2?= =?utf-8?B?TFRYWUVSeUJrd3M3WTdSVkdrZjA3QUlXK2l6MytDN1hBU3JnN3BYYkwxY1l6?= =?utf-8?B?ak1lQ2haUzZZNTUvcng0Z3Q1Vi9tcm9ESG1NZGltWTV3N21NTUttQzRKcERK?= =?utf-8?B?Ukh2YmltY0swcUZUdy9SdmhvTlBJdkVQczV6YWxuSFhSNGVDUS9uMzVXdXcy?= =?utf-8?B?T3dTTWZocXBKWG1pbWV1SEhtZE5ra0Q4aW1GaGxSSkpiYVQrWmFyTkI1bWQv?= =?utf-8?B?VFpvVGV5WndWMzlnZHl0U2lYRW1CRFNmZnN1NVJRbElJZ1Iza1F3dk1hb05p?= =?utf-8?B?VkEydFkwdzYrOVpXY0VQR3E4QWV2enhBMzlmWmM4cVFnOWFXeHF4SjBQSExZ?= =?utf-8?B?Wmx5ZjZNZDRJZFhnRkYrMmN3N1hUeFcySXJ4L3pkSFBEcy9aMzNGU21BVGRv?= =?utf-8?B?SVp4TVk4bk80NU9hZEx0S0JPeGgwN0tYQUNTeFdpakx3UVgwMTFWVGRVNHE4?= =?utf-8?B?NEYxak44YmRtRkt3NnR4bkg2NHhmV1JtSDlBb25yY2p1Mm13Z1hpS0pBNWNK?= =?utf-8?B?NDNhb2VaZFNreW05c3lvVjBycjRxRll2b1EwcFYydjdKdEVRbktMSDcwZ2dw?= =?utf-8?B?djV5Wk8wL1dFR3RIOFRoMjAwY3VsVzVHR0pHbTZJQ1hxcjEzRXV6VG5xZm5T?= =?utf-8?B?Q0NTUm16VHpLZk9vczU3b3VXYnhPOWE4NURDYVBEWGlmd3N6UDBVTkpnRy93?= =?utf-8?B?RE9VWVZhVlJGYkdLc3RhWUhOWGZuM3R6YVpKNFZTMHJCZi9hb0F1aitoNWtD?= =?utf-8?B?ald6TWtDL0JOWVpXRlNNMWVKVUdXbTYwemRxNmpnOTREcExGVG1JNDVycE9q?= =?utf-8?B?Y0NGREdHbkFmbFR1SHpKaG4yNjBIT25JMmRsWXJUNDVsbDFQUjRYUi92YUFz?= =?utf-8?B?RHZkYklHNFlJSm9YRlpablNweFZvcFE4dHpEYXJjVnRnRVJxalZ5UHVIVmxK?= =?utf-8?B?MXY5ZktWVUZpZTVFZ2h2bDJrRFIvVDBVd0JkSC9vMVUzMlZMaFlmZDIzakRY?= =?utf-8?B?VUMySlRhU1NNZ3ZXQWt1ZEFCSmJEM2k1bFhyVStZVVN1Q2x5aDVsK2hZWU1U?= =?utf-8?B?cSswR2g0T0VmUUZCbjhreHVpQWRUZ0ROODNzcmEzQTlKR2dvVTBVTzZnb2Vz?= =?utf-8?B?RlQzSzI0L2JxblZZaFJCNFB4QXZkQnpLajhCWHgwamkwQWxSdWRTdmZBU3dM?= =?utf-8?B?WXh1cSttWElKTlJEODBwOGV5K3VJQitiUVRISjZTOEMxOWZJZFJtUXIrRXcy?= =?utf-8?B?TjY3djdjYkJrVlJWY3VTOENFZStFdDlYYVJXWkQxMGcySEFNQmhCQlNhRCs4?= =?utf-8?B?aUdSTDJqa01YRFJlM3JQN2pjenBHMEpRZXg0NWhWNzZmeGtrK28zU3ZzQUZI?= =?utf-8?B?cHVUR21xS0t1Qk0rL2NRdG9yYnNvL3c1UVhHUlpKeTVxRTRqTXBYcUdSSnYy?= =?utf-8?Q?m7XjUftea/HUaVFNOpE0Fp5T?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB439;5:i+f/AFmqVsQtih0/V91fHJQbvFLkrjHwts7sMQBbcbstUxURMTTOrgrEGYClS1HF9U1cuV1glcyVsO3Mt5hZo/qx19XS3RVM+TzHlUfhCY+Dsvp94pA6mdnFeetbNybWPqOZHQKMsQyAd7AuZlxkkw==;24:Lgacolcka9ZgzjpJ9Zte9Br5ubvR4aKd1Ht4pN4IDLMLntB6hfHEuAOHz0K/PnBXc4eBsDRT2ugvBcTJQMd/TcHGki3m5nhVzmXdGhako68=;20:mypCLn6ENcZkKS++K+gspxgJHSJm+FYhMwReoVjxZaMrRWTAJkLaeQ5PxUlEXlH+8mIxSfITPOB9tWdVjmITMkCSB9evZOqcbzOa3IlqcUE8CNr/JFMsTJyUvzOo/p2n+/ht9XkogR8meEw0IwpRoeSkyUtlkWMKlRkTFkrjZnc= X-OriginatorOrg: opensource.altera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2016 20:10:52.0609 (UTC) X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a;Ip=[66.35.236.227];Helo=[sj-itexedge03.altera.priv.altera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB439 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/04/2016 01:46 PM, Borislav Petkov wrote: > On Mon, Jan 04, 2016 at 11:17:29AM -0600, Dinh Nguyen wrote: >> We tried to jam the L2 and OCRAM EDAC functionality in the same >> altr_edac.c file. It looks like it might be clean if we split out the L2 >> and OCRAM functions into their appropriate files(altr_edac_l2.c and >> altr_edac_ocram.c). Do you agree? > > "Clean" in what sense? To me clean is when there's a single compilation > unit altera_edac.c which contains all Altera-specific code. > altr_edac.c originally added support for SDRAM. Now we're adding support for L2 and OCRAM into the same file by using #ifdef CONFIG_EDAC_ALTERA_OCRAM and CONFIG_EDAC_ALTERA_L2C. So "clean" was to move the l2 and ocram implementation into separate files. Dinh