From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Geyslan G. Bem" <geyslan@gmail.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
LKML <linux-kernel@vger.kernel.org>,
linux-usb@vger.kernel.org
Subject: Re: [PATCH 08/17] usb: host: ehci-dbg: remove unnecessary space after cast
Date: Tue, 5 Jan 2016 00:52:10 +0300 [thread overview]
Message-ID: <568AE98A.4030103@cogentembedded.com> (raw)
In-Reply-To: <20160104214924.GA13959@kroah.com>
Hello.
On 01/05/2016 12:49 AM, Greg Kroah-Hartman wrote:
>>>> This patch fixes coding style issues reported by checkpatch concerning
>>>> to unnecessary space after a cast.
>>>
>>> This is a case where checkpatch is wrong, IMO. Casts should always be
>>> followed by a space. I will not accept this patch.
>> Ok. I understand.
>>
>>>
>>> This must be something recently added to checkpatch. It never used to
>>> complain about casts, whether they were followed by a space or not.
>> I'm using the checkpatch --strict option.
>
> Please never use that on existing kernel code, except for
> drivers/staging/ stuff, otherwise your patches will start to very
> quickly be ignored.
Just wanted to remind everybody that this option is forced when checking
the networking code...
> thanks,
>
> greg k-h
MBR, Sergei
next prev parent reply other threads:[~2016-01-04 21:52 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-04 20:09 [PATCH 00/17] usb: host: ehci-dbg: cleanup and refactoring Geyslan G. Bem
2016-01-04 20:09 ` [PATCH 01/17] usb: host: ehci-dbg: remove space before open parenthesis Geyslan G. Bem
2016-01-04 20:09 ` [PATCH 02/17] usb: host: ehci-dbg: remove space before open square bracket Geyslan G. Bem
2016-01-04 20:09 ` [PATCH 03/17] usb: host: ehci-dbg: use C89-style comments Geyslan G. Bem
2016-01-04 20:09 ` [PATCH 04/17] usb: host: ehci-dbg: move trailing statements to next line Geyslan G. Bem
2016-01-04 20:09 ` [PATCH 05/17] usb: host: ehci-dbg: fix up closing parenthesis Geyslan G. Bem
2016-01-04 20:09 ` [PATCH 06/17] usb: host: ehci-dbg: put spaces around operators Geyslan G. Bem
2016-01-04 20:09 ` [PATCH 07/17] usb: host: ehci-dbg: fix unsigned comparison Geyslan G. Bem
2016-01-04 20:50 ` Alan Stern
2016-01-04 21:35 ` Geyslan G. Bem
2016-01-04 21:52 ` Alan Stern
2016-01-04 20:09 ` [PATCH 08/17] usb: host: ehci-dbg: remove unnecessary space after cast Geyslan G. Bem
2016-01-04 20:58 ` Alan Stern
2016-01-04 21:40 ` Geyslan G. Bem
2016-01-04 21:49 ` Greg Kroah-Hartman
2016-01-04 21:52 ` Sergei Shtylyov [this message]
2016-01-04 22:07 ` Geyslan G. Bem
2016-01-05 2:40 ` Joe Perches
2016-01-05 15:16 ` Geyslan G. Bem
2016-01-05 16:41 ` Alan Stern
2016-01-04 20:09 ` [PATCH 09/17] usb: host: ehci-dbg: fix up function definitions Geyslan G. Bem
2016-01-04 21:00 ` Alan Stern
2016-01-04 23:28 ` Geyslan G. Bem
2016-01-05 15:12 ` Alan Stern
2016-01-05 15:20 ` Joe Perches
2016-01-05 15:23 ` Joe Perches
2016-01-05 15:27 ` Geyslan G. Bem
2016-01-05 15:36 ` Geyslan G. Bem
2016-01-05 16:06 ` Alan Stern
2016-01-05 16:10 ` Joe Perches
2016-01-05 16:29 ` Alan Stern
2016-01-05 17:03 ` Geyslan G. Bem
2016-01-04 20:09 ` [PATCH 10/17] usb: host: ehci-dbg: use a blank line after struct declarations Geyslan G. Bem
2016-01-04 20:09 ` [PATCH 11/17] usb: host: ehci-dbg: convert macro to inline function Geyslan G. Bem
2016-01-04 20:09 ` [PATCH 12/17] usb: host: ehci-dbg: add blank line after declarations Geyslan G. Bem
2016-01-04 20:09 ` [PATCH 13/17] usb: host: ehci-dbg: remove blank line before close brace Geyslan G. Bem
2016-01-04 20:09 ` [PATCH 14/17] usb: host: ehci-dbg: replace sizeof operand Geyslan G. Bem
2016-01-04 20:10 ` [PATCH 15/17] usb: host: ehci-dbg: enclose conditional blocks with braces Geyslan G. Bem
2016-01-04 20:10 ` [PATCH 16/17] usb: host: ehci-dbg: prefer kmalloc_array over kmalloc times size Geyslan G. Bem
2016-01-04 20:10 ` [PATCH 17/17] usb: host: ehci-dbg: refactor fill_periodic_buffer function Geyslan G. Bem
2016-01-04 21:01 ` Alan Stern
2016-01-05 1:19 ` Geyslan G. Bem
2016-01-05 15:15 ` Alan Stern
2016-01-05 15:41 ` Geyslan G. Bem
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568AE98A.4030103@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=geyslan@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox