From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753514AbcADVwR (ORCPT ); Mon, 4 Jan 2016 16:52:17 -0500 Received: from mail-lf0-f54.google.com ([209.85.215.54]:35543 "EHLO mail-lf0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752055AbcADVwO (ORCPT ); Mon, 4 Jan 2016 16:52:14 -0500 Subject: Re: [PATCH 08/17] usb: host: ehci-dbg: remove unnecessary space after cast To: Greg Kroah-Hartman , "Geyslan G. Bem" References: <11dd04072f65c0b168a9d842549c3705a34076b3.1451937845.git.geyslan@gmail.com> <20160104214924.GA13959@kroah.com> Cc: Alan Stern , LKML , linux-usb@vger.kernel.org From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <568AE98A.4030103@cogentembedded.com> Date: Tue, 5 Jan 2016 00:52:10 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20160104214924.GA13959@kroah.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 01/05/2016 12:49 AM, Greg Kroah-Hartman wrote: >>>> This patch fixes coding style issues reported by checkpatch concerning >>>> to unnecessary space after a cast. >>> >>> This is a case where checkpatch is wrong, IMO. Casts should always be >>> followed by a space. I will not accept this patch. >> Ok. I understand. >> >>> >>> This must be something recently added to checkpatch. It never used to >>> complain about casts, whether they were followed by a space or not. >> I'm using the checkpatch --strict option. > > Please never use that on existing kernel code, except for > drivers/staging/ stuff, otherwise your patches will start to very > quickly be ignored. Just wanted to remind everybody that this option is forced when checking the networking code... > thanks, > > greg k-h MBR, Sergei