linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Austin S. Hemmelgarn" <ahferroin7@gmail.com>
To: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	Pierre Paul MINGOT <mingot.pierre@gmail.com>,
	jslaby@suse.cz, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Add possibility to set /dev/tty number
Date: Tue, 5 Jan 2016 08:16:52 -0500	[thread overview]
Message-ID: <568BC244.5040207@gmail.com> (raw)
In-Reply-To: <20160104225544.158dc847@lxorguk.ukuu.org.uk>

On 2016-01-04 17:55, One Thousand Gnomes wrote:
>>> If the console isn't initialized by userspace, is any of that space
>>> still really being used?  Have you tried that?
>> I'm pretty certain that most of the space that gets taken up by the
>> scrollback buffer and screen isn't directly used unless the console is
>> used, but there are still structures that get allocated at driver
>> instantiation for each VT, including the device structures and such.
>
> So fix that instead.
I never said that it was broken, I was just pointing out that the 
overhead is non-zero even when the VT is unused.
>
> And really for low memory embedded why do you even have the VT layer in
> your system in the first place ?
Sometimes this is unavoidable.  Any kind of generic system generally 
wants the VT layer, and there are a number of low memory embedded 
systems that I've seen that depend on the ability to switch VT's for 
their software to work correctly.
>
>>> If we remove the number of devices, those "broken" userspace programs
>>> will also break, so that implies that we should not allow this change.
>> No, the software should just need to be recompiled (I've tested this
>> with ConsoleKit, which also fails gracefully when it tires to open a tty
>> device that doesn't exist), or adapted to dynamically detect the number
>> of TTYs (like it should have in the first place for portability reasons).
>
> We don't do regressions.
Requiring only a recompilation isn't a regression, especially when it 
works fine without being recompiled, and I have yet to actually see 
anything that changing the number of VT's would break other than 
ConsoleKit (systemd-logind might also need a rebuild, but I'm not sure 
about that, and don't have a system I could test it on).
>
>> device drivers). I doubt that it will work out to any more than 16k size
>> difference, but that's still a few more pages (on most systems) that
>> could be used for other things.
>
> And those embedded devices can almost certainly save more by just not
> including the vt layer.
And a few pages can make a difference on _any_ device, not just an 
embedded system.  For a purpose specific system, that can be the 
difference between fitting the working set in memory and having to hit 
swap space.

  reply	other threads:[~2016-01-05 13:18 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-04 15:34 [PATCH] Add possibility to set /dev/tty number Pierre Paul MINGOT
2016-01-04 15:43 ` Greg KH
2016-01-04 16:57   ` Austin S. Hemmelgarn
2016-01-04 17:11     ` Greg KH
2016-01-04 18:41       ` Austin S. Hemmelgarn
2016-01-04 22:55         ` One Thousand Gnomes
2016-01-05 13:16           ` Austin S. Hemmelgarn [this message]
2016-01-05 15:24             ` Greg KH
2016-01-05 15:33               ` Austin S. Hemmelgarn
2016-01-05 16:11             ` Theodore Ts'o
2016-01-05 16:22               ` Austin S. Hemmelgarn
2016-01-05  8:51         ` Pierre Paul MINGOT
2016-01-05 13:02           ` Austin S. Hemmelgarn
2016-01-05 15:25           ` Greg KH
2016-01-05 15:43             ` Austin S. Hemmelgarn
2016-01-05 16:03               ` Greg KH
2016-01-05 18:38         ` Austin S. Hemmelgarn
2016-01-05 20:47           ` One Thousand Gnomes
2016-01-06 12:42             ` Austin S. Hemmelgarn
2016-01-06 13:54               ` One Thousand Gnomes
2016-01-06 14:07                 ` Austin S. Hemmelgarn
2016-01-06 13:39 ` Austin S. Hemmelgarn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=568BC244.5040207@gmail.com \
    --to=ahferroin7@gmail.com \
    --cc=gnomes@lxorguk.ukuu.org.uk \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingot.pierre@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).