From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751934AbcAEOFN (ORCPT ); Tue, 5 Jan 2016 09:05:13 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:52028 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751104AbcAEOFJ (ORCPT ); Tue, 5 Jan 2016 09:05:09 -0500 Subject: Re: [PATCH V11 4/7] dma: add Qualcomm Technologies HIDMA channel driver To: Andy Shevchenko References: <1451865996-12808-1-git-send-email-okaya@codeaurora.org> <1451865996-12808-5-git-send-email-okaya@codeaurora.org> Cc: dmaengine , Mark Rutland , Timur Tabi , devicetree , Christopher Covington , Vinod Koul , jcm@redhat.com, Andy Gross , Arnd Bergmann , linux-arm-msm@vger.kernel.org, linux-arm Mailing List , "linux-kernel@vger.kernel.org" From: Sinan Kaya Message-ID: <568BCD92.7020306@codeaurora.org> Date: Tue, 5 Jan 2016 09:05:06 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/4/2016 1:43 PM, Andy Shevchenko wrote: >> his patch adds support for hidma engine. The driver consists of two >> > logical blocks. The DMA engine interface and the low-level interface. >> > The hardware only supports memcpy/memset and this driver only support >> > memcpy interface. HW and driver doesn't support slave interface. >> > > Looks fine now. > > Reviewed-by: Andy Shevchenko > Thanks. I'll wait until the end of the week to address your other comments. I'm hoping to hear from devicetree folks until that time. -- Sinan Kaya Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project