From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751679AbcAEO3p (ORCPT <rfc822;w@1wt.eu>);
	Tue, 5 Jan 2016 09:29:45 -0500
Received: from mailout2.w1.samsung.com ([210.118.77.12]:61584 "EHLO
	mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751188AbcAEO3m (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 5 Jan 2016 09:29:42 -0500
X-AuditID: cbfec7f5-f79b16d000005389-7f-568bd3546c63
Subject: Re: [PATCH v6] coccinelle: tests: unsigned value cannot be lesser than
 zero
To: Julia Lawall <julia.lawall@lip6.fr>
References: <alpine.DEB.2.02.1512301502100.2048@localhost6.localdomain6>
 <1451893531-15817-1-git-send-email-a.hajda@samsung.com>
 <alpine.DEB.2.10.1601051512010.2521@hadrien>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Gilles Muller <Gilles.Muller@lip6.fr>,
        Nicolas Palix <nicolas.palix@imag.fr>, Michal Marek <mmarek@suse.com>,
        open list <linux-kernel@vger.kernel.org>,
        "moderated list:COCCINELLE/Semantic Patches (SmPL)" 
	<cocci@systeme.lip6.fr>
From: Andrzej Hajda <a.hajda@samsung.com>
Message-id: <568BD347.7010303@samsung.com>
Date: Tue, 05 Jan 2016 15:29:27 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.4.0
MIME-version: 1.0
In-reply-to: <alpine.DEB.2.10.1601051512010.2521@hadrien>
Content-type: text/plain; charset=windows-1252
Content-transfer-encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrELMWRmVeSWpSXmKPExsVy+t/xq7ohl7vDDC6cEbfYOGM9q8WPTavZ
	LGb/vMRksezBaUaLy7vmsFmsPXKX3WJO6yw2i2MvlzM5cHgcO9bK7LF3S5ZH35ZVjB7rt1xl
	8Xi07D6Lx+dNcgFsUVw2Kak5mWWpRfp2CVwZRz4sZC+YzF7ROOcDWwPjftYuRk4OCQETid41
	zWwQtpjEhXvrgWwuDiGBpYwSrb0HWSCc54wSMyb9YAapEhYIkzg3uQXI5uAQEVCX6P2QC1Gz
	kVFi0vP57CAOs8AlJokVv16ygDSwCWhK/N18E2wFr4CWxKm/H8EGsQioSvy+M4MVZJCoQITE
	oh2ZECWCEj8m32MBCXMKWEps+esIYjIL6Encv6gFUsEsIC+xec1b5gmMArOQNMxCqJqFpGoB
	I/MqRtHU0uSC4qT0XCO94sTc4tK8dL3k/NxNjJCQ/7qDcekxq0OMAhyMSjy8G551hQmxJpYV
	V+YeYpTgYFYS4X19pDtMiDclsbIqtSg/vqg0J7X4EKM0B4uSOO/MXe9DhATSE0tSs1NTC1KL
	YLJMHJxSDYyer4/qHT58WfXVzEs5LGGruQpbJq2V9Smazr+nfL3+cZ6VCxwqDknevbCq1EdA
	KzlthXLxUdayVWsTck1nPWS6fXBSZ9xuBcVdZm79W5muHrR6zxYffHOea/jGvTt8s/oUYv/I
	HOVPFHm2TEnof0GC+rTeCdo58S+jfY+eLuXba7lEcX3RNQElluKMREMt5qLiRAAS5PtqdQIA	AA==
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 01/05/2016 03:17 PM, Julia Lawall wrote:
>> +@script:python depends on org@
>> +p << r_cmp.p;
>> +e << r.e = "";
>> +@@
>> +
>> +msg = "WARNING: Unsigned expression compared with zero: %s" % (e)
>> +coccilib.org.print_todo(p[0], msg)
>> +
>> +@script:python depends on report@
>> +p << r_cmp.p;
>> +e << r.e = "";
>> +@@
>> +
>> +msg = "WARNING: Unsigned expression compared with zero: %s" % (e)
>> +if e:
>> +    coccilib.report.print_report(p[0], msg)
> Is it intentional that these don't do the same thing?  The report case has
> an if on e, while the org case does not.  If you don't want a report when e
> doesn't have a value, you could just remove the = "" from the declaration of
> e.  That is to give a default value of e, to allow the rule to be executed
> when e doesn't have a value.
>
> julia
>
>
No, I forgot to adjust it. I will fix it then, thanks.

Regards
Andrzej