From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751959AbcAEQiE (ORCPT ); Tue, 5 Jan 2016 11:38:04 -0500 Received: from www62.your-server.de ([213.133.104.62]:43162 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751487AbcAEQiA (ORCPT ); Tue, 5 Jan 2016 11:38:00 -0500 Message-ID: <568BF162.7030008@iogearbox.net> Date: Tue, 05 Jan 2016 17:37:54 +0100 From: Daniel Borkmann User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Rabin Vincent , Eric Dumazet CC: davem@davemloft.net, netdev@vger.kernel.org, ast@kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@linux-mips.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: filter: make JITs zero A for SKF_AD_ALU_XOR_X References: <1452007387-626-1-git-send-email-rabin@rab.in> <1452009645.8255.96.camel@edumazet-glaptop2.roam.corp.google.com> <20160105160345.GA3951@debian> In-Reply-To: <20160105160345.GA3951@debian> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/05/2016 05:03 PM, Rabin Vincent wrote: > On Tue, Jan 05, 2016 at 08:00:45AM -0800, Eric Dumazet wrote: >> On Tue, 2016-01-05 at 16:23 +0100, Rabin Vincent wrote: >>> The SKF_AD_ALU_XOR_X ancillary is not like the other ancillary data >>> instructions since it XORs A with X while all the others replace A with >>> some loaded value. All the BPF JITs fail to clear A if this is used as >>> the first instruction in a filter. >> >> Is x86_64 part of this 'All' subset ? ;) > > No, because it's an eBPF JIT. Correct, filter conversion to eBPF clears it already.