From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754516AbcAEU6L (ORCPT ); Tue, 5 Jan 2016 15:58:11 -0500 Received: from mout.gmx.net ([212.227.15.19]:58361 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754483AbcAEU56 (ORCPT ); Tue, 5 Jan 2016 15:57:58 -0500 Subject: Re: [PATCH v3 09/17] drivers: Initialize resource entry to zero To: Toshi Kani , akpm@linux-foundation.org, bp@alien8.de References: <1452020081-26534-1-git-send-email-toshi.kani@hpe.com> <1452020081-26534-9-git-send-email-toshi.kani@hpe.com> Cc: linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-parisc@vger.kernel.org, linux-sh@vger.kernel.org From: Helge Deller Message-ID: <568C2E3D.4060701@gmx.de> Date: Tue, 5 Jan 2016 21:57:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1452020081-26534-9-git-send-email-toshi.kani@hpe.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:djnuSZdKws2CQxy3La+rY7p2Gwk2IVQdVfGciS82vI+EEcliRRw bj9JW0S7l9FQVz4PESOYLEsYNmzxmzxCClL3oQvIFuf5TSMXtk6bucVL/7+0GO/gZ8eAQ/j Q9dBwyZREqtTerI6hLsnYJPO6eKBB3u7i3TTwYQX8Lc0KzANJ51muzPCV7X36l4XafFGs0y W3dfikIKuFXofsgAhxe6A== X-UI-Out-Filterresults: notjunk:1;V01:K0:7enr1ay1RMw=:nJzJBuFT5T18Zdco444tHm VwqTJc35QN7AtC8tD6mbSU+WdXs9jvPdn6twigeKuhg1QruTeqEzd7aY01lePPjxIiTeSWeK2 ox8a+aCNlkg3h6B9GcFC2Uiajh6+CWjLF4q7buK+i9qqOzZ48pOh/DqMnnct9dLHb77+Bo3v/ B+H0ehi3cB/N/oIQdXA/wUaNWB1ja4fdApSCfXinE992DpzcqRxiTrRZLxODiGBdmqmjjZjv6 BGct09DJMBXsEOFuTzgZXebuy7wMSb1YmImbuf5mPPsb7VieEPgFR7t+Ctyd8URZ9RRg8vM4G h4hJdhY2WYoV6lvu5uh+Z7V3G/e3TyetWY9XXwxM/vfcMxkNFQY/LuPwnJFeBa7YIX8KOF5E+ 43yoChll4nmCbf+kKOmSTGJ3WYf2sx2hb54qDv/RnNY+WS8yPVDOijs0xIOtnrRvWl+bnvTQB GlOcQwhAgTj7EZ+ec6NpsGstNBF6HQtR80iXadviRAQXCgutNPbdbIYUGkYLL7yRLH9vTnaCC xOXVdHVslNw7OrI0sl32s+t7eQ4JwaUwTkvTBF3I3xBRCIerETHkyQnfCEeKhN/u8sK0vyK4y NSWq1sf6XXNzMREtDzgBF2H8QkhOp0pY5EaBO7qVRmIMjGrcFGmoyYhib1CvDnsEbUwFZpfOw 8CE7XzvBQ84SV9VeGN46faoc0mn0M+F/17Loy2OlHOIEpKnEtB+lfSj2CFxXodEsbmqpA0ZJi HCz/rFc3EL23Ng2mPKO2ezVZAERJqABpUS94GY2W53KH5Tn52dwcUhZt+0r5ygWZv0Z+1rbO+ NYQUgL6P0ONZ3YMht1p1l1XxEgVwmk1LvT4n6Ecpep0PWIIFLQxSeokCh9FxS9xqC+6EVS2jH Z7IbfJJfHRTCG59KI9rv8DiVIyGij7j3zo5PMirKA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05.01.2016 19:54, Toshi Kani wrote: > I/O resource descriptor, 'desc' in struct resource, needs to be > initialized to zero by default. Some drivers call kmalloc() to > allocate a resource entry, but does not initialize it to zero by > memset(). Change these drivers to call kzalloc(), instead. > > Cc: linux-acpi@vger.kernel.org > Cc: linux-parisc@vger.kernel.org > Cc: linux-sh@vger.kernel.org > Acked-by: Simon Horman # sh > Signed-off-by: Toshi Kani > --- > drivers/acpi/acpi_platform.c | 2 +- > drivers/parisc/eisa_enumerator.c | 4 ++-- The parisc changes look good. For those: Acked-by: Helge Deller > drivers/rapidio/rio.c | 8 ++++---- > drivers/sh/superhyway/superhyway.c | 2 +- > 4 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/acpi/acpi_platform.c b/drivers/acpi/acpi_platform.c > index 296b7a1..b6f7fa3 100644 > --- a/drivers/acpi/acpi_platform.c > +++ b/drivers/acpi/acpi_platform.c > @@ -62,7 +62,7 @@ struct platform_device *acpi_create_platform_device(struct acpi_device *adev) > if (count < 0) { > return NULL; > } else if (count > 0) { > - resources = kmalloc(count * sizeof(struct resource), > + resources = kzalloc(count * sizeof(struct resource), > GFP_KERNEL); > if (!resources) { > dev_err(&adev->dev, "No memory for resources\n"); > diff --git a/drivers/parisc/eisa_enumerator.c b/drivers/parisc/eisa_enumerator.c > index a656d9e..21905fe 100644 > --- a/drivers/parisc/eisa_enumerator.c > +++ b/drivers/parisc/eisa_enumerator.c > @@ -91,7 +91,7 @@ static int configure_memory(const unsigned char *buf, > for (i=0;i c = get_8(buf+len); > > - if (NULL != (res = kmalloc(sizeof(struct resource), GFP_KERNEL))) { > + if (NULL != (res = kzalloc(sizeof(struct resource), GFP_KERNEL))) { > int result; > > res->name = name; > @@ -183,7 +183,7 @@ static int configure_port(const unsigned char *buf, struct resource *io_parent, > for (i=0;i c = get_8(buf+len); > > - if (NULL != (res = kmalloc(sizeof(struct resource), GFP_KERNEL))) { > + if (NULL != (res = kzalloc(sizeof(struct resource), GFP_KERNEL))) { > res->name = board; > res->start = get_16(buf+len+1); > res->end = get_16(buf+len+1)+(c&HPEE_PORT_SIZE_MASK)+1; > diff --git a/drivers/rapidio/rio.c b/drivers/rapidio/rio.c > index d7b87c6..e220edc 100644 > --- a/drivers/rapidio/rio.c > +++ b/drivers/rapidio/rio.c > @@ -117,7 +117,7 @@ int rio_request_inb_mbox(struct rio_mport *mport, > if (mport->ops->open_inb_mbox == NULL) > goto out; > > - res = kmalloc(sizeof(struct resource), GFP_KERNEL); > + res = kzalloc(sizeof(struct resource), GFP_KERNEL); > > if (res) { > rio_init_mbox_res(res, mbox, mbox); > @@ -185,7 +185,7 @@ int rio_request_outb_mbox(struct rio_mport *mport, > if (mport->ops->open_outb_mbox == NULL) > goto out; > > - res = kmalloc(sizeof(struct resource), GFP_KERNEL); > + res = kzalloc(sizeof(struct resource), GFP_KERNEL); > > if (res) { > rio_init_mbox_res(res, mbox, mbox); > @@ -285,7 +285,7 @@ int rio_request_inb_dbell(struct rio_mport *mport, > { > int rc = 0; > > - struct resource *res = kmalloc(sizeof(struct resource), GFP_KERNEL); > + struct resource *res = kzalloc(sizeof(struct resource), GFP_KERNEL); > > if (res) { > rio_init_dbell_res(res, start, end); > @@ -360,7 +360,7 @@ int rio_release_inb_dbell(struct rio_mport *mport, u16 start, u16 end) > struct resource *rio_request_outb_dbell(struct rio_dev *rdev, u16 start, > u16 end) > { > - struct resource *res = kmalloc(sizeof(struct resource), GFP_KERNEL); > + struct resource *res = kzalloc(sizeof(struct resource), GFP_KERNEL); > > if (res) { > rio_init_dbell_res(res, start, end); > diff --git a/drivers/sh/superhyway/superhyway.c b/drivers/sh/superhyway/superhyway.c > index 2d9e7f3..bb1fb771 100644 > --- a/drivers/sh/superhyway/superhyway.c > +++ b/drivers/sh/superhyway/superhyway.c > @@ -66,7 +66,7 @@ int superhyway_add_device(unsigned long base, struct superhyway_device *sdev, > superhyway_read_vcr(dev, base, &dev->vcr); > > if (!dev->resource) { > - dev->resource = kmalloc(sizeof(struct resource), GFP_KERNEL); > + dev->resource = kzalloc(sizeof(struct resource), GFP_KERNEL); > if (!dev->resource) { > kfree(dev); > return -ENOMEM; > -- > To unsubscribe from this list: send the line "unsubscribe linux-parisc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >