From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752236AbcAFKBS (ORCPT ); Wed, 6 Jan 2016 05:01:18 -0500 Received: from sg-smtp01.263.net ([54.255.195.220]:34453 "EHLO sg-smtp01.263.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751985AbcAFKBM (ORCPT ); Wed, 6 Jan 2016 05:01:12 -0500 X-Greylist: delayed 20644 seconds by postgrey-1.27 at vger.kernel.org; Wed, 06 Jan 2016 05:01:12 EST X-RL-SENDER: zyw@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: zyw@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v6.3 4/6] drm: rockchip: Support Synopsys DW MIPI DSI To: Mark yao , heiko@sntech.de, linux-rockchip@lists.infradead.org, treding@nvidia.com References: <1450260616-21160-5-git-send-email-zyw@rock-chips.com> <1450842215-10883-1-git-send-email-zyw@rock-chips.com> <568C7258.3010104@rock-chips.com> Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, airlied@linux.ie, linux-arm-kernel@lists.infradead.org From: Chris Zhong Message-ID: <568C9534.3050700@rock-chips.com> Date: Wed, 6 Jan 2016 12:16:52 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <568C7258.3010104@rock-chips.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark On 01/06/2016 09:48 AM, Mark yao wrote: > On 2015年12月23日 11:43, Chris Zhong wrote: >> +static int dw_mipi_dsi_register(struct drm_device *drm, >> + struct dw_mipi_dsi *dsi) >> +{ >> + struct drm_encoder *encoder = &dsi->encoder; >> + struct drm_connector *connector = &dsi->connector; >> + struct device *dev = dsi->dev; >> + int ret; >> + >> + encoder->possible_crtcs = drm_of_find_possible_crtcs(drm, >> + dev->of_node); >> + /* >> + * If we failed to find the CRTC(s) which this encoder is >> + * supposed to be connected to, it's because the CRTC has >> + * not been registered yet. Defer probing, and hope that >> + * the required CRTC is added later. >> + */ >> + if (encoder->possible_crtcs == 0) >> + return -EPROBE_DEFER; >> + >> + drm_encoder_helper_add(&dsi->encoder, >> + &dw_mipi_dsi_encoder_helper_funcs); >> + ret = drm_encoder_init(drm, &dsi->encoder, >> &dw_mipi_dsi_encoder_funcs, >> + DRM_MODE_ENCODER_DSI); >> + if (ret) { >> + dev_err(dev, "Failed to initialize encoder with drm\n"); >> + return ret; >> + } >> + >> + drm_connector_helper_add(connector, >> + &dw_mipi_dsi_connector_helper_funcs); >> + >> + drm_connector_init(drm, &dsi->connector, >> + &dw_mipi_dsi_atomic_connector_funcs, >> + DRM_MODE_CONNECTOR_DSI); >> + > Hi Chris > > I try to pick your patches, but found following issues: > > drivers/gpu/drm/rockchip/dw-mipi-dsi.c: 在函数‘dw_mipi_dsi_register’中: > drivers/gpu/drm/rockchip/dw-mipi-dsi.c:1024:5: 错误： 提供给函数 > ‘drm_encoder_init’的实参太少 > include/drm/drm_crtc.h:2220:5: 附注： 在此声明 > make[4]: *** [drivers/gpu/drm/rockchip/dw-mipi-dsi.o] 错误 1 > > Can you rebase to newest Dave's drm-next and fix this problem? Thanks Mark. I have post the v7 serial, fix this this compile err and modify the config to tristate for modules build > > Thanks. >