From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752133AbcAFGae (ORCPT ); Wed, 6 Jan 2016 01:30:34 -0500 Received: from regular1.263xmail.com ([211.150.99.135]:48857 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751341AbcAFGab (ORCPT ); Wed, 6 Jan 2016 01:30:31 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: <92d2b46af2fdd8abafc4472baf670b50> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <568CB47B.1010205@rock-chips.com> Date: Wed, 06 Jan 2016 14:30:19 +0800 From: Mark yao User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Chris Zhong , heiko@sntech.de, linux-rockchip@lists.infradead.org, treding@nvidia.com CC: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, David Airlie , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v7 3/5] drm: rockchip: Support Synopsys DW MIPI DSI References: <1452053038-32098-1-git-send-email-zyw@rock-chips.com> <1452053038-32098-4-git-send-email-zyw@rock-chips.com> In-Reply-To: <1452053038-32098-4-git-send-email-zyw@rock-chips.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chris Looks good for me except some tiny issues. On 2016年01月06日 12:03, Chris Zhong wrote: > +struct dw_mipi_dsi { > + struct drm_encoder encoder; > + struct drm_connector connector; > + struct mipi_dsi_host dsi_host; > + struct drm_panel *panel; > + struct device *dev; > + struct regmap *grf_regmap; > + void __iomem *base; > + > + struct clk *pllref_clk; > + struct clk *pclk; > + > + unsigned int lane_mbps; /* per lane */ > + u32 channel; > + u32 lanes; > + u32 format; > + u16 input_div; > + u16 feedback_div; > + struct drm_display_mode *mode; > + > + const struct dw_mipi_dsi_plat_data *pdata; > + remove this blank line. > +}; > + [...] > +static void dw_mipi_dsi_encoder_mode_set(struct drm_encoder *encoder, > + struct drm_display_mode *mode, > + struct drm_display_mode *adjusted_mode) > +{ > + struct dw_mipi_dsi *dsi = encoder_to_dsi(encoder); > + int ret; > + > + dsi->mode = adjusted_mode; > + > + ret = dw_mipi_dsi_get_lane_bps(dsi); > + if (ret < 0) > + return; > + > + if (clk_prepare_enable(dsi->pclk)) { > + dev_err(dsi->dev, "%s: Failed to enable pclk\n", __func__); > + return; > + } > + > + dw_mipi_dsi_init(dsi); > + dw_mipi_dsi_dpi_config(dsi, mode); > + dw_mipi_dsi_packet_handler_config(dsi); > + dw_mipi_dsi_video_mode_config(dsi); > + dw_mipi_dsi_video_packet_config(dsi, mode); > + dw_mipi_dsi_command_mode_config(dsi); > + dw_mipi_dsi_line_timer_config(dsi); > + dw_mipi_dsi_vertical_timing_config(dsi); > + dw_mipi_dsi_dphy_timing_config(dsi); > + dw_mipi_dsi_dphy_interface_config(dsi); > + dw_mipi_dsi_clear_err(dsi); > + if (drm_panel_prepare(dsi->panel)) { > + dev_err(dsi->dev, "failed to prepare panel\n"); Don't forget doing clk_disable_unprepare when run into error path. > + return; > + } > + clk_disable_unprepare(dsi->pclk); > +} > + -- Ｍark Yao