From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753066AbcAFLWb (ORCPT ); Wed, 6 Jan 2016 06:22:31 -0500 Received: from mail-wm0-f46.google.com ([74.125.82.46]:37835 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752785AbcAFLV6 (ORCPT ); Wed, 6 Jan 2016 06:21:58 -0500 Subject: Re: [PATCH v3 0/4] thermal: re-calculate k_po/k_pu when update sustainable power To: Javi Merino , Leo Yan References: <1452070428-2567-1-git-send-email-leo.yan@linaro.org> <20160106100712.GA2790@e104805> Cc: Jonathan Corbet , Zhang Rui , Eduardo Valentin , Punit Agrawal , Daniel Kurtz , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org From: Daniel Thompson Message-ID: <568CF8D2.9040906@linaro.org> Date: Wed, 6 Jan 2016 11:21:54 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20160106100712.GA2790@e104805> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/01/16 10:07, Javi Merino wrote: > On Wed, Jan 06, 2016 at 04:53:44PM +0800, Leo Yan wrote: >> k_po/k_pu are two proportional term constants and essentially they have >> fixed ratio compared with sustainable power. In current implementation, >> k_po and k_pu are absolute value after calculation and cannot represent >> the ratio relationship with sustainable power; as a result, when change >> sustainable power we cannot smoothly change proportional term constant. > > In v2 Daniel said that the use case was made up. Can you elaborate on > why we need this? To be clear, I didn't say Leo's use case was made up. In truth I've never asked Leo what his use case is. It was simply the use case that I used to illustrate a bug in the v1 implementation which was made up (and which you asked for more details of). Daniel.