Re: [PATCH 1/1] regulator: max8973: add support for junction thermal warning

Laxman Dewangan
2016-01-06T14:09:55Z

On Wednesday 06 January 2016 06:07 PM, Mark Brown wrote:
> * PGP Signed by an unknown key
>
>
>> In one of design, interrupt from MAX77620, and alert from both MAX77621
>> shorted and going to Arm GIC controller. On this case, I need to register
>> the interrupt as SHARED interrupt. This property can not be passed via
>> "interrupt" properties from DT.
>> That's why this flag is added to support this.
> If the driver supports shared interrupts it should just register as a
> shared interrupt all the time, there is nothing about shared interrupts
> which requires that the pin actually be shared.
>
>> Now, by default, if I register the interrupt as SHARED in driver then it
>> failed on second design as GPIO does not offer to register as SHARED
>> interrupt.
> What makes you say that this would fail?

The failure was due to the mismatch flags when registering interrupts. I
used flag as ONESHOT, TRIGGER Type and SHARED.

I experimented as make the interrupt flag as SHARED all places (and
ONESHOT always) so that all interrupt flag same for all registration on
both design. This way it works fine. It success on GPIO based flag also.
Now I am passing SHARED | ONESHOT on both driver interrupt registration.

I will drop the interrupt flag option from DT on next patch.

Thanks,
Laxman