From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752152AbcAFP7n (ORCPT ); Wed, 6 Jan 2016 10:59:43 -0500 Received: from mail-bn1on0077.outbound.protection.outlook.com ([157.56.110.77]:38432 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751998AbcAFP7i (ORCPT ); Wed, 6 Jan 2016 10:59:38 -0500 Authentication-Results: spf=pass (sender IP is 63.163.107.173) smtp.mailfrom=sandisk.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=sandisk.com; X-AuditID: ac160a69-f797e6d000000b05-fb-568d39e444b8 Subject: Re: [dm-devel] [PATCH 01/35] block/fs/drivers: remove rw argument from submit_bio To: device-mapper development , , , , , , , , , , , , , , , , , , References: <1452027218-32303-1-git-send-email-mchristi@redhat.com> <1452027218-32303-2-git-send-email-mchristi@redhat.com> CC: Mike Christie From: Bart Van Assche Message-ID: <568D39DE.2060709@sandisk.com> Date: Wed, 6 Jan 2016 16:59:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <1452027218-32303-2-git-send-email-mchristi@redhat.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrKIsWRmVeSWpSXmKPExsWyRoxnke4Ty94wg0kNfBZ7381mtXh4dQWL xbLFTxkt5ne/Z7E4tu0ak8XeW9oWlx6vYLeYOe8Om8WlRe4We/aeZLG4vGsOm8XupmXsFu3z dzFadF/fwWax/sgGRotdb86xWxzY9onZ4uXMx0wWrUvfMlks6rvF6CDi8fTKESaPzUvqPVoe tLF57F7wmcljz7HvjB4fn95i8biw7A2bx+oLWxk93u+7yubxeZNcAFcUl01Kak5mWWqRvl0C V8a+CXuZCx4wVew6vpOxgXEZUxcjJ4eEgInEtcV72SBsMYkL99YD2VwcQgInGCV2NnWwQzjb GSVu7vnHAtPRt/8ZM0RiM6NE88aPYAlhgRiJDbMPM4IkRASesEgc+rQALCEkUCtx9vpKsH3M AuoSd1bcB7PZBIwkvr2fCVbDK6Al8blvKdgdLAIqEnev3WAEsUUFIiR+bFjCCFEjKHFy5hOw ek4BF4nWG4+B6jmAZtpLPNhaBjFeXmL72zlgx0kI3GaTeNr1iB3iBnWJk0vmM01gFJmFZNQs hPZZSNoXMDKvYhTLzcwpzk1PLTA00itOzEvJLM7WS87P3cQIjnyuzB2MKyaZH2IU4GBU4uHN kOsJE2JNLCuuzD3EKMHBrCTCqyHcGybEm5JYWZValB9fVJqTWnyIUZqDRUmc17pFLUxIID2x JDU7NbUgtQgmy8TBKdXAyF+8w6PbqXtZXLzVmev39JhNo4+EX7b3EGjvaei6ciR36/5vXM8F PrWqPJKpbPe9NU0rJUAwJHre9Guyq/Wmrrn3//+TpnTP3NxNWU79a7f8TK/41VC0r8rWwXu5 lPQ2j9h85tkXlK88bHvQ4xixX19eOKel4nXewZ8bVq91XhhyPqNphtYkJZbijERDLeai4kQA 0vnUFvgCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrDLMWRmVeSWpSXmKPExsXCtZEjRfeJZW+YwaLJjBZ7381mtXh4dQWL xbLFTxkt5ne/Z7E4tu0ak8XeW9oWlx6vYLeYOe8Om8WlRe4We/aeZLG4vGsOm8XupmXsFu3z dzFadF/fwWax/sgGRotdb86xWxzY9onZ4uXMx0wWrUvfMlks6rvF6CDi8fTKESaPzUvqPVoe tLF57F7wmcljz7HvjB4fn95i8biw7A2bx+oLWxk93u+7yubxeZNcAFcUl01Kak5mWWqRvl0C V8a+CXuZCx4wVew6vpOxgXEZUxcjJ4eEgIlE3/5nzBC2mMSFe+vZuhi5OIQENjJKrHvYyQaS EBaIkdgw+zAjSEJE4ACLxPa1vawgCSGBWomz11eCTWIWUJd4NHkOO4jNJmAk8e39TBYQm1dA S+Jz31KwQSwCKhJ3r91gBLFFBSIkfmxYwghRIyhxcuYTsHpOAReJ1huP2SBm2krcmbubGcKW l9j+dg7zBEb+WUhaZiEpm4WkbAEj8ypGsdzMnOLc9MwCQyO94sS8lMzibL3k/NxNjOD444za wXh9ovkhRiYOTqkGxsJSvVvl0vOfyL1r7e6o4DnFtujMOtHTqrHvRCPcnxw5daFs5vQZ7B9+ Fix3mCrQsuPrzLgTe7TUIj5ckG/+tvrdhxyLKavLdz2+bJ6zZL5KqtZRlRVvinuOevm76wrJ hwov/3Di/yyOvDVODza+1N8vNX2u5Yng/y3JaW52lnIMlUUqhWHHHyixFGckGmoxFxUnAgAj Xk7pbwIAAA== X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11FD043;1:FaWW+hVfC1QFnbdRzMI8Bq8wl9dlTcSTi/6YDA9ZlUHM3DedzmlN2s3TbRlva88cy/fDjcIVjwKf4Cs2QQM/VGMIUXp3zOggQ5z/Yas6MWUoZ0DsvCdlXjKgETmbVPzrZKufhryuGF4dbzCzgBTvFrNvwWw/wRDiDNLdk+Q+KvXt6JVBLmcUiT72haFLaIKEPWtjpaYsJmolsouaQFBRk9G7LVwAEp1J3LukddC/Wf1ue/57yV109ihmORzsCZ22zx8IvlQFuevuH9Ku+mFvI/f7cRXoau7bYXzZCpNpkhfuE4znjwm70o8gGOWRUnOoTJ4EPahgd4sfR5x/D+OZuG6rA/FKapSzr0JJDtG8WQzlOu71+UDIIScWMo3nWwXw X-Forefront-Antispam-Report: CIP:63.163.107.173;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(189002)(479174004)(377454003)(24454002)(199003)(23746002)(230700001)(5001960100002)(59896002)(19580405001)(11100500001)(80316001)(19580395003)(50466002)(69596002)(33656002)(4326007)(65806001)(47776003)(97736004)(2441003)(5001770100001)(87936001)(106466001)(2950100001)(77096005)(64126003)(1220700001)(189998001)(92566002)(5008740100001)(1096002)(4001350100001)(83506001)(65816999)(81156007)(65956001)(2201001)(586003)(36756003)(50986999)(76176999)(87266999)(86362001)(54356999)(921003)(2101003)(83996005)(1121003);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2PR0201MB0823;H:milsmgep12.sandisk.com;FPR:;SPF:Pass;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY2PR0201MB0823;2:ovDe2S4Vm4hvTSfOeOleoQ0yNYslUFoqmNp0kOcoYP0VjFskcjWLmgFHF3AbqTj+h0i6LgztJHHZO6sdgTAbD9o93SLpJW6reocgHJpYnVRMo6YbTfjsblHn+zROmblpi50c9LlTwQ3gKdYp3n5cBw==;3:YlrPkP/9ytpp8gXaL63MGGThXUmajLtdo76U0CBS6I3cUrXTzYQNTS5kxNp1zPBeKstwKGF8fG/cNMAo5ZddNPWGksOn3JfvoFSnZ2j6uTP4tva1IBd0vFk8smv5VoCvqIcZtbs60l58i18ZWzl4rTfMIheYvo/VuW3whDA+ZKNgp2r2zLFcp76z1K084DLry5vqwVUAaeSHizbuxnBSHjn+v+hVkAkX35b4XkkCHlt/rKOUhI6mhTc0NRPjt8GTZcX6L95Od6F5U0zF7f5BPA==;25:KoejLOwJyzrfxTc58SNxJO+1DSDyonEdDi5usuRLIN9l9g16/pTvgIKyttB0s1grjVbELkcIQySWUJaU0RGEgARFcy0wH3fxFxXvT28vi9D+N4y8g41HGuJqBgIG1ickWLO7EKwqiX2m0yDbO7TywAwEuO37Ismj2jjBvq2XuN6MkhM7vXtyvuDoOtTVMl41IlmX7R+pEinO5/5z/YwQ606Cz42qs5+IW7n2rq6BnCBeCu2e/evFt/v0dyINkU22 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501001);SRVR:BY2PR0201MB0823; X-Microsoft-Exchange-Diagnostics: 1;BY2PR0201MB0823;20:Ii4DoHg3768SVc8sHpCl7DLzfyfbihsqcfmEvVonYabDSBX6Q0CGm24uTpSk6YEe1YOHo/6IV6hlYkiQPEoFf7BEaHlnh/j/l27vnKKQRzPi9NnnI4yc3G6aDkS40Cgua7TeRtgJf5wxDdseJlKdA9MV4r6Ji1APE9juQS2wZzh2N5Xq8JHAnN/mJL23HsF8QdN2LLT0iNK0CrDTuNapNNDSfCXY1cCukPRetxxcjrbYbs/F2lR7xwUlM036Gw7tUf7sX5zADpAa/9KUZEvOJ+nkxMmFVFK4kzJJ+T9MSwGHFpT5XXGHJsgJO3D+TTFYowC1GPPcdKHpYWw6M5FcAkHkgC6xLyK57J0FtZSKWsscODsIKXHX3MF8Dso8JckFMVgon0iE/U/Uh6XnHPIG32rDbf5fpW8G0uLjsseltphkE/OqCPehIC0OM7FooBrdzbXc55PxAbMiajilPmjSGo+wzUDBeRA6bcV2gehgCBj6qlleMo2fm7Id+UvNd2L2;4:v/4N7KbeRJOuDEOHlwEqERjnsh/EmToGKJi9Kxksc90CJwxGaoyRU9bGSd4Gp/sNtZkKsrm19xolK3jpj7OOMbeoMzFuUTAOpNDTzQwPTB3LASQSgfzr7QcJTCK2Ie5xiG+h+cbf4K4BGMnpIoXL4NTwPvKzK6mMUKLz/VpY4/Jymo3N4TO4HZUM3oUwFJy0dXCN8LQtgiaz6IFpDGykpUVKYUAJrd80d8W1vWMk/JAgXBBwNmTpENJEwEjMPFb/Qi1HRsVMe5yhblUftJe88AA0S9WmJLvaZbE1sgB5WJN/lAEYgcZbxpoM3WuOtOOITR6qWNjCm7eVPwNR22OqZuFU4A7Rw3TfnZ9e8Lt6udvVI+nUkFmwECsepWOyNdvefvyA0dp7M7aIfQ+9ZIr7X/H6auqNtuLQJui/p/9QQKk= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(42932892334569); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(520078)(3002001)(10201501046);SRVR:BY2PR0201MB0823;BCL:0;PCL:0;RULEID:;SRVR:BY2PR0201MB0823; X-Forefront-PRVS: 0813C68E65 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BY2PR0201MB0823;23:E9wmtWzDUVTIOQGbCQxYEf6QjtVJoZCBFdo?= =?Windows-1252?Q?p4xo/12d5+6oCQbSlGXDj12qO/qY3/e/2duKj3tY69RTDOEHUQNObQQy?= =?Windows-1252?Q?Mcssm206Zgz0X0Eo/G/NtYlyI1/ZfxYh+p3Jm1j3mCfyhhEVFCGjCR3c?= =?Windows-1252?Q?JbQTXfU5WfVyWQfMl3P7U+ovz15L5wKkgkjpeNedmDFlufD8xKhNqBNG?= =?Windows-1252?Q?9VUNZ4eoKMRFYPqCAifRHpsCtihMJddfC6Um8UCsXb1xIu5voBwo8zdv?= =?Windows-1252?Q?mAGHLftlyQxpbtnOWmq8DBpET9Ih74B/JGk1XYTJRUQuyi0w+qQ7GeAk?= =?Windows-1252?Q?eMzfmCWLYgzs3dMtjpwYw7OIQ2l3fCuZrIR7IP81o9t7f7OBD0ujud05?= =?Windows-1252?Q?TGTwwYFQtu092Nz9KOxOQj2jisziaGDOx+FtroOgUnNvGrLLjELaMUDr?= =?Windows-1252?Q?Pnp5A/Gr33tnxwry82pOcE6b6rxARKdtWZ/ltkVs5xwOFAiahbEzzmaA?= =?Windows-1252?Q?vvDvKfKlExnS3EPjYJ5fNR10ypGiFA09lbfz4M+jwjcwgl64Np970bUS?= =?Windows-1252?Q?d2XypGcrxDmX73qldyx1Tpj6tGFbJbJAG8IdHWuvnFXwtyNwnx8EfIbg?= =?Windows-1252?Q?L8L/vWE8I1LQe9IcqmJcduygHUu7YZxYeadrMbwg/OJs4aR3Lh56SWXH?= =?Windows-1252?Q?hWp3IjKtjaHfZ23QrWfHZwJM52Q89ZM5T4Fprj97N6X1TLffc5LXNw4q?= =?Windows-1252?Q?EyllQcp7FAjNqKsSlajbChXqwAbHktlV0AqWWp34kzV86W19FUtbqBii?= =?Windows-1252?Q?Tv6w26rr9NfsUFyaolKXCYjt/vOWpycly2Ki1gJG4b20k3Dei7iTHwzg?= =?Windows-1252?Q?d+8+onm6JKEp9AvZziKEazSYZPMQ4FCdi0j3m1pTj0OakeNrNbQSw6TJ?= =?Windows-1252?Q?JTv0jw9YXynASyTOhli6c49GKqPcAC7eEbWlJJJoNzMuCijgCS9qhX9k?= =?Windows-1252?Q?pfYZq56r1uao8+3di/aaumD9RQRZ3dA6H45Bwczkufyh6d4p6uCONTty?= =?Windows-1252?Q?rppzAFKXuQxsyrMGQcECVdiGBS+JwxiKRwjEqEcpaJiamUMgsLUbU09I?= =?Windows-1252?Q?f7HLk/06/j8fU2Oen9gvPTZUDbyowCPsVd2v/KypmEmYA9vQk9cT42j/?= =?Windows-1252?Q?9AZzH3ebTUnmTwnTk21CN2COfSUr6S3YHla7sfGNQ/D6+Gc6T9ogjbHc?= =?Windows-1252?Q?cCQ67HNHDxuZMFt7OmZfkas6vFsrnWf5cXbHw7kEQ5T7jOhIIS9UM9RJ?= =?Windows-1252?Q?2Z4u9XWye96QwmX/Jqkot3R+2chAP7gHCa9sJKcHPNSkc8nnro57P9Oa?= =?Windows-1252?Q?05Hm31TWS2tpf17iwnHZvvGCZVBpwv+TZm7ilW4bH6X71lrA0YHCVw3Q?= =?Windows-1252?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;BY2PR0201MB0823;5:WvKOzVMminnar3edRr0dibaNRUxnZS/Rb5sj17pvipSElqwisb700apoQjNZlsJ6mlGZEYvpwEYYECdhlckZFtBUgIXFutQ9gk/wWlOk0NTeADvM9lK/gw6ecWQa8MgWqSEaDjf4kzQjNpt7KFm8QQ==;24:HfgT6VreKpKxsRdtPTtTCTssTJ4R0TdYpLLAAWUJUzVRvBQxARkVK8X68n+OHiVHODrDcVSWmAaC9n2Ang4Mp+LCLWqF9RMPSxEYe7b51hs=;20:Ti6O4GGfTxZYKaiRGTE3i7VQegcPG/kPInBvtp3nFzARblcO+wm5IhKPCj8Gq+uQofOR63cni+TQRDftmhr9X5LR3gRcgfVE2J1S3/zslu2IBIh/jZFYVl5mYKSuhgbRwUnBRfgWbGtDoXwwmh/qFjNpV2Z+hzX/uDCnD1dQnfz+xyn6ILUKlNl0glfbVAKcv5UmX4WhinNH+69rlI5PnB4N/c8MEh9IJmGcC77zC9qZob8/+EhN2QqfpTh+ekJh SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jan 2016 15:59:32.4232 (UTC) X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d;Ip=[63.163.107.173];Helo=[milsmgep12.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0201MB0823 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/05/2016 09:53 PM, mchristi@redhat.com wrote: > From: Mike Christie > > This has callers of submit_bio/submit_bio_wait set the bio->bi_rw > instead of passing it in. This makes that use the same as > generic_make_request and how we set the other bio fields. Reviewed-by: Bart Van Assche