From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752306AbcAFRhq (ORCPT ); Wed, 6 Jan 2016 12:37:46 -0500 Received: from www.sr71.net ([198.145.64.142]:36133 "EHLO blackbird.sr71.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751717AbcAFRhm (ORCPT ); Wed, 6 Jan 2016 12:37:42 -0500 Subject: Re: [PATCH 3/5] x86: simplify early command line parsing To: Borislav Petkov References: <20151222225237.08CDE5F1@viggo.jf.intel.com> <20151222225241.15365E43@viggo.jf.intel.com> <20160106171044.GB20321@pd.tnic> Cc: x86@kernel.org, linux-kernel@vger.kernel.org, dave.hansen@linux.intel.com, hpa@zytor.com, fenghua.yu@intel.com, yu-cheng.yu@intel.com From: Dave Hansen Message-ID: <568D50E4.30102@sr71.net> Date: Wed, 6 Jan 2016 09:37:40 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20160106171044.GB20321@pd.tnic> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/06/2016 09:10 AM, Borislav Petkov wrote: >> > - if (!strlen(cmdline)) >> > - return 0; >> > - > Patch 1 adds the strlen(), this patch removes it. Please merge both patches. As I mentioned, it doesn't strictly add it. Plus, if I go add this back to that patch, I'll end up having to paste most of the changelog in to that one. I think it's much more clear to have this hunk live on its own.