From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752209AbcAFRqT (ORCPT ); Wed, 6 Jan 2016 12:46:19 -0500 Received: from www.sr71.net ([198.145.64.142]:36235 "EHLO blackbird.sr71.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751863AbcAFRqR (ORCPT ); Wed, 6 Jan 2016 12:46:17 -0500 Subject: Re: [PATCH 22/32] x86, pkeys: dump PTE pkey in /proc/pid/smaps To: Vlastimil Babka , linux-kernel@vger.kernel.org References: <20151214190542.39C4886D@viggo.jf.intel.com> <20151214190619.BA65327A@viggo.jf.intel.com> <568BC5FA.2080800@suse.cz> Cc: linux-mm@kvack.org, x86@kernel.org, dave.hansen@linux.intel.com From: Dave Hansen Message-ID: <568D52E7.1060602@sr71.net> Date: Wed, 6 Jan 2016 09:46:15 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <568BC5FA.2080800@suse.cz> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/05/2016 05:32 AM, Vlastimil Babka wrote: > On 12/14/2015 08:06 PM, Dave Hansen wrote: >> From: Dave Hansen > > $SUBJ is a bit confusing in that it's dumping stuff from VMA, not PTE's? Yeah, absolutely. That's a relic from when I thought I'd need to be walking the page tables to figure this out. I'll update it. > It could be also useful to extend dump_vma() appropriately. Currently > there are no string translations for the new "flags" (but one can figure > it out from the raw value). But maybe we should print pkey separately in > dump_vma() as you do here. I have a series in flight [1] that touches > dump_vma() and the flags printing in general, so to avoid conflicts, > handling pkeys there could wait. But mentioning it now for less chance > of being forgotten... > > [1] https://lkml.org/lkml/2015/12/18/178 - a previous version is in > mmotm and this should replace it after 4.5-rc1 Ahhh, very nice. I'll go back and add support for it once your patch lands.