From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750818AbcAGFFa (ORCPT ); Thu, 7 Jan 2016 00:05:30 -0500 Received: from mail-bn1bon0080.outbound.protection.outlook.com ([157.56.111.80]:6016 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750707AbcAGFF1 (ORCPT ); Thu, 7 Jan 2016 00:05:27 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Suravee.Suthikulpanit@amd.com; Subject: Re: [PATCH v4] i2c: designware: Do not require clock when SSCN and FFCN are provided To: Loc Ho , Wolfram Sang References: <1451920655-10798-1-git-send-email-Suravee.Suthikulpanit@amd.com> <20160104161525.GC1599@katana> CC: Mika Westerberg , , , Ken Xue , , , Linux Kernel Mailing List From: Suravee Suthikulpanit Message-ID: <568DF20A.3060504@amd.com> Date: Wed, 6 Jan 2016 23:05:14 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: BY2PR1001CA0035.namprd10.prod.outlook.com (25.164.163.173) To SN1PR12MB0447.namprd12.prod.outlook.com (25.162.105.140) X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0447;2:aZwRGzTI+01H+ghlD2UqIOCPAa39Lzb8NUFJYk6CVcyFxc1n+vloASusxHFepsghNNov7E6BvEuzI0f/bCOWueXDXjJbxUSr9b8AwvLkt0LN+HwunSEFAkUJBGSEhzZnqMQ+bUnvsAYa6roditb9jw==;3:o3rROHQ5fz66Devu/FBfGXoTXrWnKC0/1YscFu86Ghox3tyRU9bpQP3s8Go9bsMTIL7xlaHls5MIYGFR8Ypb21glkA3Q1mHYpvjNJG0cQjGO9FBewCYKjIyt5bak0tS7;25:9UWAdlKU3hNrSHR9FPKKroVTKCae1VeRsdDf0ndjnPlqTWEvLXMROguVZCZEDXZiIgc2CcrxOeDRIh2acPugDELPhv5j2sQYlVtuL4Mbv8KOFJtdOSnfSsVUx3QiL5+ISPMFDExTFfvgpmQSpQXTYkrjyOGLFVXkSQ3J/JL3bbBiIQfj4UY1WUy/YwNV7V/+2BoLZ9T4lwU6hsHs8PjrsA== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN1PR12MB0447; X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0447;20:6Trg19uKt2mRpSX14/jj32TtHjMKlPvn6FlNoD7Td+0nbWSoKpjVOvCEp30Upm4ouusHltjvAKETLh3oyuJDx4qN9UFQ4NWfnOixBuz4ErNpVfjw/yPL1WaOr3B+/VrOTld90WFQKMxYA+LsnW1O+ZzDYmwo5/P+sMXoxELSJR3ToeMUfnIzrZjsPNoMpcn5UKp8vp5qSnXF4O8Oo3uObQCthnB/p0obQbT/IAdXnuK2gLUHRPYjnczwW5erjhKRxYPT3TzIoUOmbxQd54oGJS/OF0MMelavjmXB4YIFeiX04wG0NMjIWil+o38mz2Msop3XK7W0+7e6CJfuQtfWJaUvHmsKb9eTlqHUDv5UhuGNOmr95OtiBpt0oFKthHjHLajZ/EzKTI3X87mvzd3A49lAnGW7LoYopS/sZ7PMmjvmfCH4YMqhM+1UhpEqNUmvg/wGERhR3vtlCnlO1VM8T1eZrI30wRulPa4wqX5cBPjVmP5oTFz1kJ2ByP0kK2Np;4:DX8TPHBLEbPwCwvAG2Pfi4fqznQ+HLYrcARzvlCVmFJVgMybs/HjliJxQ3dQje5EREF+D5U+cG0dQMQrQl7NAfhicKlMLCDuvRWM2lSgRSf4pn9CVB0McuMOb4hxHzI1Jll7gV9qXCGacaKpliQE46tGYlfJglyu4JBc+M3AXtdpTasAvLDxe4h+04F4krGDNmTrAyfxlrXeOX3yFkeWG3G3vMSaQm3yg6ieiCiwqE/IPOpdyh4qFRWk7pRxlspmmL27WH8F/mc9gZMTWNgKzjCC6eZDuX0WZRyX4bcPNGl5H5boZE7GXlq4grTYBFsbGPUA9vX5/lt89ScUwtXOEIszLcVMW9KJXvGwrz8hmjLJME6yB3aBYYd5LrT/nlxXUgd0Z2iqFZM2zfHAZUQEGJ36QFBfSNth/HGCbe+Resw= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(8121501046)(5005006)(10201501046)(3002001);SRVR:SN1PR12MB0447;BCL:0;PCL:0;RULEID:;SRVR:SN1PR12MB0447; X-Forefront-PRVS: 0814A2C7A3 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(6049001)(479174004)(199003)(24454002)(377454003)(53754006)(189002)(64126003)(87976001)(50986999)(87266999)(5008740100001)(5004730100002)(92566002)(97736004)(2950100001)(65816999)(59896002)(76176999)(19580405001)(15975445007)(40100003)(86362001)(4001350100001)(66066001)(50466002)(81156007)(189998001)(5001770100001)(54356999)(230700001)(77096005)(4326007)(47776003)(83506001)(1096002)(6116002)(106356001)(42186005)(101416001)(586003)(23676002)(105586002)(65806001)(3846002)(65956001)(19580395003)(80316001)(33656002)(5001960100002)(122386002)(36756003)(2906002);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR12MB0447;H:[10.224.9.134];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjFQUjEyTUIwNDQ3OzIzOk1sSFZ3cTl2MFJvQVp5bjhjVnM2d1owK2RF?= =?utf-8?B?WEJ2cGprTitTeStjTG9KVEFldGZncWx4aWFDSnFTVDg5U3lQRnJweWlhQ25z?= =?utf-8?B?NVZRM3VkYk13VVMxRVc5N2d5NDRLajN0VCs3cHd0N28xMEM4cnFwSUxiTmJL?= =?utf-8?B?TUJDM0Vic0I5TUdDblFia2RKeG44RmtuUitXYjJzbGhPRWhYb0tVcGtCcEh4?= =?utf-8?B?QlRBQ3loaWFlek1HenRSaHkyLzhnZXZyVlJIb0lqYjFkRkk2eVo4VW40V2hx?= =?utf-8?B?dVhTWENSUmdNajIvbjFkaHRJekEvWmVZa0VCSTl1bi9RVjVONmM5RUd4bHpS?= =?utf-8?B?bkswSlF3djdvVEE1amI0bkI0ZGV6QURZTlIzZWc5eldPcG1NUElVWmNCaFFT?= =?utf-8?B?TEIyUm13K1prZGxYVjRWNzBZRkZ6TTByQy9RTk4wdEdISkMvTGpBaVp2b0Ju?= =?utf-8?B?Zm13MngraUh5bE04MW5TL1VnME4zZ2VONmhLNE5BVkYyMUtOUXhjVlUzVUp6?= =?utf-8?B?cU5TUXlEY0JRRjFsL3crYzU5Q0JMNmV4bWJCaVNuZXVUbDlYcGh2NXE0cSt6?= =?utf-8?B?Mk1ORmxIVC9UY0F2Ry9qdnQ5RFBOelYxMTFrNXY2bER0aXBpMjhoSHRJVW5G?= =?utf-8?B?alAxSGVTWC91bThobUsyVmNObUlaTmFDb2lJaTVRRkN5Z2YxL0JaRnRpSFlS?= =?utf-8?B?Y3gzSnA3cmZXTGJCWEdOdng0Q1VaSldTbFRPMHBvR1N5eW5GVm05QVFmOTd1?= =?utf-8?B?dTBPMkR3N2x3VVJsb0tBY2JXVHpYbGlKTjJ0QkxDMC9WT1ovc3A4QjlpTFZo?= =?utf-8?B?UER4OHovOUcvQTBQTlJwcVF4L2Nkc056T0RhRGNHc3RFelRkQ3BMdTE1Ylo4?= =?utf-8?B?Qkh3eVFuZ0h4enpQSmd0SjY4MWhGSUhhM2Urb25zMzNOb0xaWGJ2VHRXMS85?= =?utf-8?B?RlVFZlBKY0JPNWdrKzAvcHRGVUlkL0JsTlM3ZFNaNDZvNUVlYzgrWExnTEJP?= =?utf-8?B?TCtpLy9VaVBWakl4SEZmTmRLemdSeEU5SzA3ZklrVjJBdWE4YzhFVmlvdk1x?= =?utf-8?B?eGZvSzF2cm9STE01MHVvOEtJT294UzhNdWJ5VzVDeFlRWkJYWEZkaHRmdG1V?= =?utf-8?B?T01zNTZNQ0NWU09iSFZWYVBDY1VLcFVCeWtRNTZLQmlNQlAxS0x0b2FsOHlG?= =?utf-8?B?U0dBWHluL0JIZytvNXlEMVBSV1M1RVhsT1Z6V0dCUTdSZzI1aWVDT3lmYXBv?= =?utf-8?B?aFlrRnAyRTE2WEFRT1dJYWR2LzU4Z1E5eWE3bEU2WHVrY1Nsbjh0NEluTnNn?= =?utf-8?B?Zmtma2I1NkVtWmxxTGU1WURnc1dHQkswMGtOV004ck1UVEZDMWNHbDArb0tV?= =?utf-8?B?RnpoekRWWkZUaGdVK3R0ZCttTU9aM29HMjRTZy91RGRRSFNRcFI2RGVkSHBC?= =?utf-8?B?SXVnNTZ3SDJiN3ZOS0x5a2dOZ2MrbFM4NW9FYlR4WVhsMXdIOVl1RDg2WGhZ?= =?utf-8?B?LzRsbllXczNtWDdWa3ZEbkNFUGtKZ0NseUwvaE42OE5mUU9lTVRkbGtUSnZl?= =?utf-8?B?aU04TUlka09GRWYzN09BYTlYQXE1M3U5S1lML2NqaWZ4QzdsN2k1MFloVEtx?= =?utf-8?B?YWRJNk95WDlJT3cxbWt1V2dLSHIyQy84aklidUVXY2FISmlFR2NrdS91Slk3?= =?utf-8?B?R3JuVGMxV2xETkc3NkFvTkZWSnc1R2lnZjd3NjVLYXljQ3lKbWhtRnB6OFZL?= =?utf-8?B?dDBob21naEVrSnFSS0ZPQlVwSWpZUktZK0RvUUlJTXQ4cUZZZU9HdGVUa21U?= =?utf-8?B?U3ZHR2Z2aCtoeGVoSEdPc01XSEQ4ZW4zUjV6Nm56ejhDYTd5OGVlaVFzWmZn?= =?utf-8?Q?QZn3x7oW2+w=3D?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0447;5:YSsiWvjZdGYo9q/T18HnVXxmp3A6iA72m2iglbP3KMVEyyPDZHOFhtHWa3e2giDKiWYPMPNK5JJkkBN8Z1D49xTsuN4zHkHFmtNdHgCynaxNgly6mQirmJ1zxqjelbuIRrN0b7IIeh31eP/FieP2vw==;24:HJx57yYJJau+FhallW68cdZgIHscTShHPIWNmydIQhAPgiGkABLAFawuSkSCySW39Oyw3Ii1VhTeMkMVCM5/Z0KtATErBTaDXpfDocjfpnY=;20:fN9rdvUHLZlOa9iUfM7SfdXrmZh1qxI+msvaqWp8sGKtQhFh93Y3ISHooCANDHWwMbkSKxZOVLGwuWWYnUv0Kf9ijpfoGHg5nLAZe5DzTyyTH6Zea8eniYveLhRVXFkKJrvEcPyZSxZPE4OaP7bOOxC3dN/qxPBvO+zjjN1zUWXDamtsDBFhFC7ODPCbrjDdMoxDm+H6B9nMF+I/2+fmr1ndnOlSjQH75HCThjCNGaiZZTDNsTWTnL8ECGe9FIaU X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jan 2016 05:05:22.4201 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB0447 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 01/06/2016 06:31 PM, Loc Ho wrote: > Hi All, > >>> The current driver uses input clock source frequency to calculate >>> values for [SS|FS]_[HC|LC] registers. However, when booting ACPI, we do not >>> currently have a good way to provide the frequency information. >>> Instead, we can leverage the SSCN and FFCN ACPI methods, which can be used >>> to directly provide these values. So, the clock information should >>> no longer be required during probing. >>> >>> However, since clk can be invalid, additional checks must be done where >>> we are making use of it. >>> >>> Signed-off-by: Mika Westerberg >>> Signed-off-by: Suravee Suthikulpanit >>> Tested-by: Loc Ho >>> --- >>> >>> Note: This has been tested on AMD Seattle RevB for both DT and ACPI. >>> >>> Changes from V3 (https://lkml.org/lkml/2015/12/22/596): >>> * Add i2c_dw_plat_prepare_clk() per Andy's suggestion >>> * Add tested-by Loc Ho. >> >> The changes from V3 are big enough that I'd appreciate a new Tested-by >> tag. > > I had tested this via this mixes of test cases: > > a. NO APD driver + this patch ==> HCNT/LCNT as expected > b. with APD driver + this patch ==> HCNT/LCNT as expected > c. with APD driver + this patch + double the frequency APD driver ==> > HCNT/LCNT as expected > d. with APD driver + this patch + double the frequency APD driver + > comment out the ACPI parameter retrieve ==> HCNT/LCNT changed as > expected > > Therefore, you can add my - Tested-by: Loc Ho > > -Loc > Thanks Loc, Suravee