From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752465AbcAGHsG (ORCPT ); Thu, 7 Jan 2016 02:48:06 -0500 Received: from arroyo.ext.ti.com ([192.94.94.40]:39245 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750809AbcAGHsC (ORCPT ); Thu, 7 Jan 2016 02:48:02 -0500 Subject: Re: [PATCH 00/19] irqchip: atmel-aic: make unified AIC driver To: Boris Brezillon References: <1451881723-2478-1-git-send-email-milo.kim@ti.com> <20160104100238.2b40f736@bbrezillon> <568CC6C7.3040809@ti.com> <20160106100755.2b6a4983@bbrezillon> CC: , , , , , , From: Milo Kim Message-ID: <568E1869.3050608@ti.com> Date: Thu, 7 Jan 2016 16:48:57 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20160106100755.2b6a4983@bbrezillon> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Boris, >> If AIC and AIC5 must be separate, then I'll try to rework >> irq-atmel-common part. > > What would you like to rework? Could you describe in more details > what's bothering you in this code? I was about to modify irq-atmel-aic-common as below. * AIC5 handles for-loop twice during initialization. 1) after IRQ generic chip is allocated successfully. 2) map AIC5 IRQ chip operation after aic_common_of_init() returns. To reduce for-loop count, move each IRQ chip initialization code into common part. * AIC and AIC5 have same interrupt handling procedure, so each IRQ handler can be moved to common part. BTW, I've sent another patch-set about fixing few things. Could you check them? Best regards, Milo