From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752827AbcAGRjE (ORCPT ); Thu, 7 Jan 2016 12:39:04 -0500 Received: from mail-pa0-f44.google.com ([209.85.220.44]:33840 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752672AbcAGRjB (ORCPT ); Thu, 7 Jan 2016 12:39:01 -0500 Subject: Re: [PATCH] tty: plug a use-after-free in TIOCGETD ioctl To: Greg Kroah-Hartman References: <1452178680-30284-1-git-send-email-mguzik@redhat.com> <20160107161418.GA28297@kroah.com> <568E946C.60703@hurleysoftware.com> <20160107170853.GA28780@kroah.com> Cc: Mateusz Guzik , Jiri Slaby , stable@vger.kernel.org, linux-kernel@vger.kernel.org, security@kernel.org, milos@redhat.com, linux-serial@vger.kernel.org From: Peter Hurley Message-ID: <568EA2B0.3010407@hurleysoftware.com> Date: Thu, 7 Jan 2016 09:38:56 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20160107170853.GA28780@kroah.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/07/2016 09:08 AM, Greg Kroah-Hartman wrote: > On Thu, Jan 07, 2016 at 08:38:04AM -0800, Peter Hurley wrote: >> On 01/07/2016 08:14 AM, Greg Kroah-Hartman wrote: >>> Adding Peter and linux-serial to the list here, as Peter has been doing >>> a ton of work in this area... >>> >>> Peter, does this seem sane with the tty locking rules? >>> >>> thanks, >>> >>> greg k-h >> >> No. >> >> Fix for this is right here: >> http://lkml.iu.edu/hypermail/linux/kernel/1511.3/03045.html > > Ah, I thought I had seen this before, thanks for the reminder :) > > But, I didn't apply that series for some reason, was it waiting on > something before that? Or did I just miss it with the holliday break? That series is good to go, and in fact fixes a rash of crash reports which occur on kernels since 3.10, but just started showing up now (triggered by some interaction between consoles over terminal servers and systemd). I didn't bother you about it because it seemed like you were busy. Do you need me to resend this series (and the other 6 series' plus misc fixes)? Regards, Peter Hurley PS - I meant to get to plumbers' last summer but overdue work kept me from going. This would have been easier with a tree to pull from.