From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753619AbcAHBXH (ORCPT ); Thu, 7 Jan 2016 20:23:07 -0500 Received: from mail-pa0-f44.google.com ([209.85.220.44]:33004 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752189AbcAHBXF (ORCPT ); Thu, 7 Jan 2016 20:23:05 -0500 Subject: Re: [RFC][PATCH 0/7] Sanitization of slabs based on grsecurity/PaX To: Christoph Lameter References: <1450755641-7856-1-git-send-email-laura@labbott.name> <5679ACE9.70701@labbott.name> <568C8741.4040709@labbott.name> Cc: Kees Cook , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Linux-MM , LKML , "kernel-hardening@lists.openwall.com" From: Laura Abbott Message-ID: <568F0F75.4090101@labbott.name> Date: Thu, 7 Jan 2016 17:23:01 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/7/16 8:26 AM, Christoph Lameter wrote: > On Tue, 5 Jan 2016, Laura Abbott wrote: > >> It's not the poisoning per se that's incompatible, it's how the poisoning is >> set up. At least for slub, the current poisoning is part of SLUB_DEBUG which >> enables other consistency checks on the allocator. Trying to pull out just >> the poisoning for use when SLUB_DEBUG isn't on would result in roughly what >> would be here anyway. I looked at trying to reuse some of the existing >> poisoning >> and came to the conclusion it was less intrusive to the allocator to keep it >> separate. > > SLUB_DEBUG does *not* enable any debugging features. It builds the logic > for debugging into the kernel but does not activate it. CONFIG_SLUB_DEBUG > is set for production kernels. The poisoning is build in by default into > any recent linux kernel out there. You can enable poisoning selectively > (and no other debug feature) by specifying slub_debug=P on the Linux > kernel command line right now. > > There is a SLAB_POISON flag for each kmem_cache that can be set to > *only* enable poisoning and nothing else from code. > > The slub_debug=P not only poisons it enables other consistency checks on the slab as well, assuming my understanding of what check_object does is correct. My hope was to have the poison part only and none of the consistency checks in an attempt to mitigate performance issues. I misunderstood when the checks actually run and how SLUB_DEBUG was used. Another option would be to have a flag like SLAB_NO_SANITY_CHECK. sanitization enablement would just be that and SLAB_POISON in the debug options. The disadvantage to this approach would be losing the sanitization for ->ctor caches (the grsecurity version works around this by re-initializing with ->ctor, I haven't heard any feedback if this actually acceptable) and not having some of the fast paths enabled (assuming I'm understanding the code path correctly.) which would also be a performance penalty Thanks, Laura