From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754225AbcAHIQX (ORCPT ); Fri, 8 Jan 2016 03:16:23 -0500 Received: from mail-pa0-f47.google.com ([209.85.220.47]:35246 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751279AbcAHIQV (ORCPT ); Fri, 8 Jan 2016 03:16:21 -0500 Subject: Re: [PATCH RESEND] perf config: Rename 'colors.code' to 'colors.jump_arrows' To: Namhyung Kim References: <1452149290-30634-1-git-send-email-treeze.taeung@gmail.com> <20160107080205.GI8053@sejong> Cc: Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org, Ingo Molnar , Jiri Olsa From: taeung Message-ID: <568F7052.3050908@gmail.com> Date: Fri, 8 Jan 2016 17:16:18 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20160107080205.GI8053@sejong> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Namhyung Thanks for your review. I rechecked this patch and then I found missed part that is contained on Documentation/perf-config.txt. So, I'll resend modified patch. Thanks, Taeung On 01/07/2016 05:02 PM, Namhyung Kim wrote: > On Thu, Jan 07, 2016 at 03:48:10PM +0900, Taeung Song wrote: >> Suggest 'jump_arrows' config name instead of 'code' >> on 'colors' section. 'colors.code' config is only for >> jump arrows on assembly code listings i.e. >> >> │ ┌──jmp 1333 >> │ │ xchg %ax,%ax >> │ │ mov %r15,%r10 >> │ └─→cmp %r15,%r14 >> >> But this config name seems unfit. >> Maybe 'jump_arrows' would be better than 'code'. >> >> Cc: Jiri Olsa >> Signed-off-by: Taeung Song > > Acked-by: Namhyung Kim > > Thanks, > Namhyung > > >> --- >> tools/perf/Documentation/perfconfig.example | 2 +- >> tools/perf/ui/browser.c | 4 ++-- >> tools/perf/ui/browser.h | 2 +- >> tools/perf/ui/browsers/annotate.c | 2 +- >> 4 files changed, 5 insertions(+), 5 deletions(-) >> >> diff --git a/tools/perf/Documentation/perfconfig.example b/tools/perf/Documentation/perfconfig.example >> index 767ea24..1d8d5bc 100644 >> --- a/tools/perf/Documentation/perfconfig.example >> +++ b/tools/perf/Documentation/perfconfig.example >> @@ -5,7 +5,7 @@ >> medium = green, lightgray >> normal = black, lightgray >> selected = lightgray, magenta >> - code = blue, lightgray >> + jump_arrows = blue, lightgray >> addr = magenta, lightgray >> >> [tui] >> diff --git a/tools/perf/ui/browser.c b/tools/perf/ui/browser.c >> index d372021..af68a9d 100644 >> --- a/tools/perf/ui/browser.c >> +++ b/tools/perf/ui/browser.c >> @@ -531,8 +531,8 @@ static struct ui_browser_colorset { >> .bg = "yellow", >> }, >> { >> - .colorset = HE_COLORSET_CODE, >> - .name = "code", >> + .colorset = HE_COLORSET_JUMP_ARROWS, >> + .name = "jump_arrows", >> .fg = "blue", >> .bg = "default", >> }, >> diff --git a/tools/perf/ui/browser.h b/tools/perf/ui/browser.h >> index 01781de..be3b70e 100644 >> --- a/tools/perf/ui/browser.h >> +++ b/tools/perf/ui/browser.h >> @@ -7,7 +7,7 @@ >> #define HE_COLORSET_MEDIUM 51 >> #define HE_COLORSET_NORMAL 52 >> #define HE_COLORSET_SELECTED 53 >> -#define HE_COLORSET_CODE 54 >> +#define HE_COLORSET_JUMP_ARROWS 54 >> #define HE_COLORSET_ADDR 55 >> #define HE_COLORSET_ROOT 56 >> >> diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c >> index d4d7cc2..d2d2599 100644 >> --- a/tools/perf/ui/browsers/annotate.c >> +++ b/tools/perf/ui/browsers/annotate.c >> @@ -284,7 +284,7 @@ static void annotate_browser__draw_current_jump(struct ui_browser *browser) >> to = (u64)btarget->idx; >> } >> >> - ui_browser__set_color(browser, HE_COLORSET_CODE); >> + ui_browser__set_color(browser, HE_COLORSET_JUMP_ARROWS); >> __ui_browser__line_arrow(browser, pcnt_width + 2 + ab->addr_width, >> from, to); >> } >> -- >> 2.5.0 >>