From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755353AbcAHPfY (ORCPT ); Fri, 8 Jan 2016 10:35:24 -0500 Received: from lists.s-osg.org ([54.187.51.154]:49565 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751025AbcAHPfW (ORCPT ); Fri, 8 Jan 2016 10:35:22 -0500 Subject: Re: [PATCH 2/2] ARM: exynos_defconfig: Enable s5p-secss driver To: Krzysztof Kozlowski , Kukjin Kim , Anand Moon , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <1452132905-8587-1-git-send-email-k.kozlowski@samsung.com> <1452132905-8587-2-git-send-email-k.kozlowski@samsung.com> Cc: tjakobi@math.uni-bielefeld.de From: Javier Martinez Canillas Message-ID: <568FD733.8030601@osg.samsung.com> Date: Fri, 8 Jan 2016 12:35:15 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1452132905-8587-2-git-send-email-k.kozlowski@samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Krzysztof, On 01/06/2016 11:15 PM, Krzysztof Kozlowski wrote: > The Exynos SoC provides a Security SubSystem block for accelerating some > cryptographic operations. Enable the driver for it - s5p-secss to > utilize the hardware acceleration. > > Currently the s5p-secss driver supports AES in CBC and ECB modes. > However on Odroid XU4 (Exynos5422) and Trats2 (Exynos4412) boards this > change introduces one booting error: > > alg: skcipher: encryption failed on chunk test 1 for ecb-aes-s5p: ret=22 > > The cbc-aes-s5p properly registers itself and passes self-tests. > > Signed-off-by: Krzysztof Kozlowski > --- > arch/arm/configs/exynos_defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig > index 0aee1e035be9..c47c7e069873 100644 > --- a/arch/arm/configs/exynos_defconfig > +++ b/arch/arm/configs/exynos_defconfig > @@ -240,6 +240,7 @@ CONFIG_DEBUG_RT_MUTEXES=y > CONFIG_DEBUG_SPINLOCK=y > CONFIG_DEBUG_MUTEXES=y > CONFIG_DEBUG_USER=y > +CONFIG_CRYPTO_DEV_S5P=y I noticed that this is not enabled in multi_v7_defconfig. Are you planing to do it as well? > CONFIG_ARM_CRYPTO=y > CONFIG_CRYPTO_SHA1_ARM_NEON=m > CONFIG_CRYPTO_SHA256_ARM=m > Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America