From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756107AbcAHUFY (ORCPT ); Fri, 8 Jan 2016 15:05:24 -0500 Received: from mail-lb0-f179.google.com ([209.85.217.179]:33625 "EHLO mail-lb0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751700AbcAHUFW (ORCPT ); Fri, 8 Jan 2016 15:05:22 -0500 Subject: Re: [PATCH v4.4-rc8 5/7] isdn: eicon: divasfunc: Silence frame size warning To: tim.gardner@canonical.com, Armin Schindler , Karsten Keil , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <1452256375-24223-1-git-send-email-tim.gardner@canonical.com> <1452256375-24223-6-git-send-email-tim.gardner@canonical.com> From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <5690167F.6030405@cogentembedded.com> Date: Fri, 8 Jan 2016 23:05:19 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1452256375-24223-6-git-send-email-tim.gardner@canonical.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/08/2016 03:32 PM, tim.gardner@canonical.com wrote: > From: Tim Gardner > > drivers/isdn/hardware/eicon/divasfunc.c: In function 'connect_didd': > drivers/isdn/hardware/eicon/divasfunc.c:192:1: warning: the frame size of 1152 bytes is larger than 1024 bytes [-Wframe-larger-than=] > > gcc version 5.3.1 20151219 (Ubuntu 5.3.1-4ubuntu1) > > Cc: Armin Schindler > Cc: Karsten Keil > Signed-off-by: Tim Gardner > --- > drivers/isdn/hardware/eicon/divasfunc.c | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/drivers/isdn/hardware/eicon/divasfunc.c b/drivers/isdn/hardware/eicon/divasfunc.c > index 4be5f88..ac4c04a 100644 > --- a/drivers/isdn/hardware/eicon/divasfunc.c > +++ b/drivers/isdn/hardware/eicon/divasfunc.c > @@ -158,10 +158,13 @@ static int __init connect_didd(void) > int x = 0; > int dadapter = 0; > IDI_SYNC_REQ req; > - DESCRIPTOR DIDD_Table[MAX_DESCRIPTORS]; > + DESCRIPTOR *DIDD_Table; > > - DIVA_DIDD_Read(DIDD_Table, sizeof(DIDD_Table)); > + DIDD_Table = kcalloc(MAX_DESCRIPTORS, sizeof(*DIDD_Table), GFP_KERNEL); kmalloc_array()? MBR, Sergei