From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755452AbcAHWLY (ORCPT ); Fri, 8 Jan 2016 17:11:24 -0500 Received: from mail.tpi.com ([74.45.170.26]:49926 "EHLO mail.tpi.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751690AbcAHWLX (ORCPT ); Fri, 8 Jan 2016 17:11:23 -0500 X-Greylist: delayed 370 seconds by postgrey-1.27 at vger.kernel.org; Fri, 08 Jan 2016 17:11:22 EST Subject: Re: [PATCH v4.4-rc8 6/7] isdn: eicon: diddfunc: Silence frame size warning To: Sergei Shtylyov References: <1452256375-24223-1-git-send-email-tim.gardner@canonical.com> <1452256375-24223-7-git-send-email-tim.gardner@canonical.com> <5690163B.7050808@cogentembedded.com> Cc: Armin Schindler , Karsten Keil , netdev@vger.kernel.org, linux-kernel@vger.kernel.org From: Tim Gardner X-Enigmail-Draft-Status: N1110 Message-ID: <56903296.3090701@canonical.com> Date: Fri, 8 Jan 2016 15:05:10 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <5690163B.7050808@cogentembedded.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/08/2016 01:04 PM, Sergei Shtylyov wrote: > Hello. > > On 01/08/2016 03:32 PM, tim.gardner@canonical.com wrote: > >> From: Tim Gardner >> >> drivers/isdn/hardware/eicon/diddfunc.c: In function 'connect_didd': >> drivers/isdn/hardware/eicon/diddfunc.c:77:1: warning: the frame size >> of 1152 bytes is larger than 1024 bytes [-Wframe-larger-than=] >> >> gcc version 5.3.1 20151219 (Ubuntu 5.3.1-4ubuntu1) >> >> Cc: Armin Schindler >> Cc: Karsten Keil >> Signed-off-by: Tim Gardner >> --- >> drivers/isdn/hardware/eicon/diddfunc.c | 17 +++++++++++++---- >> 1 file changed, 13 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/isdn/hardware/eicon/diddfunc.c >> b/drivers/isdn/hardware/eicon/diddfunc.c >> index b0b23ed..a9feb4f 100644 >> --- a/drivers/isdn/hardware/eicon/diddfunc.c >> +++ b/drivers/isdn/hardware/eicon/diddfunc.c >> @@ -52,9 +52,13 @@ static int __init connect_didd(void) >> int x = 0; >> int dadapter = 0; >> IDI_SYNC_REQ req; >> - DESCRIPTOR DIDD_Table[MAX_DESCRIPTORS]; >> + DESCRIPTOR *DIDD_Table; >> >> - DIVA_DIDD_Read(DIDD_Table, sizeof(DIDD_Table)); >> + DIDD_Table = kcalloc(MAX_DESCRIPTORS, sizeof(*DIDD_Table), >> GFP_KERNEL); > > Previously the array didn't seem to be zeroed, perhaps it's better to > use kmalloc_array()? > > [...] > > MHR, Sergei > The last patch in the series (isdn: eicon: consolidate descriptor allocation) consolidates the allocation code into one function. I used kmalloc() there because I noticed that diva_didd_read_adapter_array() does zero the buffer before using it. Do you think that is sufficient ? rtg -- Tim Gardner tim.gardner@canonical.com