From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754579AbcAHWUs (ORCPT ); Fri, 8 Jan 2016 17:20:48 -0500 Received: from mail-lb0-f175.google.com ([209.85.217.175]:33773 "EHLO mail-lb0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754040AbcAHWUq (ORCPT ); Fri, 8 Jan 2016 17:20:46 -0500 Subject: Re: [PATCH v4.4-rc8 6/7] isdn: eicon: diddfunc: Silence frame size warning To: Tim Gardner References: <1452256375-24223-1-git-send-email-tim.gardner@canonical.com> <1452256375-24223-7-git-send-email-tim.gardner@canonical.com> <5690163B.7050808@cogentembedded.com> <56903296.3090701@canonical.com> Cc: Armin Schindler , Karsten Keil , netdev@vger.kernel.org, linux-kernel@vger.kernel.org From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <5690363A.1050400@cogentembedded.com> Date: Sat, 9 Jan 2016 01:20:42 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <56903296.3090701@canonical.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/09/2016 01:05 AM, Tim Gardner wrote: >>> From: Tim Gardner >>> >>> drivers/isdn/hardware/eicon/diddfunc.c: In function 'connect_didd': >>> drivers/isdn/hardware/eicon/diddfunc.c:77:1: warning: the frame size >>> of 1152 bytes is larger than 1024 bytes [-Wframe-larger-than=] >>> >>> gcc version 5.3.1 20151219 (Ubuntu 5.3.1-4ubuntu1) >>> >>> Cc: Armin Schindler >>> Cc: Karsten Keil >>> Signed-off-by: Tim Gardner >>> --- >>> drivers/isdn/hardware/eicon/diddfunc.c | 17 +++++++++++++---- >>> 1 file changed, 13 insertions(+), 4 deletions(-) >>> >>> diff --git a/drivers/isdn/hardware/eicon/diddfunc.c >>> b/drivers/isdn/hardware/eicon/diddfunc.c >>> index b0b23ed..a9feb4f 100644 >>> --- a/drivers/isdn/hardware/eicon/diddfunc.c >>> +++ b/drivers/isdn/hardware/eicon/diddfunc.c >>> @@ -52,9 +52,13 @@ static int __init connect_didd(void) >>> int x = 0; >>> int dadapter = 0; >>> IDI_SYNC_REQ req; >>> - DESCRIPTOR DIDD_Table[MAX_DESCRIPTORS]; >>> + DESCRIPTOR *DIDD_Table; >>> >>> - DIVA_DIDD_Read(DIDD_Table, sizeof(DIDD_Table)); >>> + DIDD_Table = kcalloc(MAX_DESCRIPTORS, sizeof(*DIDD_Table), >>> GFP_KERNEL); >> >> Previously the array didn't seem to be zeroed, perhaps it's better to >> use kmalloc_array()? >> [...] > The last patch in the series (isdn: eicon: consolidate descriptor > allocation) consolidates the allocation code into one function. I used > kmalloc() there because I noticed that diva_didd_read_adapter_array() > does zero the buffer before using it. > > Do you think that is sufficient ? If it worked before your patch, yes. > rtg MBR, Sergei