From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756414AbcAHXzz (ORCPT <rfc822;w@1wt.eu>);
	Fri, 8 Jan 2016 18:55:55 -0500
Received: from mga11.intel.com ([192.55.52.93]:56777 "EHLO mga11.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1756312AbcAHXzy (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 8 Jan 2016 18:55:54 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,541,1444719600"; 
   d="scan'208";a="886845871"
Subject: Re: [RFC 11/13] x86/mm: Build arch/x86/mm/tlb.c even on !SMP
To: Andy Lutomirski <luto@kernel.org>, x86@kernel.org,
        linux-kernel@vger.kernel.org
References: <cover.1452294700.git.luto@kernel.org>
 <a6eab8f94f1c6e0134246e4a21aa8af1cb7155fd.1452294700.git.luto@kernel.org>
Cc: Borislav Petkov <bp@alien8.de>, Brian Gerst <brgerst@gmail.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Oleg Nesterov <oleg@redhat.com>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>
From: Dave Hansen <dave.hansen@linux.intel.com>
Message-ID: <56904C89.8050205@linux.intel.com>
Date: Fri, 8 Jan 2016 15:55:53 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: <a6eab8f94f1c6e0134246e4a21aa8af1cb7155fd.1452294700.git.luto@kernel.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 01/08/2016 03:15 PM, Andy Lutomirski wrote:
> @@ -352,3 +354,5 @@ static int __init create_tlb_single_page_flush_ceiling(void)
>  	return 0;
>  }
>  late_initcall(create_tlb_single_page_flush_ceiling);
> +
> +#endif /* CONFIG_SMP */

Heh, I was about to complain that you #ifdef'd out my lovely INVLPG
tunable.  But I guess on UP you just get flush_tlb_mm_range() from:

> static inline void flush_tlb_mm_range(struct mm_struct *mm,
>            unsigned long start, unsigned long end, unsigned long vmflag)
> {
>         if (mm == current->active_mm)
>                 __flush_tlb_up();
> }

which doesn't even do INVLPG.  How sad.  Poor UP.