From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755588AbcAIQCv (ORCPT ); Sat, 9 Jan 2016 11:02:51 -0500 Received: from mout.web.de ([212.227.17.11]:59022 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755194AbcAIQCt (ORCPT ); Sat, 9 Jan 2016 11:02:49 -0500 Subject: Re: [PATCH 1/2] scripts/gdb: Add version command To: Kieran Bingham , linux-kernel@vger.kernel.org References: <1452171138-22691-1-git-send-email-kieran.bingham@linaro.org> <1452171138-22691-2-git-send-email-kieran.bingham@linaro.org> Cc: peter.griffin@linaro.org, lee.jones@linaro.org, maxime.coquelin@st.com From: Jan Kiszka Message-ID: <56912F22.3030506@web.de> Date: Sat, 9 Jan 2016 17:02:42 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <1452171138-22691-2-git-send-email-kieran.bingham@linaro.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="J3DjpLp4b2gvePfdhCn9t80hCXdbd50Os" X-Provags-ID: V03:K0:wn78rtomk2w22te+D/gWvtF+BPwHetJ7UZbIXL5Bx3iNDoOIJi1 sxGc/qAFhDpo1GneCdsT83JE1ulrpE2N+qJUBKQJszd44gTbpSC+mh5WrE/1528dq+zrF7F 3FE3WVyttcsI1S/1SJZw60s54oNz/YXDr3hPoNSUnirNu4cFhJj4Y3nbLX3ld7e2v3HDVlC XK14li5jMaEIBXnGt+5Cg== X-UI-Out-Filterresults: notjunk:1;V01:K0:0tj/qwOzbvA=:lyNEgcnBAtoZ76mBS9XCkk GbuBK31iJAEHEewy7s9GH4w65eclDVAJglVhyQ+gLMblY3qivOrD8bkygAKmhIhfwJvyXPYSI d02eMhTHUg2t1zw5VKCO0xDHr8tXdlNVGA23iBLaUNJDeOavqif4HBsOn9c7mKqlPzmaHQRTb gtVQhNJylUw+iE0rDqako9n3HtKosE8yEEGTXESdJSmCk40DTm1GzSv7JB7LlaJBiba0fTRVZ GMx9jzEWghGVatYxeahRkAkz5Lx8Tqfhx56UjcbC+qg3z3eGNicF0Rqfl7IY5SNOFPpB1usCZ zd1B7cl9q6vc9/7FE1C96buPuhd7qpKlnPmeXwFysDs+tPQSfcOjCkvBaHZAY9qBbebB1mDXk xZOpgjxEDsWfa9FMnNGKg/ttDtQe9NPuy6E0wfu5tHoGB4IOxqsMxUGJz0+TeaWbm7L+XkjpN 82Unc2BeGrcFuA1VHsYZqni04uuoCqAaXq5tyvQkbq2bhgcKNzBHCvKv1P4sJ7tuT5aXF1P25 IUK2aDy7hq9AASd1Gg9VdaoAqzCR2r3smvVJWPPdYwEkaAk7I7lb+oM65jmyGWQRtHZJdnNZ1 z37btOZwhm+D28OU9dcoD0CV5uhusvB9KsfA5xDoq9n0bMCs0O9PoY9/1iQKOfCPPLwgSG8mH VBNbbbFghOX7icey9RR8mJu26119Kzsbg86fhq+yGffVBUzIJlyIFCKY/ipvkV442LfPRPvMo piLCPuPV/wPft+BLENY7muQ6gyE2kAsPyQkbHGuGYjRehWx7BFopzL3IeD4= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --J3DjpLp4b2gvePfdhCn9t80hCXdbd50Os Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 2016-01-07 13:52, Kieran Bingham wrote: > lx-version Report the Linux Version of the current kernel. >=20 > Add a command to identify the version specified by the banner in the > debugged kernel. >=20 > This lets the user identify the kernel of the running kernel, and will > let later scripts compare the banner of the attached kernel against the= > banner in the vmlinux symbols files to verify that the files are correc= t. >=20 > Signed-off-by: Kieran Bingham > --- > scripts/gdb/linux/proc.py | 27 +++++++++++++++++++++++++++ > scripts/gdb/vmlinux-gdb.py | 1 + > 2 files changed, 28 insertions(+) > create mode 100644 scripts/gdb/linux/proc.py >=20 > diff --git a/scripts/gdb/linux/proc.py b/scripts/gdb/linux/proc.py > new file mode 100644 > index 000000000000..7a2afe60416a > --- /dev/null > +++ b/scripts/gdb/linux/proc.py > @@ -0,0 +1,27 @@ > +# > +# gdb helper commands and functions for Linux kernel debugging > +# > +# Kernel proc information reader > +# > +# Copyright (c) 2016 Linaro Ltd > +# > +# Authors: > +# Kieran Bingham > +# > +# This work is licensed under the terms of the GNU GPL version 2. > +# > + > +import gdb > + pep8 says: scripts/gdb/linux/proc.py:16:1: E302 expected 2 blank lines, found 1 > +class LxVersion(gdb.Command): > + """ Report the Linux Version of the current kernel. > + Equivalent to cat /proc/version on a running target > + """ Minor thing, but for the sake of consistency: Moving the """ into a new line gives an additional empty line at the end of the help output. Other commands, also gdb built-ins, don't do this. > + def __init__(self): > + super(LxVersion, self).__init__("lx-version", gdb.COMMAND_DATA= ) > + > + def invoke(self, arg, from_tty): > + # linux_banner should contain a newline > + gdb.write(gdb.parse_and_eval("linux_banner").string()) > + > +LxVersion() > diff --git a/scripts/gdb/vmlinux-gdb.py b/scripts/gdb/vmlinux-gdb.py > index ce82bf5c3943..d5943eca19cd 100644 > --- a/scripts/gdb/vmlinux-gdb.py > +++ b/scripts/gdb/vmlinux-gdb.py > @@ -29,3 +29,4 @@ else: > import linux.tasks > import linux.cpus > import linux.lists > + import linux.proc >=20 Two options: I can adjust these (and the corresponding issues in patch 2) myself before sending out a merge request to Andrew. Or, if you have more in your queue, I'll wait for a potential longer v2 round. Just let me know. Thanks, Jan --J3DjpLp4b2gvePfdhCn9t80hCXdbd50Os Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlaRLyIACgkQitSsb3rl5xTNUgCfSKG0V39oMmgDBMc7gCSi6kSl egsAn21QsJV7O5vH+TNtLz3dd9/5puDr =ZbIV -----END PGP SIGNATURE----- --J3DjpLp4b2gvePfdhCn9t80hCXdbd50Os--