From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756443AbcAIQ3Z (ORCPT ); Sat, 9 Jan 2016 11:29:25 -0500 Received: from mail-wm0-f43.google.com ([74.125.82.43]:36077 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754236AbcAIQ3W (ORCPT ); Sat, 9 Jan 2016 11:29:22 -0500 Subject: Re: [PATCH 1/2] scripts/gdb: Add version command To: Jan Kiszka , linux-kernel@vger.kernel.org References: <1452171138-22691-1-git-send-email-kieran.bingham@linaro.org> <1452171138-22691-2-git-send-email-kieran.bingham@linaro.org> <56912F22.3030506@web.de> Cc: peter.griffin@linaro.org, lee.jones@linaro.org, maxime.coquelin@st.com From: Kieran Bingham X-Enigmail-Draft-Status: N1110 Message-ID: <56913560.9040002@linaro.org> Date: Sat, 9 Jan 2016 16:29:20 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <56912F22.3030506@web.de> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jan On 09/01/16 16:02, Jan Kiszka wrote: > On 2016-01-07 13:52, Kieran Bingham wrote: >> lx-version Report the Linux Version of the current kernel. >> >> Add a command to identify the version specified by the banner in the >> debugged kernel. >> >> This lets the user identify the kernel of the running kernel, and will >> let later scripts compare the banner of the attached kernel against the >> banner in the vmlinux symbols files to verify that the files are correct. >> >> Signed-off-by: Kieran Bingham >> --- >> scripts/gdb/linux/proc.py | 27 +++++++++++++++++++++++++++ >> scripts/gdb/vmlinux-gdb.py | 1 + >> 2 files changed, 28 insertions(+) >> create mode 100644 scripts/gdb/linux/proc.py >> >> diff --git a/scripts/gdb/linux/proc.py b/scripts/gdb/linux/proc.py >> new file mode 100644 >> index 000000000000..7a2afe60416a >> --- /dev/null >> +++ b/scripts/gdb/linux/proc.py >> @@ -0,0 +1,27 @@ >> +# >> +# gdb helper commands and functions for Linux kernel debugging >> +# >> +# Kernel proc information reader >> +# >> +# Copyright (c) 2016 Linaro Ltd >> +# >> +# Authors: >> +# Kieran Bingham >> +# >> +# This work is licensed under the terms of the GNU GPL version 2. >> +# >> + >> +import gdb >> + > pep8 says: > > scripts/gdb/linux/proc.py:16:1: E302 expected 2 blank lines, found 1 My apologies - I should have run those checks before I sent the patches. I've added it to my checklist, to make sure I do, for any more that I send. > >> +class LxVersion(gdb.Command): >> + """ Report the Linux Version of the current kernel. >> + Equivalent to cat /proc/version on a running target >> + """ > Minor thing, but for the sake of consistency: Moving the """ into a new > line gives an additional empty line at the end of the help output. Other > commands, also gdb built-ins, don't do this. And, I'll try to make sure I copy the style correctly for any follow-ups! > >> + def __init__(self): >> + super(LxVersion, self).__init__("lx-version", gdb.COMMAND_DATA) >> + >> + def invoke(self, arg, from_tty): >> + # linux_banner should contain a newline >> + gdb.write(gdb.parse_and_eval("linux_banner").string()) >> + >> +LxVersion() >> diff --git a/scripts/gdb/vmlinux-gdb.py b/scripts/gdb/vmlinux-gdb.py >> index ce82bf5c3943..d5943eca19cd 100644 >> --- a/scripts/gdb/vmlinux-gdb.py >> +++ b/scripts/gdb/vmlinux-gdb.py >> @@ -29,3 +29,4 @@ else: >> import linux.tasks >> import linux.cpus >> import linux.lists >> + import linux.proc >> > Two options: I can adjust these (and the corresponding issues in patch > 2) myself before sending out a merge request to Andrew. Or, if you have > more in your queue, I'll wait for a potential longer v2 round. Just let > me know. > > Thanks, > Jan If you're happy to do the fix-ups that's fine by me. These two are simple and standalone, so I don't see any point in holding them back. -- Regards Kieran