From: Guenter Roeck <linux@roeck-us.net>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next 1/2] net: tc35815: Fix build error due to missed API change
Date: Sat, 9 Jan 2016 18:48:53 -0800 [thread overview]
Message-ID: <5691C695.1080703@roeck-us.net> (raw)
In-Reply-To: <20160109220924.GF6877@lunn.ch>
On 01/09/2016 02:09 PM, Andrew Lunn wrote:
>>> Hi Guenter
>>>
>>> You fix looks right, but i'm wondering about the code which is being
>>> fixed.
>>>
>>> How can phydev ever evaluate to true, given the break statement? Can
>>> this code every detect multiple PHYs? I think not.
>>>
>>> Either the break needs to be removed, or we just replace the whole lot
>>> with phy_find_first().
>>>
>>
>> Hi Andrew,
>>
>> you are right, the current code is pretty pointless.
>>
>> I would suggest to use phy_find_first().
>
> Me too.
>
>> Should I submit a separate patch, or replace my patch with v2 ?
>
> I say a v2 which uses phy_find_first() and include in the changelog
> why the current code is pointless and so the change to
> phy_find_first().
>
Ok, I'll do that.
Guenter
prev parent reply other threads:[~2016-01-10 2:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-09 21:21 [PATCH -next 1/2] net: tc35815: Fix build error due to missed API change Guenter Roeck
2016-01-09 21:21 ` [PATCH -next 2/2] net: tc35815: Drop unused variable Guenter Roeck
2016-01-09 21:37 ` Andrew Lunn
2016-01-09 21:36 ` [PATCH -next 1/2] net: tc35815: Fix build error due to missed API change Andrew Lunn
2016-01-09 21:50 ` Guenter Roeck
2016-01-09 22:09 ` Andrew Lunn
2016-01-10 2:48 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5691C695.1080703@roeck-us.net \
--to=linux@roeck-us.net \
--cc=andrew@lunn.ch \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox