From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757235AbcAJPQU (ORCPT ); Sun, 10 Jan 2016 10:16:20 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:42370 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756318AbcAJPQS (ORCPT ); Sun, 10 Jan 2016 10:16:18 -0500 Subject: Re: [PATCH -next 1/2] net: bfin_mac: Fix error handling in probe function To: Andrew Lunn References: <1452357427-30578-1-git-send-email-linux@roeck-us.net> <20160109165802.GD28813@lunn.ch> <56914D21.9050804@roeck-us.net> <20160109205240.GA6877@lunn.ch> Cc: "David S. Miller" , adi-buildroot-devel@lists.sourceforge.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org From: Guenter Roeck Message-ID: <569275C0.1040606@roeck-us.net> Date: Sun, 10 Jan 2016 07:16:16 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20160109205240.GA6877@lunn.ch> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/09/2016 12:52 PM, Andrew Lunn wrote: > On Sat, Jan 09, 2016 at 10:10:41AM -0800, Guenter Roeck wrote: >> Hi Andrew, >> >> On 01/09/2016 08:58 AM, Andrew Lunn wrote: >>> Hi Guenter >>> >>> Same fix was submitted yesterday by Sudip Mukherjee. >>> >> >> I missed that one, sorry. >> >> How about drivers/net/ethernet/toshiba/tc35815.c ? It now has an unused >> variable due to e7f4dc3536a4, and it fails to build because of 7f854420fbfe. >> >> Which leads to the question which of the other build failures due to >> 7f854420fbfe have been addressed already. In addition to the toshiba driver, >> I see build failures in drivers/net/ethernet/ti/cpmac.c and possibly >> drivers/staging/octeon/ethernet-rgmii.c (the error message is different, >> so it may be something else). >> >> I don't see patches for those, but I guess I must be blind, so I figure I >> better ask before I send out mine. > > That i have seen so far: > > Wantiq_etp.c: Me > octeon/ethernet-rgmii.c: Me > adi/bfin_mac.c: Sudip Mukerjee I re-posted this one anyway, using phy_find_first. > nxp/lpc_eth.c: Fabio Estevam > > Plus there is an interesting one for micrel.c which is going to have > to wait a while. > How about those ? drivers/net/ethernet/freescale/ucc_geth.c: In function 'uec_configure_serdes': drivers/net/ethernet/freescale/ucc_geth.c:1719:20: error: 'struct phy_device' has no member named 'dev' drivers/net/ethernet/freescale/fs_enet/mac-fec.c: In function 'stop': drivers/net/ethernet/freescale/fs_enet/mac-fec.c:366:36: error: 'struct phy_device' has no member named 'bus' Guenter