From: "Wangnan (F)" <wangnan0@huawei.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: <jolsa@kernel.org>, <namhyung@kernel.or>, <lizefan@huawei.com>,
<pi3orama@163.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/6] perf tools: Improve 'make build-test'
Date: Mon, 11 Jan 2016 10:55:50 +0800 [thread overview]
Message-ID: <569319B6.1050901@huawei.com> (raw)
In-Reply-To: <20160108143252.GG19314@kernel.org>
Hi Jiri,
I think if we can fold the feature checking in build-test then
it can be even faster. We need only 2 feature check result (for
normal building and static building), but in a full build-test
we run 138 rounds feature checking. Would you please give some
help on it?
Now I have a 160 cores server for building perf, currently busy
time and idle time are 5:3 (result from top. I use 1s interval.
Each test case takes about 8s, in about 5 seconds I can see
full of 'cc1' in perf top result). A full test-build still require
more than 0.3 hours (8s * 34 cases * 2 (with and without O) *
2 (Makefile and Makefile.perf) = 1088 seconds).
Thank you.
On 2016/1/8 22:32, Arnaldo Carvalho de Melo wrote:
> Em Fri, Jan 08, 2016 at 02:23:55PM +0000, Wang Nan escreveu:
>> There are some bugs and inconveniences in 'make build-test', causes
>> people with strong motivation to avoid writing to source directory
>> and people don't have plenty of time skip build-test before sending
>> patches.
>>
>> Patch 1 - 3 fixes some existing bug. Patch 4 speedup the test.
>> Patch 5 and 6 makes build-test obey 'O' option passes from cmdline
>> of the first 'make'.
>>
>> With these 6 patches I make build-test success in my environment
>> fully success the first time.
> Hey, I owe you some beer or other stuff you like first time we meet, now
> waiting for Jiri to chime in...
>
> Thanks!
>
> - Arnaldo
>
>> Wang Nan (6):
>> perf tools: Add -lutil in python lib list for broken python-config
>> perf tools: Add missing headers in perf's MANIFEST
>> perf tools: Fix phony build target for build-test
>> perf tools: Set parallel making options build-test
>> perf tools: Pass O option to Makefile.perf in build-test
>> perf tools: Test correct path of perf in build-test
>>
>> tools/perf/MANIFEST | 2 ++
>> tools/perf/config/Makefile | 2 +-
>> tools/perf/tests/make | 56 +++++++++++++++++++++++++++++++++-------------
>> 3 files changed, 43 insertions(+), 17 deletions(-)
>>
>> --
>> 1.8.3.4
next prev parent reply other threads:[~2016-01-11 2:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-08 14:23 [PATCH 0/6] perf tools: Improve 'make build-test' Wang Nan
2016-01-08 14:23 ` [PATCH 1/6] perf tools: Add -lutil in python lib list for broken python-config Wang Nan
2016-01-11 9:28 ` Jiri Olsa
2016-01-11 9:44 ` Wangnan (F)
2016-01-11 9:50 ` Wangnan (F)
2016-01-12 9:41 ` Jiri Olsa
2016-01-08 14:23 ` [PATCH 2/6] perf tools: Add missing headers in perf's MANIFEST Wang Nan
2016-01-09 16:37 ` [tip:perf/core] perf tools: Add missing headers in perf' s MANIFEST tip-bot for Wang Nan
2016-01-11 9:43 ` [PATCH] perf tools: Add missing sources in perf's MANIFEST Jiri Olsa
2016-01-11 9:46 ` Wangnan (F)
2016-01-11 14:12 ` Arnaldo Carvalho de Melo
2016-01-08 14:23 ` [PATCH 3/6] perf tools: Fix phony build target for build-test Wang Nan
2016-01-11 9:29 ` Jiri Olsa
2016-01-08 14:23 ` [PATCH 4/6] perf tools: Set parallel making options build-test Wang Nan
2016-01-11 9:38 ` Jiri Olsa
2016-01-08 14:24 ` [PATCH 5/6] perf tools: Pass O option to Makefile.perf in build-test Wang Nan
2016-01-08 14:24 ` [PATCH 6/6] perf tools: Test correct path of perf " Wang Nan
2016-01-08 14:32 ` [PATCH 0/6] perf tools: Improve 'make build-test' Arnaldo Carvalho de Melo
2016-01-11 2:55 ` Wangnan (F) [this message]
2016-01-11 8:46 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569319B6.1050901@huawei.com \
--to=wangnan0@huawei.com \
--cc=acme@kernel.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=namhyung@kernel.or \
--cc=pi3orama@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox