From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758119AbcAKC5Y (ORCPT ); Sun, 10 Jan 2016 21:57:24 -0500 Received: from szxga01-in.huawei.com ([58.251.152.64]:9177 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757937AbcAKC5X (ORCPT ); Sun, 10 Jan 2016 21:57:23 -0500 Message-ID: <569319B6.1050901@huawei.com> Date: Mon, 11 Jan 2016 10:55:50 +0800 From: "Wangnan (F)" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Arnaldo Carvalho de Melo CC: , , , , Subject: Re: [PATCH 0/6] perf tools: Improve 'make build-test' References: <1452263041-225488-1-git-send-email-wangnan0@huawei.com> <20160108143252.GG19314@kernel.org> In-Reply-To: <20160108143252.GG19314@kernel.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.111.66.109] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020206.569319C8.00EF,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 3f02daa20c4ead63c2dc59ddec52a03c Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jiri, I think if we can fold the feature checking in build-test then it can be even faster. We need only 2 feature check result (for normal building and static building), but in a full build-test we run 138 rounds feature checking. Would you please give some help on it? Now I have a 160 cores server for building perf, currently busy time and idle time are 5:3 (result from top. I use 1s interval. Each test case takes about 8s, in about 5 seconds I can see full of 'cc1' in perf top result). A full test-build still require more than 0.3 hours (8s * 34 cases * 2 (with and without O) * 2 (Makefile and Makefile.perf) = 1088 seconds). Thank you. On 2016/1/8 22:32, Arnaldo Carvalho de Melo wrote: > Em Fri, Jan 08, 2016 at 02:23:55PM +0000, Wang Nan escreveu: >> There are some bugs and inconveniences in 'make build-test', causes >> people with strong motivation to avoid writing to source directory >> and people don't have plenty of time skip build-test before sending >> patches. >> >> Patch 1 - 3 fixes some existing bug. Patch 4 speedup the test. >> Patch 5 and 6 makes build-test obey 'O' option passes from cmdline >> of the first 'make'. >> >> With these 6 patches I make build-test success in my environment >> fully success the first time. > Hey, I owe you some beer or other stuff you like first time we meet, now > waiting for Jiri to chime in... > > Thanks! > > - Arnaldo > >> Wang Nan (6): >> perf tools: Add -lutil in python lib list for broken python-config >> perf tools: Add missing headers in perf's MANIFEST >> perf tools: Fix phony build target for build-test >> perf tools: Set parallel making options build-test >> perf tools: Pass O option to Makefile.perf in build-test >> perf tools: Test correct path of perf in build-test >> >> tools/perf/MANIFEST | 2 ++ >> tools/perf/config/Makefile | 2 +- >> tools/perf/tests/make | 56 +++++++++++++++++++++++++++++++++------------- >> 3 files changed, 43 insertions(+), 17 deletions(-) >> >> -- >> 1.8.3.4